Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1216177rwl; Fri, 31 Mar 2023 08:09:29 -0700 (PDT) X-Google-Smtp-Source: AK7set8tyfXqixtn4AqV/lOLc6NitB2oPs6r4i1RVFQrxLaLPcP/5CJUDmOA2s6x2kpI5h4opGkC X-Received: by 2002:a05:6a20:bca8:b0:da:e44f:5284 with SMTP id fx40-20020a056a20bca800b000dae44f5284mr20269192pzb.30.1680275369416; Fri, 31 Mar 2023 08:09:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680275369; cv=none; d=google.com; s=arc-20160816; b=X32sGQg06TMGKWpuC8F2cwEN2ca9C4jc3D5kZpruyJpwTgxeIApx5j3ASzaMbycm09 t1Pg89STcIFqFliXtKWXhM0EjlSpIjGaXN+5bq86EP7PFG7Iz3618d9Z+n+ns+dgpITL 9lvP5uggHIdi+w+etA1/inl/Xb7oQJlw+dr93qr3Xosu7Sldc/ujqwqN/c8M+2UmRt1W J8frH7FG88so4UAFMFoSpzmU74bjsnxbmXxnX8dwQmJEvtFHikHoeZrizKEsjQS80gYJ /ffs5xqonj2l2XrTGrs9i/kPNObrM0OjkSbvnqKfSf680TVaM46VKkJVoFbEpJiA0HWx xJNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=9A81X2Yn+OFTlpr1vExqPxkdFNgIGwkaT0++bws4x8s=; b=VcZaYmA8HAGWt1AvmHEFlarsdz7HRIt5lWQcYCJKUxDZ4CNjAjLzWdDhvhxwGYjNzs wd1T1mHi9+BXfJ/BBmSJo7lg/8tiAAQ5xqr5XNE0jP2Y9TJZ2mPAKT9OeEytkSDNILi4 zIlpQwt9GcWhJekikexnVb+2IXOwBd96bcxZ5Kp6cB6TjQqH6/QfbCksZiZ6TcQAbHkC 72tQ1sdYHokaZGjUf7deGlovTNWsUE1im8Caf3vf60yBeRnWJfj7FUddo04v84FuoL0t vqF2TyX/40CkpHULc85gKph7qfsoWpcFBWib5g0Eolk1y/M0/8J3efabst0wESU+uCfH zbKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZxUr1+bm; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x27-20020aa7957b000000b0059258b3c5cbsi2568500pfq.358.2023.03.31.08.09.21; Fri, 31 Mar 2023 08:09:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZxUr1+bm; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233102AbjCaPBc (ORCPT + 58 others); Fri, 31 Mar 2023 11:01:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232489AbjCaPB0 (ORCPT ); Fri, 31 Mar 2023 11:01:26 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE41FE053 for ; Fri, 31 Mar 2023 08:01:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 55074B83035 for ; Fri, 31 Mar 2023 15:01:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E514CC433D2; Fri, 31 Mar 2023 15:01:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680274881; bh=2xZdzRAuLUerdkuoZqPN6cKExCCDywGDTjQ2X8rwjTw=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=ZxUr1+bmchoU0vyLpxSMW/Mae58LRLCKVoemoV7REalc5VikQQkZPybfglCncxGT6 tUY6wpXxsgIRLmmfuNTrRd28pr+Zc+HSAaq9PiBV2KPoOtaTdwWOhJ2gJm8ugwAuSd uydxUrdNSLvRfvjQFMirtK5QknOsQ9LjPDHf+X14LK/PiGJNzrzDCXE7bnh1ELrP5T 6LqbrOASo4iAzCO3ur2vtC///+RRsNraJTKUOVneF7VcsHS/FkQq0VcYyzGWcuXuJ1 /WYHp18aVYuGajiz2Uj01INq/vKKLTLls1R9t1uz6eeMTgzj0qbgphu3qj455b7ntS jUw/dhaqvRvKg== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [v3] wifi: mt76: mt7921: Fix use-after-free in fw features query. From: Kalle Valo In-Reply-To: <51fd8f76494348aa9ecbf0abc471ebe47a983dfd.1679502607.git.lorenzo@kernel.org> References: <51fd8f76494348aa9ecbf0abc471ebe47a983dfd.1679502607.git.lorenzo@kernel.org> To: Lorenzo Bianconi Cc: nbd@nbd.name, linux-wireless@vger.kernel.org, lorenzo.bianconi@redhat.com, Ben Greear User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <168027487819.3675.4308323171224302056.kvalo@kernel.org> Date: Fri, 31 Mar 2023 15:01:19 +0000 (UTC) X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Lorenzo Bianconi wrote: > From: Ben Greear > > Stop referencing 'features' memory after release_firmware is called. > > Fixes this crash: > > RIP: 0010:mt7921_check_offload_capability+0x17d > mt7921_pci_probe+0xca/0x4b0 > ... > > Signed-off-by: Ben Greear > Signed-off-by: Lorenzo Bianconi > Acked-by: Felix Fietkau Patch applied to wireless.git, thanks. 2ceb76f734e3 wifi: mt76: mt7921: Fix use-after-free in fw features query. -- https://patchwork.kernel.org/project/linux-wireless/patch/51fd8f76494348aa9ecbf0abc471ebe47a983dfd.1679502607.git.lorenzo@kernel.org/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches