Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <317782bf-b12a-b6b8-8f08-5e4e19f3b309@gmail.com>
Date:   Fri, 31 Mar 2023 15:34:16 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.2
Subject: Re: [PATCH 0/2] RTW88 USB bug fixes
Content-Language: en-US
To:     Sascha Hauer <s.hauer@pengutronix.de>,
        linux-wireless <linux-wireless@vger.kernel.org>
Cc:     Hans Ulli Kroll <linux@ulli-kroll.de>,
        Larry Finger <Larry.Finger@lwfinger.net>,
        Pkshih <pkshih@realtek.com>, Tim K <tpkuester@gmail.com>,
        Nick Morrow <morrownr@gmail.com>,
        Viktor Petrenko <g0000ga@gmail.com>,
        Andreas Henriksson <andreas@fatal.se>,
        ValdikSS <iam@valdikss.org.ru>, kernel@pengutronix.de,
        stable@vger.kernel.org
References: <20230331121054.112758-1-s.hauer@pengutronix.de>
From:   "Alex G." <mr.nuke.me@gmail.com>
In-Reply-To: <20230331121054.112758-1-s.hauer@pengutronix.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/31/23 07:10, Sascha Hauer wrote:
> This series fixes two bugs in the RTW88 USB driver I was reported from
> several people and that I also encountered myself.
> 
> The first one resulted in "timed out to flush queue 3" messages from the
> driver and sometimes a complete stall of the TX queues.
> 
> The second one is specific to the RTW8821CU chipset. Here 2GHz networks
> were hardly seen and impossible to connect to. This goes down to
> misinterpreting the rfe_option field in the efuse.

I applied both these patches, tested an 8821CU, and the news are good:

The number of kernel warnings and adapter hangs has gone down considerably.

The signal levels on 2.4GHz bands have improved noticeably. There is the 
occasional station coming in 30dB lower than on nearby adapters. I 
wasn't able to find a pattern here.

I can now run these adapters in IBSS and 802.11s modes on the 2.4 GHz 
band. That was not possible before.

I am impressed with the improvements in these patches. For the series:

Tested-by: Alexandru gagniuc <mr.nuke.me@gmail.com>
>
> Sascha Hauer (2):
>    wifi: rtw88: usb: fix priority queue to endpoint mapping
>    wifi: rtw88: rtw8821c: Fix rfe_option field width
> 
>   drivers/net/wireless/realtek/rtw88/rtw8821c.c |  3 +-
>   drivers/net/wireless/realtek/rtw88/usb.c      | 70 +++++++++++++------
>   2 files changed, 48 insertions(+), 25 deletions(-)
>