Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Larry Finger <larry.finger@gmail.com>
Message-ID: <4a76b5fe-c3d6-de44-c627-3f48fafdd905@lwfinger.net>
Date:   Fri, 31 Mar 2023 21:05:49 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH 0/2] RTW88 USB bug fixes
Content-Language: en-US
To:     "Alex G." <mr.nuke.me@gmail.com>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        linux-wireless <linux-wireless@vger.kernel.org>
Cc:     Hans Ulli Kroll <linux@ulli-kroll.de>, Pkshih <pkshih@realtek.com>,
        Tim K <tpkuester@gmail.com>, Nick Morrow <morrownr@gmail.com>,
        Viktor Petrenko <g0000ga@gmail.com>,
        Andreas Henriksson <andreas@fatal.se>,
        ValdikSS <iam@valdikss.org.ru>, kernel@pengutronix.de,
        stable@vger.kernel.org
References: <20230331121054.112758-1-s.hauer@pengutronix.de>
 <317782bf-b12a-b6b8-8f08-5e4e19f3b309@gmail.com>
From:   Larry Finger <Larry.Finger@lwfinger.net>
In-Reply-To: <317782bf-b12a-b6b8-8f08-5e4e19f3b309@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 3/31/23 15:34, Alex G. wrote:
> On 3/31/23 07:10, Sascha Hauer wrote:
>> This series fixes two bugs in the RTW88 USB driver I was reported from
>> several people and that I also encountered myself.
>>
>> The first one resulted in "timed out to flush queue 3" messages from the
>> driver and sometimes a complete stall of the TX queues.
>>
>> The second one is specific to the RTW8821CU chipset. Here 2GHz networks
>> were hardly seen and impossible to connect to. This goes down to
>> misinterpreting the rfe_option field in the efuse.
> 
> I applied both these patches, tested an 8821CU, and the news are good:
> 
> The number of kernel warnings and adapter hangs has gone down considerably.
> 
> The signal levels on 2.4GHz bands have improved noticeably. There is the 
> occasional station coming in 30dB lower than on nearby adapters. I wasn't able 
> to find a pattern here.
> 
> I can now run these adapters in IBSS and 802.11s modes on the 2.4 GHz band. That 
> was not possible before.
> 
> I am impressed with the improvements in these patches. For the series:
> 
> Tested-by: Alexandru gagniuc <mr.nuke.me@gmail.com>
>>
>> Sascha Hauer (2):
>>    wifi: rtw88: usb: fix priority queue to endpoint mapping
>>    wifi: rtw88: rtw8821c: Fix rfe_option field width
>>
>>   drivers/net/wireless/realtek/rtw88/rtw8821c.c |  3 +- >>   drivers/net/wireless/realtek/rtw88/usb.c      | 70 +++++++++++++------
>>   2 files changed, 48 insertions(+), 25 deletions(-)

I can confirm that these changes cleared up my problems with the "timed out to 
flush queue" warnings that caused a problem before with my rtw8822bu.

Tested-by: Larry Finger <Larry,Finger@lwfinger.net>

Thanks,

Larry