Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp4916265rwl; Mon, 3 Apr 2023 11:25:29 -0700 (PDT) X-Google-Smtp-Source: AKy350bJXJrce/kHXVLaarOuH25fnXbERyKPkcTpQjwOPrOO56BR2EmK97TrfrBwO7p6k7pYK7DQ X-Received: by 2002:a17:906:4ed4:b0:878:61d8:d7c2 with SMTP id i20-20020a1709064ed400b0087861d8d7c2mr36532298ejv.39.1680546329217; Mon, 03 Apr 2023 11:25:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680546329; cv=none; d=google.com; s=arc-20160816; b=oWZy8LBkD2cMGnZ2kL9Q7HIIoVWItb7eDt+fgZ3UZ26Q6gVV9A2l3Yu2llgXFl5PgP n720m9ACla0C8+C2G5A+R/+xk65P39iHp3uTL9JfC6icRqUVF2UvkVd44DLbU7/LbkJR q4v0p7x3J/4Xi53+uPJVWfKWylzEcTQDf4P76NGhdJKDTTX8n/MmzXP5L7QrOY/CJ5pr kOlV9kL4+CUleM1ov0+5LTXvGwgEsNBCCdNnZL7ToG5SqZsc+kkhztquVWWQDAVe/AxJ x6/n6K+NuzBlynJ+Ryp9cCbDO5dTP7HKuc/DeFPWFkH7if3k9vp7MyfJuM8AGHOyt6Yz x6KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=ioc0k7k141HNKS9uCRmpKF1n9VUBs8vAOc7wX3+Zsfs=; b=hgC81f5Mu1I04YjAXKgfsvB8jQZn+nVxWSfz1bn0QiNrWwvo3VTB9T9v8b50Ct7XW0 ABq28Drs9tmZH2GRiv264fiOS9lmXpXfH4moHWQBOxbCql5A/cj1LNs353LZLyiGrZSC UUjzy5ZZzYfvKC9Y8B+L67Q3QL2eWnmUDR+Mj84gknhYMrYDBIpthO1wXTpMJEgcm6SU GuOCosmibPVFJ7oNTFaEwjaPdE8yyDQKrcGXV56zMRHqAoIRMa0FjOvbA15JFgVC0GbI BtsGyST3oyi8FC/2Tic+W4/bL4qjGj1rqxbjF5tTBqROFpFm16qwQ3bDHRHoSXB0VJOi Jnkg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HsjeXKwa; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r2-20020a170906c28200b0093f7d33443fsi7613110ejz.349.2023.04.03.11.25.08; Mon, 03 Apr 2023 11:25:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HsjeXKwa; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232560AbjDCSHI (ORCPT + 59 others); Mon, 3 Apr 2023 14:07:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232564AbjDCSG5 (ORCPT ); Mon, 3 Apr 2023 14:06:57 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B084A358E for ; Mon, 3 Apr 2023 11:06:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3895262447 for ; Mon, 3 Apr 2023 18:06:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A376EC433EF; Mon, 3 Apr 2023 18:06:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680545211; bh=C0jeJzYSg+7BaH8JhWlX6pjE/fzFELNGkqiQ29PPBZo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=HsjeXKwa8i47X7mJp2jctTv/2pxF8ualDrv9Mgoj2yp4EXZCaHBW9bRk0emzWsyum B9wZqA06UWW2AFvPjzuaE57PqAuqyL9wP5c7sDW57eD/Zhgz76hUjqHVEjqR32/nt8 4imiLWNlA754pmCiWTl3uyTMAU7dTvluTTtSASZp3NJtSo7okoxRhrStXUkATMY3rC ZzGe16aXTj63KDpetsQS9nY3kN3Td2w49RKuVg7Zn7cjSTcikEQJuM5ea3Z5rO+8Bz RRUUBL6w8asJBLy5d0YPpLT+aZGgBoqbcOZtezHVbly6AmphjxnPtWQqoEzxY3flJW GS1ijf7i54hYg== From: Kalle Valo To: Ping-Ke Shih Cc: "linux-wireless\@vger.kernel.org" , "Bernie Huang" , "arnd\@arndb.de" Subject: Re: rtw88/rtw89: command/event structure handling References: <20230310034631.45299-1-pkshih@realtek.com> <20230310034631.45299-2-pkshih@realtek.com> <87zg8emn4i.fsf@kernel.org> <87a5zpb71j.fsf_-_@kernel.org> <871ql1aym9.fsf@kernel.org> <84e5fadd204807a6de84376f76d405a63198e055.camel@realtek.com> Date: Mon, 03 Apr 2023 21:06:46 +0300 In-Reply-To: <84e5fadd204807a6de84376f76d405a63198e055.camel@realtek.com> (Ping-Ke Shih's message of "Mon, 3 Apr 2023 14:09:51 +0000") Message-ID: <87ttxwalhl.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Ping-Ke Shih writes: >> > Downside of course is that there's quite a lot of boilerplate code but I >> > still consider that positives outweight the negatives. Thoughts? >> > >> > And I'll emphasise that this is not a blocker for anything but it would >> > be nice to clean this up both in rtw88 and rtw89 at some point, if we >> > can. > > Since they will be a lot of works and I have a lot of local patches on > hand, can I apply these rules to the patches and submit them ahead? > Until all things or a bunch of conversion are completed (maybe weeks or > one or two months later), I can submit patches that only convert > these H2C/C2H with new rules. > > Does it work to you? Yes, that's totally fine. No rush with this cleanup. Thanks for working on this. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches