Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bd40816c-9759-a0af-9075-cc684f81fd70@quicinc.com>
Date:   Thu, 6 Apr 2023 18:47:07 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH] wifi: mac80211: Add support to randomize TA of auth and
 deauth frames
To:     Johannes Berg <johannes@sipsolutions.net>,
        <linux-wireless@vger.kernel.org>
References: <20230112012415.167556-3-quic_vjakkam@quicinc.com>
 <20230307102225.74883-1-johannes@sipsolutions.net>
Content-Language: en-US
From:   Veerendranath Jakkam <quic_vjakkam@quicinc.com>
In-Reply-To: <20230307102225.74883-1-johannes@sipsolutions.net>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 3/7/2023 3:52 PM, Johannes Berg wrote:
> ---
> So this is the patch I ended up with after some cleanups, but
> then at the end I noticed you didn't unset the temp address
> when the remain-on-channel expires, and wasn't sure exactly
> how that should be handled, and you probably have the better
> test setup right now too ...
>
> johannes
> ---


Apologies for the delayed response. Thanks for the cleaning up the patch.

Regarding the comment on clearing temp address, I think the temp address 
should get cleared with below changes added in 
ieee80211_roc_notify_destroy() when remain-on-channel expires. Please 
let me know if I am missing something.


> diff --git a/net/mac80211/offchannel.c b/net/mac80211/offchannel.c
> index d78c82d6b696..74d2b826916a 100644
> --- a/net/mac80211/offchannel.c
> +++ b/net/mac80211/offchannel.c
> @@ -187,6 +187,12 @@ static void ieee80211_roc_notify_destroy(struct ieee80211_roc_work *roc)
>   					 roc->mgmt_tx_cookie,
>   					 roc->chan, GFP_KERNEL);
>   
> +	if (!is_zero_ether_addr(roc->sdata->vif.cfg.temp_addr)) {
> +		eth_zero_addr(roc->sdata->vif.cfg.temp_addr);
> +		ieee80211_vif_cfg_change_notify(roc->sdata,
> +						BSS_CHANGED_TEMP_ADDR);
> +	}
> +
>   	list_del(&roc->list);
>   	kfree(roc);
>   }

--

veeru