Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230320133840.30162-1-quic_nmaran@quicinc.com>
In-Reply-To: <20230320133840.30162-1-quic_nmaran@quicinc.com>
From:   Robert Marko <robert.marko@sartura.hr>
Date:   Fri, 7 Apr 2023 10:46:13 +0200
Message-ID: <CA+HBbNFXkOqFr9cKmB+Me3q4pbR31u5d21EuCCUnos7hGQi9RQ@mail.gmail.com>
Subject: Re: [PATCH] wifi: ath11k: Fix invalid management rx frame length issue
To:     Nagarajan Maran <quic_nmaran@quicinc.com>
Cc:     ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
        Bhagavathi Perumal S <quic_bperumal@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Mar 20, 2023 at 2:39=E2=80=AFPM Nagarajan Maran <quic_nmaran@quicin=
c.com> wrote:
>
> From: Bhagavathi Perumal S <quic_bperumal@quicinc.com>
>
> The WMI management rx event has multiple arrays of TLVs, however the comm=
on
> WMI TLV parser won't handle multiple TLV tags of same type.
> So the multiple array tags of WMI management rx TLV is parsed incorrectly
> and the length calculated becomes wrong when the target sends multiple
> array tags.
>
> Add separate TLV parser to handle multiple arrays for WMI management rx
> TLV. This fixes invalid length issue when the target sends multiple array
> tags.
>
> Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.7.0.1-01744-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: Bhagavathi Perumal S <quic_bperumal@quicinc.com>
> Co-developed-by: Nagarajan Maran <quic_nmaran@quicinc.com>
> Signed-off-by: Nagarajan Maran <quic_nmaran@quicinc.com>
>
> ---

We hit the exact error that this patch fixes while updating to FW
2.9.0.1 on IPQ8074 and
it fixed it so:
Tested-by: Robert Marko <robert.marko@sartura.hr>

Regards,
Robert
--=20
Robert Marko
Staff Embedded Linux Engineer
Sartura Ltd.
Lendavska ulica 16a
10000 Zagreb, Croatia
Email: robert.marko@sartura.hr
Web: www.sartura.hr