Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 10 Apr 2023 09:28:14 -0700
From:   Nathan Chancellor <nathan@kernel.org>
To:     gregory.greenman@intel.com
Cc:     johannes@sipsolutions.net, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] wifi: iwlwifi: mvm: fix the order of
 TIMING_MEASUREMENT notifications
Message-ID: <20230410162814.GA2775@dev-arch.thelio-3990X>
References: <20230410140721.897683-1-gregory.greenman@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230410140721.897683-1-gregory.greenman@intel.com>
Precedence: bulk

On Mon, Apr 10, 2023 at 05:07:20PM +0300, gregory.greenman@intel.com wrote:
> From: Gregory Greenman <gregory.greenman@intel.com>
> 
> Host commands and notifications are expected to be ordered in
> iwl_mvm_groups array. Fix the order of two new TIMING_MEASUREMENT
> notifications.
> 
> Fixes: c7eca79def44 ("wifi: iwlwifi: mvm: report hardware timestamps in RX/TX status")
> Reported-by: Nathan Chancellor <nathan@kernel.org>
> Link: https://lore.kernel.org/linux-wireless/20230331175121.GA3127046@dev-arch.thelio-3990X/
> Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>

Thanks for the quick fix! It appears to work for me.

Tested-by: Nathan Chancellor <nathan@kernel.org>

> ---
>  drivers/net/wireless/intel/iwlwifi/mvm/ops.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c
> index 56a4e9d6ae33..6f082059025a 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c
> +++ b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c
> @@ -472,8 +472,8 @@ static const struct iwl_hcmd_names iwl_mvm_legacy_names[] = {
>  	HCMD_NAME(SCAN_OFFLOAD_PROFILES_QUERY_CMD),
>  	HCMD_NAME(BT_COEX_UPDATE_REDUCED_TXP),
>  	HCMD_NAME(BT_COEX_CI),
> -	HCMD_NAME(WNM_80211V_TIMING_MEASUREMENT_CONFIRM_NOTIFICATION),
>  	HCMD_NAME(WNM_80211V_TIMING_MEASUREMENT_NOTIFICATION),
> +	HCMD_NAME(WNM_80211V_TIMING_MEASUREMENT_CONFIRM_NOTIFICATION),
>  	HCMD_NAME(PHY_CONFIGURATION_CMD),
>  	HCMD_NAME(CALIB_RES_NOTIF_PHY_DB),
>  	HCMD_NAME(PHY_DB_CMD),
> -- 
> 2.38.1
>