Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <67d681751d9af226fc84c533649d620ea1bb7664.camel@sipsolutions.net>
Subject: Re: [PATCH] wifi: mac80211: Add support to randomize TA of auth and
 deauth frames
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Veerendranath Jakkam <quic_vjakkam@quicinc.com>,
        linux-wireless@vger.kernel.org
Date:   Tue, 11 Apr 2023 12:15:38 +0200
In-Reply-To: <bd40816c-9759-a0af-9075-cc684f81fd70@quicinc.com>
References: <20230112012415.167556-3-quic_vjakkam@quicinc.com>
         <20230307102225.74883-1-johannes@sipsolutions.net>
         <bd40816c-9759-a0af-9075-cc684f81fd70@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2023-04-06 at 18:47 +0530, Veerendranath Jakkam wrote:
> On 3/7/2023 3:52 PM, Johannes Berg wrote:
> > ---
> > So this is the patch I ended up with after some cleanups, but
> > then at the end I noticed you didn't unset the temp address
> > when the remain-on-channel expires, and wasn't sure exactly
> > how that should be handled, and you probably have the better
> > test setup right now too ...

> Apologies for the delayed response. Thanks for the cleaning up the patch.
>=20
> Regarding the comment on clearing temp address, I think the temp address=
=20
> should get cleared with below changes added in=20
> ieee80211_roc_notify_destroy() when remain-on-channel expires. Please=20
> let me know if I am missing something.
>=20
>=20
> > diff --git a/net/mac80211/offchannel.c b/net/mac80211/offchannel.c
> > index d78c82d6b696..74d2b826916a 100644
> > --- a/net/mac80211/offchannel.c
> > +++ b/net/mac80211/offchannel.c
> > @@ -187,6 +187,12 @@ static void ieee80211_roc_notify_destroy(struct ie=
ee80211_roc_work *roc)
> >   					 roc->mgmt_tx_cookie,
> >   					 roc->chan, GFP_KERNEL);
> >  =20
> > +	if (!is_zero_ether_addr(roc->sdata->vif.cfg.temp_addr)) {
> > +		eth_zero_addr(roc->sdata->vif.cfg.temp_addr);
> > +		ieee80211_vif_cfg_change_notify(roc->sdata,
> > +						BSS_CHANGED_TEMP_ADDR);
> > +	}
> > +
> >   	list_del(&roc->list);
> >   	kfree(roc);
> >   }
>=20

Huh, yeah, looks like I just missed that? Sorry about that.

Seeing that though, I remembered another thing - don't we have to adjust
the merging logic in ieee80211_start_roc_work() and maybe also
ieee80211_coalesce_hw_started_roc()?

johannes