Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Aloka Dixit <quic_alokad@quicinc.com>
Cc:     <ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
        Pradeep Kumar Chitrapu <quic_pradeepc@quicinc.com>
Subject: Re: [PATCH v2 06/11] wifi: ath12k: prepare EHT peer assoc parameters
References: <20230403225146.14139-1-quic_alokad@quicinc.com>
        <20230403225146.14139-7-quic_alokad@quicinc.com>
        <b3282c7d-07c5-8657-fca2-c286f82cb235@quicinc.com>
Date:   Wed, 12 Apr 2023 12:19:03 +0300
In-Reply-To: <b3282c7d-07c5-8657-fca2-c286f82cb235@quicinc.com> (Aloka Dixit's
        message of "Mon, 10 Apr 2023 09:22:53 -0700")
Message-ID: <87r0sp8nlk.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Aloka Dixit <quic_alokad@quicinc.com> writes:

> On 4/3/2023 3:51 PM, Aloka Dixit wrote:
>
>> Add new parameters and prepare the association data for an EHT peer.
>> MCS data uses the format described in IEEE P802.11be/D2.0, May 2022,
>> 9.4.2.313.4, convert it into the format expected by the firmware.
>>
>> +	case IEEE80211_STA_RX_BW_320:
>> +		bw = &eht_cap->eht_mcs_nss_supp.bw._320;
>> +		ath12k_mac_set_eht_mcs(bw->rx_tx_mcs9_max_nss,
>> +				       bw->rx_tx_mcs9_max_nss,
>> +				       bw->rx_tx_mcs11_max_nss,
>> +				       bw->rx_tx_mcs13_max_nss,
>> +				       &rx_mcs[WMI_EHTCAP_TXRX_MCS_NSS_IDX_320],
>> +				       &tx_mcs[WMI_EHTCAP_TXRX_MCS_NSS_IDX_320]);
>> +		arg->peer_eht_mcs_count++;
>> +		fallthrough;
>> +
>> +	case IEEE80211_STA_RX_BW_160:
>> +		bw = &eht_cap->eht_mcs_nss_supp.bw._160;
>> +		ath12k_mac_set_eht_mcs(bw->rx_tx_mcs9_max_nss,
>> +				       bw->rx_tx_mcs9_max_nss,
>> +				       bw->rx_tx_mcs11_max_nss,
>> +				       bw->rx_tx_mcs13_max_nss,
>> +				       &rx_mcs[WMI_EHTCAP_TXRX_MCS_NSS_IDX_160],
>> +				       &tx_mcs[WMI_EHTCAP_TXRX_MCS_NSS_IDX_160]);
>> +		fallthrough;
>> +
>
> 'arg->peer_eht_mcs_count++' is missing for 160 MHz case.
> Should I send a follow-up now for the series or wait for comments on
> the remaining part for some time.

Sending a new version sounds like the best.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches