Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Ping-Ke Shih <pkshih@realtek.com>
Cc:     <tony0620emma@gmail.com>, <phhuang@realtek.com>,
        <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/7] wifi: rtw88: add port switch for AP mode
References: <20230401124410.33221-1-pkshih@realtek.com>
        <20230401124410.33221-3-pkshih@realtek.com>
Date:   Wed, 12 Apr 2023 15:35:18 +0300
In-Reply-To: <20230401124410.33221-3-pkshih@realtek.com> (Ping-Ke Shih's
        message of "Sat, 1 Apr 2023 20:44:05 +0800")
Message-ID: <87bkjt8eih.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Ping-Ke Shih <pkshih@realtek.com> writes:

> From: Po-Hao Huang <phhuang@realtek.com>
>
> Switch port settings if AP mode does not start on port 0 because of
> hardware limitation. For some ICs, beacons on ports other than zero
> could misbehave and do not issue properly, to fix this we change AP
> VIFs to port zero when multiple interfaces is active.
>
> Signed-off-by: Po-Hao Huang <phhuang@realtek.com>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>

[...]

> +static void rtw_port_switch_iter(void *data, u8 *mac, struct ieee80211_vif *vif)
> +{
> +	struct rtw_iter_port_switch_data *iter_data = data;
> +	struct rtw_dev *rtwdev = iter_data->rtwdev;
> +	struct rtw_vif *rtwvif_target = (struct rtw_vif *)vif->drv_priv;
> +	struct rtw_vif *rtwvif_ap = iter_data->rtwvif_ap;
> +	const struct rtw_hw_reg *reg1, *reg2;
> +
> +	if (rtwvif_target->port != RTW_PORT_0)
> +		return;
> +
> +	rtw_info(rtwdev, "AP port switch from %d -> %d\n", rtwvif_ap->port,
> +		 rtwvif_target->port);

This looks more like a debug message. In normal operations (after the
initialisation) the drivers should be quiet and only print messages when
something unexpected happens.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches