Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <11811efa-7722-fded-b0bb-64808cfc1336@intel.com>
Date:   Wed, 12 Apr 2023 09:12:52 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH] wifi: mt76: mt7921: fix missing unwind goto in
 `mt7921u_probe`
To:     Jiefeng Li <jiefeng_li@hust.edu.cn>, Felix Fietkau <nbd@nbd.name>,
        "Lorenzo Bianconi" <lorenzo@kernel.org>,
        Ryder Lee <ryder.lee@mediatek.com>,
        "Shayne Chen" <shayne.chen@mediatek.com>,
        Sean Wang <sean.wang@mediatek.com>,
        "Kalle Valo" <kvalo@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
CC:     Dongliang Mu <dzm91@hust.edu.cn>, <linux-wireless@vger.kernel.org>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-mediatek@lists.infradead.org>
References: <20230412062234.4810-1-jiefeng_li@hust.edu.cn>
Content-Language: en-US
From:   "Samudrala, Sridhar" <sridhar.samudrala@intel.com>
In-Reply-To: <20230412062234.4810-1-jiefeng_li@hust.edu.cn>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d0o5OHBPT1RoR2lEeFNHeG9GL0M2MFAxWjd2azhydDNwbzNoUFpCRkJkZDFT?=
 =?utf-8?B?akhTU0ZyYmxYRUJqS3pNVlJ2RUkxeE1kZkVhbjVMOE5GeVBFK3lYbTl3MEgv?=
 =?utf-8?B?djE2RVU2akMwbGZ3ZGdxSmxGVS9iZlJrSndzUnB2a0wrQWhkSTQ4NUREL0VN?=
 =?utf-8?B?NFhCOTdiNjZMaGxsa0w2VnNpeGVBRDZpaHBYTWJ5cDZ1dkRaTndBckJVMEc4?=
 =?utf-8?B?Ti83eHV3VmtxdndCd1AzSWdlNTMxWkprZUpzVElOckRkd3R6ZkxrTGV5ZDha?=
 =?utf-8?B?OE45U0UzdDhyMlU1QW5pMVp4SVpEMmU0VkpGUTFHempvdmFNQmRFT25aN3l3?=
 =?utf-8?B?VktmMjRxZVZWazRIdTh6RXVxWVZVaGlVS0d5YUVVYmJ1Y2xxYmZBbGxoSlp5?=
 =?utf-8?B?UWJLTWFvL2puQU5wWEhWQzJjTUxVM3NYSWxaWEo0TWdQSzNQNVBGZFh0c3Q3?=
 =?utf-8?B?RldUaUJRMktOQUZpNE01M1BHYVFCTGt6V3hOeEV4NHlleGtDZHRvOS8xQkRK?=
 =?utf-8?B?ZUc5RzVuZzQrWnBsa0dlaERBTWRWa01WL1o5NGlDVG1QVTM5bU1HaWJpaEli?=
 =?utf-8?B?a3RaTXR1K1JKOUk0SkNLeXB5a2xVWUx0U3JLZG1WdjVUcGpsVTBZb0ZHUHZU?=
 =?utf-8?B?Z2dwakkzdHVDTlo3cXpVR0pOdkQrUEpidVFJSldhMXlpSDlGNGs0dTVnQnhn?=
 =?utf-8?B?MGlDQzRyTjRjSFhKcjdBTGMvbU1lN2E2c2tKcGkyRHk2TVBEN2ZYMmFUTDNk?=
 =?utf-8?B?a2xIYkw0Smp4Mjl2R0NSZFJuMnlqYThqWjdPUU5oWTMxZUlGU0V4Qmp4MUpV?=
 =?utf-8?B?WjN2YU9NOElOVWVtWGZkVERsakt5VFhlUEtvcUZEZWhJdnczNWduaVRHWU04?=
 =?utf-8?B?Um9YOUl4ZVNpdzlwem50NHR3dXM1SG5jUjdTcHl5VjlJUjhNTzF1cFkzWkpo?=
 =?utf-8?B?bndZK3ErSVBMdDZDMllWNm1iK0w0TE1ubDNLMlNmRlNuQUtVL1RBcURIY1Bh?=
 =?utf-8?B?Mkdxb2h1eUpIYjBYRzliUEZLZ1E3L3JiOXdycFFGbEg0bkFNaEptR2hwOWpv?=
 =?utf-8?B?MkJnN3E3Z2haeXpmQVh5SkRSQW4wTU1BZnExdXJPTVY2MGxWdDBpZjF6dEZm?=
 =?utf-8?B?UjZpUUY3VSt6aFo1WGZQMlBXb0NPSlpsYU4xMVh2SWtnRGh1WUdONkhEWk1E?=
 =?utf-8?B?d2FsanBiQzdra0J6U3lESGI2ZDl4RUFCNUg5dzVQa242WUtTRmx6eWkrRzFj?=
 =?utf-8?B?RFRtRnpoejB0c0dSOWFXM2Jrb1lza2xHNkpoaW1iNWJkdWhPSVFQdWhOQlV0?=
 =?utf-8?B?RG0xVjRSdHJNc3pKWlQzK3hpTUJtaEdraEZaWjZYZXZmdzBjd3pCNnRqUCtq?=
 =?utf-8?B?UmNiYzAxN2dIbHQrSmpzVFhXa1E3UG1tbWcrOHNJejFoQ2ZtNFJHZW5FN3h1?=
 =?utf-8?B?VGRNeXlCdnA2VzM3WUt1TktqTkVwR003QlpmVm5wc0x4a1NSWGlXSEF0SGFD?=
 =?utf-8?B?WGFnY2tLKzY0em9NM1JEOUhGUDk3SGVSNzFtOUpXRUlEMm1ST25RU1JJZkJo?=
 =?utf-8?B?M2FzOU5HckcxV1ZjellPQkNxdHhJV1ZUR2lLVEVndytTU0xFZUJXblZEWDdI?=
 =?utf-8?B?ZmFkRTl2SDMwcXh4UXZxeEVxSnJ4SmdqQmNPTmJ6LzFTSXlPVHZVSm1WV0N3?=
 =?utf-8?B?T0tZbGFzOThJY1JLN05YQ1R4SlBha3dCZGVzSEx2WkYrVW1kN2pPMVhxQTMw?=
 =?utf-8?B?RHhVazNCdk8vM2xRejBMaTJ2eXdhN1A1N3VCTTFKT0pGYWh6Q0lRSmtrc0p6?=
 =?utf-8?B?NlhJSDE1YnFWZE14bXlWOVBhY1VRams3T04wRzRBN092a0NVUlNBb3NPcGlx?=
 =?utf-8?B?c2h0czNyYmRZZjFQd3l1LzZWOWp3V3dGMlo1U2pncDZPUDZNSVMrbWhNbW00?=
 =?utf-8?B?R1BIQ3Q2bk1pYTFseEUzTVVaTU5GVCsxU3UxUmxuYmxyTGN1SlRzcllseXB4?=
 =?utf-8?B?ellrMVhlWFJXWTJlVjhxR2wwVks5aDgzczduUmppZjE3RG54US9nbEk5d0Rr?=
 =?utf-8?B?dnFpWlFkTUJ0ZWN5VlUwOWttMzhtN2RVVU00UHdJRFF4VnNIL21aVzNacTY5?=
 =?utf-8?B?NXNvN0t2Y2xUYmVvMS9yYkU2UDZaTTZUNlNoZStzMUl2SDA1TjN0VEIxS0Y2?=
 =?utf-8?B?YVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 95a27486-f69d-4148-b419-08db3b600322
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4886.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2023 14:12:56.0950
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: S4UPHYlnLNKYs3xVyXxLyj59+yi2Uutx8koJYmiP5ZUiSrKAiQ0CZijRJ0YBO5kwVyh+eak/wLWA5GtGEl6j+3Yw/YscBeWnzZljel74txk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4571
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org


On 4/12/2023 1:22 AM, Jiefeng Li wrote:
> `mt7921u_dma_init` can only return zero or negative number according to its
> definition. When it returns non-zero number, there exists an error and this
> function should handle this error rather than return directly.
> 
> Fixes: 0d2afe09fad5 ("mt76: mt7921: add mt7921u driver")
> Signed-off-by: Jiefeng Li <jiefeng_li@hust.edu.cn>
> Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>

Reviewed-by: Sridhar Samudrala <sridhar.samudrala@intel.com>

> ---
> The issue is discovered by static analysis, and the patch is not tested yet.
> ---
>   drivers/net/wireless/mediatek/mt76/mt7921/usb.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/usb.c b/drivers/net/wireless/mediatek/mt76/mt7921/usb.c
> index 8fef09ed29c9..70c9bbdbf60e 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7921/usb.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/usb.c
> @@ -272,7 +272,7 @@ static int mt7921u_probe(struct usb_interface *usb_intf,
>   
>   	ret = mt7921u_dma_init(dev, false);
>   	if (ret)
> -		return ret;
> +		goto error;
>   
>   	hw = mt76_hw(dev);
>   	/* check hw sg support in order to enable AMSDU */