Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp432981rwe; Fri, 14 Apr 2023 05:15:05 -0700 (PDT) X-Google-Smtp-Source: AKy350arfYftgPOeL+8lPV3WatzHM2UNT75TpUJy9KuRIFtfzo4niLKeDIrbkNdfWnLlAIor1Tfx X-Received: by 2002:a4a:378d:0:b0:542:14df:16c3 with SMTP id r135-20020a4a378d000000b0054214df16c3mr2193655oor.0.1681474505195; Fri, 14 Apr 2023 05:15:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681474505; cv=none; d=google.com; s=arc-20160816; b=gLzMJbwN6Ka2T86BZHnLxDcAs6uGnST9b2uZbnY/3wHbkzwxCZVqiYhBNmjM+MxkOq yvAZtwmir0rpqjVg4dl8qsvQC8sbvFmbA0eAe1Cy/Sr+dHyi7dHvxAbr89QsSLNiCaRt PtJzYzNpkkOGfoGIFJ7D8tZcEx/RXi7jnjnSLUl8A0Sn/OoI4vAdfdr6OWa8EpbLeTMc FwVp7BCD4Z03VNw6rUjvK3FtKmyAt2PZSM+hl1xdqy90eoSPAk68EfiB1wG2+jwh5KLY dp/2fNEls9H3X1gAeO0UO0wTlYAbm0y/SvLojuc4TPjO1kLigZo9hREJT+Jrbqa10rvM 3AIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=xDv3esXSlht4+LUFybe3MNtBZx2XV2qGQnFtT4YUJ+I=; b=C6pUV38ttnpi3M9ruVHL1hA0t/CrX2s0aquMF2EOpBzzr9lWY7TlyE5x7ozLyhePzc UDG/IbnQbcsqTE4tSlc5jUdsKtCv1mJm/WxbtVYqBD7VYGTz+ZA5Nnl+8+xZX+AV9+GK J7f61upyYy2qe+m9UPwYFmx+bo1dzZ+vdGu1EzWQM3/4ekX1xAYrB497gIdl/KtTUbMx 687hikgWsCJgQVNfov9qEFCOqUT1x3he9T7SAAOx+WXcB/7tHw3N7u5q8H+NQzLh7I64 LPjnCEYaPaV98MqFqoj9/wsNQa6gh+cTEMyxJ3bvss8J1Ma7E7aJP8H/HyY3eAlgoddg qJMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hcfhiXtp; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i22-20020a4addd6000000b005419ad122e8si3646435oov.78.2023.04.14.05.14.54; Fri, 14 Apr 2023 05:15:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hcfhiXtp; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230305AbjDNMGV (ORCPT + 62 others); Fri, 14 Apr 2023 08:06:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230344AbjDNMGQ (ORCPT ); Fri, 14 Apr 2023 08:06:16 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73CF4127 for ; Fri, 14 Apr 2023 05:05:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EB48061601 for ; Fri, 14 Apr 2023 12:05:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 62D62C433D2; Fri, 14 Apr 2023 12:05:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681473956; bh=FwNrvNe4VWH+lWbrqNpkKbPN7HxJu0u/3f/Jb+iLL8k=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=hcfhiXtpWrB3GceYpwIAZOvXgvInJqn9serexzBJLck6shITnU8Pe5BHL1LzRxWwM weJERWfzYweZj2KRwuLn7qPJAYWyx9kd3AziU/z5hXG3mrytg9EcUmDhG4Flp0UhNq LrZcR2bqm6EA9MnkB7tQehXm6Tm+P12ZhVy+OlFfwVdWn6ePT/Fzh11W/IDuSN56nL RH7Zbl7HEpCNUVEvJIfS65E+G8ELjAQeVNWS0aNc28q1QMKHZsPZ80Xcx6OaI4dSal qW2eebNUiI7EGO0CnKPX+sS+kY6yUjX+2bv5JCq7j4rmIAeeKNcbbRwZEj2W3EZg9l DW4lAKgrPwpzw== From: Kalle Valo To: Ping-Ke Shih Cc: , , Subject: Re: [PATCH v6 2/5] wifi: rtw89: add function to wait for completion of TX skbs References: <20230411124832.14965-1-pkshih@realtek.com> <20230411124832.14965-3-pkshih@realtek.com> Date: Fri, 14 Apr 2023 15:05:50 +0300 In-Reply-To: <20230411124832.14965-3-pkshih@realtek.com> (Ping-Ke Shih's message of "Tue, 11 Apr 2023 20:48:29 +0800") Message-ID: <87ildy7joh.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Ping-Ke Shih writes: > From: Po-Hao Huang > > Allocate a per-skb completion to track those skbs we are interested in > and wait for them to complete transmission with TX status. > > Normally, the completion object is freed by wait side, but it could be > timeout result that complete side should free the object instead. Add a > owner field with a spin_lock to determine which side should free the > object. I'll change the last sentence to mention RCU so that it matches the code. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches