Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Larry Finger <larry.finger@gmail.com>
Message-ID: <c8d4b1e0-1fb4-4bcd-cff0-c108e9ee1e7a@lwfinger.net>
Date:   Sat, 15 Apr 2023 12:22:58 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: Question about rtw88 patches
Content-Language: en-US
To:     Ping-Ke Shih <pkshih@realtek.com>,
        "kvalo@kernel.org" <kvalo@kernel.org>
Cc:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>
References: <3aaaceb0-1518-49b6-ca18-f7c46c35c65c@lwfinger.net>
 <e8e70392bb38ee44f29fd0dc2522daa8340cf609.camel@realtek.com>
From:   Larry Finger <Larry.Finger@lwfinger.net>
In-Reply-To: <e8e70392bb38ee44f29fd0dc2522daa8340cf609.camel@realtek.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/14/23 23:00, Ping-Ke Shih wrote:
> On Fri, 2023-04-14 at 14:50 -0500, Larry Finger wrote:
>>
>> Kalle,
>>
>> Has something gone wrong with Sasha's rtw88 patches to fix the hardware queue
>> selection in rtw88 [1], and the corresponding rfe field width fix [2]. These two
>> patches are included in my GitHub repo for rtw88, and they fix the ubiquitous
>> "timed out to flush queue" warnings.
>>
>> Larry
>>
>> [1]
>> https://lore.kernel.org/linux-wireless/20230404072508.578056-2-s.hauer@pengutronix.de/
>> [2]
>> https://lore.kernel.org/linux-wireless/20230404072508.578056-3-s.hauer@pengutronix.de/
>>
> 
> Hi Larry,
> 
> I think this is because I have some suggestions of [2] to improve further.
> Do you think we can take this temporary version in advance?
> 

Ping-Ke,

I think these two should be applied as soon as possible.  Any further 
improvements should be made on top of [2]. The log spamming that happens without 
these patches is extreme.

Larry