Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] wifi: ath12k: fix missing unwind goto in
 `ath12k_pci_probe`
From:   Kalle Valo <kvalo@kernel.org>
In-Reply-To: <20230417115921.176229-1-lnk_01@hust.edu.cn>
References: <20230417115921.176229-1-lnk_01@hust.edu.cn>
To:     Li Ningke <lnk_01@hust.edu.cn>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Vasanthakumar Thiagarajan <quic_vthiagar@quicinc.com>,
        Jeff Johnson <quic_jjohnson@quicinc.com>,
        Karthikeyan Periyasamy <quic_periyasa@quicinc.com>,
        Carl Huang <quic_cjhuang@quicinc.com>,
        P Praneesh <quic_ppranees@quicinc.com>,
        hust-os-kernel-patches@googlegroups.com,
        Li Ningke <lnk_01@hust.edu.cn>,
        Dongliang Mu <dzm91@hust.edu.cn>,
        Kalle Valo <quic_kvalo@quicinc.com>,
        Bhagavathi Perumal S <quic_bperumal@quicinc.com>,
        Baochen Qiang <quic_bqiang@quicinc.com>,
        Balamurugan Selvarajan <quic_bselvara@quicinc.com>,
        ath12k@lists.infradead.org, linux-wireless@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3
Message-ID: <168173568189.28224.5440053310426162831.kvalo@kernel.org>
Date:   Mon, 17 Apr 2023 12:48:06 +0000 (UTC)
Precedence: bulk

Li Ningke <lnk_01@hust.edu.cn> wrote:

> Smatch complains that
> drivers/net/wireless/ath/ath12k/pci.c:1198 ath12k_pci_probe() warn: 
> missing unwind goto?
> 
> In order to release the allocated resources before returning an
> error, the statement that directly returns the error is changed
> to a goto statement that first releases the resources in the error
> handling section.
> 
> Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
> Signed-off-by: Li Ningke <lnk_01@hust.edu.cn>
> Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>

Already fixed with an identical patch:

https://git.kernel.org/kvalo/ath/c/488d9a484f96

error: patch failed: drivers/net/wireless/ath/ath12k/pci.c:1195
error: drivers/net/wireless/ath/ath12k/pci.c: patch does not apply
stg import: Diff does not apply cleanly

Patch set to Rejected.

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230417115921.176229-1-lnk_01@hust.edu.cn/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches