Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp4030633rwe; Mon, 17 Apr 2023 07:06:26 -0700 (PDT) X-Google-Smtp-Source: AKy350YKjN+KmOldv5h6o4Ih+vxrY28pxg4tYCgqdO3VRn7Hfm+y0Xck/hFTxf9Ptgi6b6u3+cYC X-Received: by 2002:a05:6a00:2186:b0:635:1770:beb7 with SMTP id h6-20020a056a00218600b006351770beb7mr15674793pfi.14.1681740385826; Mon, 17 Apr 2023 07:06:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681740385; cv=none; d=google.com; s=arc-20160816; b=u/l9zvneXRV5R/rSgq+GBownfJMfIEv3uCquy3NPjhuK5gXwl15mhyW3gxHE0yK69l SHmzHQRzmL0Hepn02LayhMtM5dCquSEW8rb90Tyy+7w1ThkuCsVJTwMmnai/G54s6WPs 3vpzBuN3ExVrSL0LpBGXFrDfzSX/yoWOuRaeAuZi+XvFKNF5WeXjcn2KUKh8PC6ANVwu HOixP+L4P5XXnIa+siSWtJgr/jt7wFzO9QFX8Gu0yuAE3eIPUgDp7p+WRAxHBWtZYhfO KT3IKGkuXUiSQMATbkjxP7EvM4GeUUm2Qpuf7wtyR9y54fUVMSiy4cIw1SWD0qEHGv8t F1KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=eG21d3j0O9I++oS3UFo6WX1xflzOjUNFfJYCitpjO00=; b=qJkQqncKr5axYUst0gYiJMsPILtqFjFmqmWBVZhkZ1N9LXkkyunGHw+0PMhGOoVQwS a+J3Wor7pg1g0QGbQh4KEhuN3BjphhhJcbKS87MN3BwVrbt3qTfZFFxfZsu6ExyFJTyq RF2/OJEwqRisKAedJo1omYdJrjvFUb89DABr2MNJXQQB0Y6NcN3UU8vB4D1TkamW6zjI rzY1Op262/ujNycAdNrtlUex0K9JmvEDmdM2LYr27zNQ1qDemLEyWXaMBj4UarlgfcL3 JrsOtzbJ3BF/pAGH+h1df+UGAlyQOdD5yoJa9KQEr6CjUIP08ySjj0RK2TOaYrhPcpll esvQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a3-20020aa794a3000000b0063d2c3e897bsi911831pfl.202.2023.04.17.07.06.10; Mon, 17 Apr 2023 07:06:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230518AbjDQOCk (ORCPT + 63 others); Mon, 17 Apr 2023 10:02:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229903AbjDQOCX (ORCPT ); Mon, 17 Apr 2023 10:02:23 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBE48BBA8 for ; Mon, 17 Apr 2023 07:01:43 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1poPQK-0003Iv-LU; Mon, 17 Apr 2023 16:01:40 +0200 Received: from [2a0a:edc0:0:1101:1d::28] (helo=dude02.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1poPQH-00BtJb-A6; Mon, 17 Apr 2023 16:01:37 +0200 Received: from sha by dude02.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1poPQG-009OaZ-Ek; Mon, 17 Apr 2023 16:01:36 +0200 From: Sascha Hauer To: linux-wireless Cc: Hans Ulli Kroll , Larry Finger , Pkshih , Tim K , "Alex G ." , Nick Morrow , Viktor Petrenko , Andreas Henriksson , ValdikSS , kernel@pengutronix.de, Sascha Hauer Subject: [PATCH v3 0/4] RTW88 USB bug fixes Date: Mon, 17 Apr 2023 16:01:30 +0200 Message-Id: <20230417140134.2237428-1-s.hauer@pengutronix.de> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Third round of the RTW88 USB bug fixes. After some discussion and thinking I came to the conclusion that the v1 variant of "wifi: rtw88: rtw8821c: Fix rfe_option field width" is better than the one posted in v2, so I reverted back to this version, but added a note to the commit message why this might not be entirely correct for all chip variants (though for all variants currently supported in the driver). The patches are sorted in order of importance. 1/4 hasn't seen any negative comments and I think it should be applied right now. As stated above I think 2/4 should be applied as well. 3/4 fixes something I stumbled upon while reading in the vendor driver, but I don't what effect it actually has, I didn't notice any change in behaviour of the driver. 4/4 straightens the logic how rtw8821c_switch_rf_set() is called for different variants of the rtw8821c. This is taken from the vendor driver. From the supported chip variants this should only have an effect on the ones with rfe_option = 6, but I don't have that one available here for testing. I would be glad if at least 1/4 and 2/4 could be applied as these fix real issues in the driver. Sascha Sascha Hauer (4): wifi: rtw88: usb: fix priority queue to endpoint mapping wifi: rtw88: rtw8821c: Fix rfe_option field width wifi: rtw88: set pkg_type correctly for specific rtw8821c variants wifi: rtw88: call rtw8821c_switch_rf_set() according to chip variant drivers/net/wireless/realtek/rtw88/main.c | 2 +- drivers/net/wireless/realtek/rtw88/main.h | 2 + drivers/net/wireless/realtek/rtw88/rtw8821c.c | 25 +++++-- drivers/net/wireless/realtek/rtw88/usb.c | 70 +++++++++++++------ 4 files changed, 69 insertions(+), 30 deletions(-) -- 2.39.2