Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Ramya Gnanasekar <rgnanase@qti.qualcomm.com>
To:     Kalle Valo <kvalo@kernel.org>,
        "Ramya Gnanasekar (Temp) (QUIC)" <quic_rgnanase@quicinc.com>
CC:     "ath12k@lists.infradead.org" <ath12k@lists.infradead.org>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "Karthik M (QUIC)" <quic_karm@quicinc.com>
Subject: RE: [PATCH] wifi: ath12k: add wait operation for tx management
 packets for flush from mac80211
Thread-Topic: [PATCH] wifi: ath12k: add wait operation for tx management
 packets for flush from mac80211
Thread-Index: AQHZZ4IPExKM3Sc9TEmK1AyvvEk4m68viRacgAAYRlA=
Date:   Mon, 17 Apr 2023 14:31:22 +0000
Message-ID: <CY4PR02MB253674B0BA0767E1504B76B8F19C9@CY4PR02MB2536.namprd02.prod.outlook.com>
References: <20230405054646.7300-1-quic_rgnanase@quicinc.com>
 <87leiqwttz.fsf@kernel.org>
In-Reply-To: <87leiqwttz.fsf@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fJuJE186/UFY08qJLQ/qB40jD+ldR3Vz8FZiP4npsEGzXPT0VqJ7XeOOJCy6?=
 =?us-ascii?Q?FRYte605xgqKsl1XoF96GuisJpe3Uouzka09zV2cDEK6byShT9EHEF5//amY?=
 =?us-ascii?Q?+b+LLWsvcqyRuWKlJIEzGdUhmruHSRqX+wBhmu7T+Hncda+oiGhntft0x4qX?=
 =?us-ascii?Q?rL2BEMpLAyX0a9RMAdQK8ITUa3Z+L2YjbVHaFEPqNocMIwXAiUltBdwcPEYV?=
 =?us-ascii?Q?/ZiFsvLuZsRHNAcjPU0Tqx1yKj7zqJTV6boK/uPvRbw9CgaWZBD0+q3IIv35?=
 =?us-ascii?Q?XUkNSFmPeNktRCz9BIW0v/lQpiaJ7I+qZeHKNMPn8RYHfWjK9E7qcIHSo1ZG?=
 =?us-ascii?Q?BKP80HCVyAYl5tPsvuUXzIpOZCaLYPPFfnvlyG5qFv33ksrdyj2uBx5RVdbW?=
 =?us-ascii?Q?7O7nbSiKM9WA1FppeSJJQt2Yrx+YAaXHPoBsCIdMqPt+fxrXu6KNEnX8voek?=
 =?us-ascii?Q?aBWUods82tkI599HWeTBHOBNEJARFwcfZPkmsGc+yQteJvPiZ67s3WD6RH+w?=
 =?us-ascii?Q?XJHNQrJsliFOK/OWt6QlrgFhtZEt/zRKMF2Niq7LAGAhSh5OZQ/gpz1xnrxN?=
 =?us-ascii?Q?VUYd7P/v704Gtx5dJg85jS7TbL0KYoMVNudjqCF2CIYJKWMuUt6wbmx5KcpS?=
 =?us-ascii?Q?LdLbwUzUaIGWChyWe0zFP5C4+/CUjTZc0QM1UsnxCyxzYjnL0kXKGX41yzvk?=
 =?us-ascii?Q?WpohAmEIV5+kjjx3zYv442ZK28GSwiBwNT4v7qmxZ0B771gI/monSKFEyMGI?=
 =?us-ascii?Q?Ph/kauz+dJws87TAMhf5eDuFuuAJalXxk7j9OYuvU5wZGTgpMh8Q+bK8OuC/?=
 =?us-ascii?Q?Gu5IXF6DyX24k6hH5b3JQPbN6cUCZnPdxBR0wVONpnIqZeqzqeD4Gv4eM3QT?=
 =?us-ascii?Q?iGWi01t5eFmKaEMeKKzn8i0Se8zni4JBsi+kTkltFdhptMsB9XPGg63oTwUX?=
 =?us-ascii?Q?odS8Hi3lnqcgzxgkAtdHiTXID51hdRMJA5tHKpMSK9xWdOI+iTP/yaOlJ8I0?=
 =?us-ascii?Q?0IQ/yNFZVzlN3jG9i2RVSPs+ElpDX4wQbAtlZLaZYiePdyJk4sRK/cZ2gsfy?=
 =?us-ascii?Q?OE8JHi8X+jyMdMGhmw4PDtG3WJXn/UPP7Yb+rjXHDNTG1vIDeqlDEfS1nT7M?=
 =?us-ascii?Q?MBIbPIe6hTjqBv5J/xoC6I4PMc5Klk9u517KmMr3WUPabnvwZJxcl0LCi4Xm?=
 =?us-ascii?Q?uw9bm8ISN2vpK2SXS8dQNOLg5a+UfO7aCVEwBb5gAdPMXGUJS8P+d+r71Xvs?=
 =?us-ascii?Q?j2tg8dRo+BCxixSt/3+4JdIr9PvARGZxcGy9pGw2+7c9lL/4ZeUN9JAjmkLI?=
 =?us-ascii?Q?ld3w/isbJv4fvyolVL8aQOuQY3hL94v9HhuErZQI/X+SBZPPpOtZe6154im4?=
 =?us-ascii?Q?iZ20aXBk1vQwJrdKNiO9BpVBtGwgoyLehy5tB8Pa1aze2Ys9grB8ellfyH5L?=
 =?us-ascii?Q?6YC28Xi9jn22IpXp83GHht259QVsFTqYKEGXStOqb/T6dkBKvXes2/gM62aR?=
 =?us-ascii?Q?uwoWznzRZvHkXYfy0zW7Z3h5zoFjuFYIQKBKcKQJIO3qn/N3netWLmnfLX8g?=
 =?us-ascii?Q?d6g2MlcjYakYDemp+hpVgAVDjtAP8ua0y9pAn8q/XEwopzJg8Qcabu1FvN9+?=
 =?us-ascii?Q?Xg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Md9LIurBNMirk8baqSuoNIcEHV+DGDzPp2jSLbiP+iQUsFWzT44/q7wT3caXTyjEdOrYZ3sxWp28n0C8k4cyE5JR2Cy9wMm2coC0Sy/o96+kg5j/vrPH4g+iSaol0D/wofVtIQdY6silkDfna5aHGGR89VG+cz7oTY6bnJ7Wyj/Cw9Wnra3VQnMUBtRLHI+y8utEa88lFF610ocG25jZiQ+2liGzEuUthn8/3f9vCK81LEsS9a08180PfxjdYXOu0/URa8KH/CCBtFnvbZNE9TczfkZyA5/D/CwGkUfOEmzITLq8HO44Wk13vyxRtJLo+JaAP5ZaEPCZBrGF/DKH50wCEi2lHrDhzilDUffZMdMpwsM12TtLnlV3yfXzxywZkt2j8EUrEL7MgAz+RKAUm9JYUC52Btv6AlZuIpnkbhG04A8iYKbcvQfv06v5h8p3VLkRDAL6KEukZNlPr37PliR/g1Izw4mygoAMs0Es6zp4NMjlIRJXXjUCgLhrRage6jDYjHJbylEfFy5LH5/VB+sV24tUJ3Jufifyov/dT2tK71H1A1pPX9m6Q6arqgpZskao/mtUq2nuH+/K8hdmjCnSdsgJa67rBkBxezUwsu8mNYT5p8CzP12OwhtAnTeyRPKOFMZrnjfn8l+N4RDfHn0i9W++uHhr0JQRTzTv3hGL3QscCxstAQApBWDXmIFwm4t67SZ9mwrb1iIkvW4B1EAIjqu1ySwBKuMuQ6/Hdk5CBEx6EJcRwJtMfymKn/Kj/5lbgLw5gpHHKHwaD5Hv26N0yeglJvqXRL7nFbBxzJwCDWEslTRvhPKtkxRTUEAnZZq9zho3t/rfB1lOnHrvs+8ITy6K6B4gMccOPf9wDS4=
X-OriginatorOrg: qti.qualcomm.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CY4PR02MB2536.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a0721236-9ef8-41ee-ba2d-08db3f506b0d
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Apr 2023 14:31:22.8973
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 98e9ba89-e1a1-4e38-9007-8bdabc25de1d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: m5Cg6IE6jwigfIotTKs0BtCaiiY6S6zrAyRBDo0VJPAEtLR8DOgpzi1YcQuL+nLsYKWuHrOBJ1ZNVZBzCZme+UNrOOBlz7Bd2/v4qaHHwyg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR02MB9222
X-Proofpoint-GUID: WNN5wp6IAr1VZLeQctAhZ8SqsxprXvh2
X-Proofpoint-ORIG-GUID: WNN5wp6IAr1VZLeQctAhZ8SqsxprXvh2
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-17_09,2023-04-17_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0
 priorityscore=1501 mlxlogscore=999 lowpriorityscore=0 adultscore=0
 phishscore=0 mlxscore=0 clxscore=1011 suspectscore=0 impostorscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2303200000 definitions=main-2304170130
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

> -----Original Message-----
> From: Kalle Valo <kvalo@kernel.org>
> Sent: Monday, April 17, 2023 6:26 PM
> To: Ramya Gnanasekar (Temp) (QUIC) <quic_rgnanase@quicinc.com>
> Cc: ath12k@lists.infradead.org; linux-wireless@vger.kernel.org; Karthik M
> (QUIC) <quic_karm@quicinc.com>
> Subject: Re: [PATCH] wifi: ath12k: add wait operation for tx management
> packets for flush from mac80211
>=20
> WARNING: This email originated from outside of Qualcomm. Please be wary o=
f
> any links or attachments, and do not enable macros.
>=20
> Ramya Gnanasekar <quic_rgnanase@quicinc.com> writes:
>=20
> > From: Karthik M <quic_karm@quicinc.com>
> >
> > Transmission of management packets are done in a work queue. Sometimes
> > the workqueue does not finish Tx immediately, then it lead after the
> > next step of vdev delete finished, it start to send the management
> > packet to firmware and lead firmware crash.
> >
> > ieee80211_set_disassoc() have logic of ieee80211_flush_queues() after
> > it send_deauth_disassoc() to ath12k, its purpose is make sure the
> > deauth was actually sent, so it need to change ath12k to match the
> > purpose of mac80211.
> >
> > To address these issues wait for Tx management as well as Tx data packe=
ts.
> >
> > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-
> QCAHKSWPL_SILICONZ-1
> >
> > Signed-off-by: Karthik M <quic_karm@quicinc.com>
> > Signed-off-by: Ramya Gnanasekar <quic_rgnanase@quicinc.com>
> >
> > diff --git a/drivers/net/wireless/ath/ath12k/core.c
> > b/drivers/net/wireless/ath/ath12k/core.c
> > index a89e66653f04..499b81cd938e 100644
>=20
> Ramya, how do you submit your patches? Your patches are missing the "---"=
 line
> which breaks my scripts. I have asked this already before but no reply fr=
om you:
>=20
> https://lore.kernel.org/all/87edqot8m4.fsf@kernel.org/
>=20
> Please do not ignore my questions. If you continue to do that I will just=
 stop
> taking patches from you.
>=20
> --
> https://patchwork.kernel.org/project/linux-wireless/list/
>=20
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpa=
tch
> es

Hi Kalle,

I use "git send-email" to send the patches and the patches are generated us=
ing "git format-patch" command.

Thanks,
Ramya