Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Amisha.Patel@microchip.com>
To:     <linux-wireless@vger.kernel.org>
CC:     <Ajay.Kathat@microchip.com>, <Claudiu.Beznea@microchip.com>,
        <Amisha.Patel@microchip.com>
Subject: [PATCH v2] wifi: wilc1000: fix for absent RSN capabilities WFA
 testcase
Thread-Topic: [PATCH v2] wifi: wilc1000: fix for absent RSN capabilities WFA
 testcase
Thread-Index: AQHZcVxTbYUBq6/w3kmQK+MqPhbi/g==
Date:   Mon, 17 Apr 2023 18:42:12 +0000
Message-ID: <20230417184145.12593-1-amisha.patel@microchip.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?TYRmegDHTL8hxw1lPiIl6lZElckYoGX9l7bJz9CpX20bK61B8RZrW3iSYx?=
 =?iso-8859-1?Q?t1ILSUbKXtngue1jKc4bxDhInelU4DxQJNCY8RcyQcszO0slzkGhQzN4qd?=
 =?iso-8859-1?Q?Fp2d0nPQyItUQaJD9cK4zqYIwJ4N2PNDXjVnY1TOWPtuLqZGwzWL8L5lIO?=
 =?iso-8859-1?Q?DW1Bz8qxO2EcTWc+yFupvxl8QZI2uZF9RynTKblR0pNEbhQiZ9CKRHUZXe?=
 =?iso-8859-1?Q?UBPZl0zcD5DRNFamWwTafPzqswcmxjqse+B6RzUGe4isG/Es6MfQH9z/gE?=
 =?iso-8859-1?Q?UKXYf15IDFe87T+wkU2BCCtbaqejtDKAHjUdt4DjYHldYSfubz90mj7Ixd?=
 =?iso-8859-1?Q?mw2NIFrNmwYgrjJXKV+lg1AQz6aKHjdKe4ZgxjQd/vsty9yfJSsvQOLmis?=
 =?iso-8859-1?Q?lQ/yM6WK54cgXw4+AG+7ol97yYO8TGGAMfch8ZZA6wfzuiuUisJCsV+h31?=
 =?iso-8859-1?Q?qnqqkxO1BKaWUpBrjP0uNamm5yKHubhzI4uH/nk4EjNpP6Aa463osImnqe?=
 =?iso-8859-1?Q?GKGtG2J8VaZ2aX0gJW7vCupDRrI70f5epQeCiDEshn9ERt5Kdr43gUR9gt?=
 =?iso-8859-1?Q?eTVahn5jqWOip6C7E4iniqmWqFG08NEE/89Qw4kVJHUBcxYFXzo5zVDe4M?=
 =?iso-8859-1?Q?bppc37nCUYto07R1xImpm/+6raVA/oOQ/DJ1GY7Y+TD+PRwZvlvDb4yxeH?=
 =?iso-8859-1?Q?31v5YspuKD1l3Y4q1W9TcMYhTwJr7edFTMzsa6iAViRfMuP5RuDKtB186k?=
 =?iso-8859-1?Q?acwdKvZuRXgL4mJfrmatPVYGocErQtZtGhOIO//1DHu0SwIi2ItjmRmjxX?=
 =?iso-8859-1?Q?FVYbH1osMRGZ9GtMW4tdIRdImiLFkVf1VVBHnCl8eixOWsCvFYgbOR2Ibw?=
 =?iso-8859-1?Q?T89NM2kMViMK34hl5qQ2Uw974SYrgW0qfeS3QwkGrmerq8Dc+xe2oBz1D4?=
 =?iso-8859-1?Q?HjwxQIOTON4U1MSxH2z88I4aLREjdnuT1qA2wCfW8Y2Ma8NqZVuUwEc7Cl?=
 =?iso-8859-1?Q?xr72tuqsmNteFJTaJ65qa4wla+O27fzKDC0AOi0uPsa8D549Th4Exhob9d?=
 =?iso-8859-1?Q?0zFl2QKTjyTPl2KbDUNMGrcWy2dEfUjKeheK2nvrNTKrmhhyEsbyCQHChi?=
 =?iso-8859-1?Q?0ni2cWdIj0l2XpFPk7bfmbfNNksGDaw2UOcBRwfeU8iFRX0DqjU1cIBeEj?=
 =?iso-8859-1?Q?EB3Bd4CYLLYgHINBdib8y+2/3yF/Si/L96f9UANY8o/sUS/cE3zmS6iKyh?=
 =?iso-8859-1?Q?aIyGQJkndmdz1r0Z0d5f/Qy7sj/enzcaVqJfZLp0pyniGVmrbjsVAN//O8?=
 =?iso-8859-1?Q?PY/n1VGdsH+y4KdT3W7xKf2WQvNO0SrEVjkb0PfzieKr46vp/zSFt8Z5J+?=
 =?iso-8859-1?Q?vehGEOhqWNIRFZoKP3mJed1XgTA5CLPeU1KI2/gdDEFRo7zvAWgyTz24aD?=
 =?iso-8859-1?Q?OJ4QfQxMCnA33ITpeIPqQtJHdUL4VHgm0iV6AfwOiKGae0vVJNa8qDMOQb?=
 =?iso-8859-1?Q?TZprzDnXHHT59FNZJxCV2+LxlQC2bvYDyzObaJ53qS7/y4HhwA7zRwDec1?=
 =?iso-8859-1?Q?x5OxX0+5hoyXlDzGpt6XpbWxYyzLwmXVvTmecFNgeUeiMRn5RNH9jE6YYg?=
 =?iso-8859-1?Q?lRNDlfe9fDLFyeLfVr8OeGAiVi00VcLmc9vPXavbEmGdkdKIP04u4n/w?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CY8PR11MB7393.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a7c1141d-b1c3-4f6b-b32e-08db3f73759e
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Apr 2023 18:42:12.9727
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: o8Sts2t9+Eb/RkBURBB3JXOLJiZp/aDZ5KoFlmRbyUP0zn94h0M8cZDvwyy9mRPsSqOwfz801xqbd8EW6W5T8jzX20uakf5kwVp6Tv16Pqs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5879
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

Mandatory WFA testcase
CT_Security_WPA2Personal_STA_RSNEBoundsVerification-AbsentRSNCap,
performs bounds verfication on Beacon and/or Probe response frames. It
failed and observed the reason to be absence of cipher suite and AKM
suite in RSN information. To fix this, enable the RSN flag before extractin=
g RSN
capabilities.

Fixes: cd21d99e595e ("wifi: wilc1000: validate pairwise and authentication =
suite offsets")
Signed-off-by: Amisha Patel <amisha.patel@microchip.com>
---
v2 - modified commit log based on review
---
 drivers/net/wireless/microchip/wilc1000/hif.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/wireless/microchip/wilc1000/hif.c b/drivers/net/wi=
reless/microchip/wilc1000/hif.c
index 5adc69d5bcae..a28da5938481 100644
--- a/drivers/net/wireless/microchip/wilc1000/hif.c
+++ b/drivers/net/wireless/microchip/wilc1000/hif.c
@@ -485,6 +485,9 @@ void *wilc_parse_join_bss_param(struct cfg80211_bss *bs=
s,
 		int rsn_ie_len =3D sizeof(struct element) + rsn_ie[1];
 		int offset =3D 8;
=20
+		param->mode_802_11i =3D 2;
+		param->rsn_found =3D true;
+
 		/* extract RSN capabilities */
 		if (offset < rsn_ie_len) {
 			/* skip over pairwise suites */
@@ -494,11 +497,8 @@ void *wilc_parse_join_bss_param(struct cfg80211_bss *b=
ss,
 				/* skip over authentication suites */
 				offset +=3D (rsn_ie[offset] * 4) + 2;
=20
-				if (offset + 1 < rsn_ie_len) {
-					param->mode_802_11i =3D 2;
-					param->rsn_found =3D true;
+				if (offset + 1 < rsn_ie_len)
 					memcpy(param->rsn_cap, &rsn_ie[offset], 2);
-				}
 			}
 		}
 	}
--=20
2.25.1