Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     "Muna Sinada \(QUIC\)" <quic_msinada@quicinc.com>
Cc:     Robert Marko <robert.marko@sartura.hr>,
        "ath11k\@lists.infradead.org" <ath11k@lists.infradead.org>,
        "linux-wireless\@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "Anilkumar Kolli \(QUIC\)" <quic_akolli@quicinc.com>
Subject: Re: [PATCH v2 2/4] wifi: ath11k: push MU-MIMO params from hostapd to hardware
References: <1666128501-12364-1-git-send-email-quic_msinada@quicinc.com>
        <1666128501-12364-3-git-send-email-quic_msinada@quicinc.com>
        <CA+HBbNHw-0+Ty_-masxGKwT6ju_EBxT3n5B0Ygcn3XzQi_CzWg@mail.gmail.com>
        <87fs9ndh6s.fsf@kernel.org>
        <CA+HBbNEaNTkUv_UPgQievxaLya0XC6=AVj0=GWiH+qB9=vRZHg@mail.gmail.com>
        <87bkkbdcfu.fsf@kernel.org> <87pm8iaggt.fsf@kernel.org>
        <BY5PR02MB6164BAC2A418B3C5462C2C348F9B9@BY5PR02MB6164.namprd02.prod.outlook.com>
        <87mt3b6nz6.fsf@kernel.org>
Date:   Tue, 18 Apr 2023 12:09:15 +0300
In-Reply-To: <87mt3b6nz6.fsf@kernel.org> (Kalle Valo's message of "Fri, 14 Apr
        2023 08:18:21 +0300")
Message-ID: <874jpdwo90.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Kalle Valo <kvalo@kernel.org> writes:

> "Muna Sinada (QUIC)" <quic_msinada@quicinc.com> writes:
>
>> Muna Sinada <quic_msinada@quicinc.com> writes:
>>> Kalle Valo <kvalo@kernel.org> writes:
>>>> Robert Marko <robert.marko@sartura.hr> writes:
>>>>
>>>>> On Wed, Mar 29, 2023 at 11:45=E2=80=AFAM Kalle Valo <kvalo@kernel.org=
> wrote:
>>>>>
>>>>>> >> @@ -5369,6 +5491,10 @@ static int ath11k_mac_copy_he_cap(struct=20
>>>>>> >> ath11k *ar,
>>>>>> >>
>>>>>> >>                 he_cap_elem->mac_cap_info[1] &=3D
>>>>>> >>=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20
>>>>>> >> IEEE80211_HE_MAC_CAP1_TF_MAC_PAD_DUR_MASK;
>>>>>> >> +               he_cap_elem->phy_cap_info[0] &=3D
>>>>>> >> + ~IEEE80211_HE_PHY_CAP0_CHANNEL_WIDTH_SET_160MHZ_IN_5G;
>>>>>> >> +               he_cap_elem->phy_cap_info[0] &=3D
>>>>>> >> +=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20
>>>>>> >> + ~IEEE80211_HE_PHY_CAP0_CHANNEL_WIDTH_SET_80PLUS80_MHZ_IN_5G;
>>>>>> >
>>>>>> > This is causing a regression for us in OpenWrt at least on IPQ8074=
=20
>>>>>> > but probably on all ath11k-supported HW. Cause 80+80 and 160MHz=20
>>>>>> > support bits are being cleared here so 160MHz is not being=20
>>>>>> > advertised after this patch.
>>>>>>
>>>>>> Oh man, not good. Robert, should we revert this patchset entirely?=20
>>>>>> Of course it would be better if Muna can submit quickly a fix, but=20
>>>>>> I'm not going to wait for long.
>>>>>
>>>>> I would prefer to see it get fixed, cause just removing the flag=20
>>>>> removal gets 160MHz working, but I am not sure about other flags as=20
>>>>> well.
>>>>
>>>> Ok, let's try to get it fixed then. Muna, can you comment and send a=20
>>>> fix ASAP?
>>>
>>>No reply from Muna. I'll try the new bugbot to open a bug for this regre=
ssion:
>>>
>>>bugbot on
>>
>> I have created fix, tested it and pushed internally for review.
>>
>> @Kalle, how do I go about continuing the conversation on Bugzilla?
>
> Better to continue the discussion on the list. I only created the bug on
> Bugzilla so that I don't forget this as I didn't hear anything from you.

Muna now submitted a fix:

https://patchwork.kernel.org/project/linux-wireless/patch/1681762947-13882-=
1-git-send-email-quic_msinada@quicinc.com/

Robert, can you please check it? And if it works a Tested-by would be
nice.

--=20
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc=
hes