Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp35545rwr; Wed, 19 Apr 2023 03:04:00 -0700 (PDT) X-Google-Smtp-Source: AKy350aARIumHpz8BoYWEPvSCL3v7xPHz5fZQIOUd7xomshYovjTSRLKXxm2yK9j1DLQ3fw+UKqM X-Received: by 2002:a17:90b:4a06:b0:246:ac68:297 with SMTP id kk6-20020a17090b4a0600b00246ac680297mr2566392pjb.0.1681898640668; Wed, 19 Apr 2023 03:04:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681898640; cv=none; d=google.com; s=arc-20160816; b=taqjzZjVvmEM34/ChF/Jz8myTK7JcXHOenxRRNkwEDmo/KuLtshO4BanisbxmZnJkc h0yDQ1R6jM99G5BoIFe038TmpYXWXa0LiKfSTJcr3iCdKHxsQZ68JgxQkePtTLWR1nLU 55bW9en+OEpMsQanojHDZ/45PfHm/UVDMREdnrB6BuIXUhtMwPruXWmIhS04kkfY9tVL JkhPt4n3LSBugB+yLMZOXBdSxXpMvVgBCrM8Qx4CPTNeVNhnkBacMTZGGMBf7DqgLcjs 0xltisRL84BV+HeCqxeatfIYmmuHbhLRHxNVQQeMK2DG5GEs+/4MMXGbRd3V6IjGGwEb j71Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:dkim-signature :dkim-signature:from; bh=D+rS0TSKT4q674y2NlyHuepF+qK+0VF3K9UGMkt4m6I=; b=oPro93BN/7fyagDYc7grPKVyxActdCIUOdi/iprj1gHKkxcNbDlxLR40gVkBcfzTGC PAxZbHE+1jqSFCP99vdzsNvcILgHpT6i2DfHkiOfdnxAH09XzbYRDhcg4W1Wu7Jnqr+G uo6U3+9HcQt6QyE8jwro5OtCOMYIW0zwTkNYBPH5otQ1R93l8f9U8uVwewgbm+6yoUmX CEXtLUjkTn5UvTx+9iUZBMCNZL39QCWkvlt8i2gzGrUuQ89+uzE2IgUHBPEY7vVD9JRQ jnIjsQBnslQq3dAOP2SsMPzDfYr4XCiNq2G+PeXgyQqcFrs8SAMp4klyop6wzucsB3WL 470Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=UeBr1FcF; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hg13-20020a17090b300d00b0023750b695e1si1495414pjb.156.2023.04.19.03.03.51; Wed, 19 Apr 2023 03:04:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=UeBr1FcF; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232954AbjDSKCm (ORCPT + 64 others); Wed, 19 Apr 2023 06:02:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232935AbjDSKCT (ORCPT ); Wed, 19 Apr 2023 06:02:19 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47A9AB759 for ; Wed, 19 Apr 2023 03:02:17 -0700 (PDT) From: Martin Kaistra DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681898533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D+rS0TSKT4q674y2NlyHuepF+qK+0VF3K9UGMkt4m6I=; b=UeBr1FcF5Y9p+yzjGSUxjQQdbe7uexa5SUZMaKoyvYSkP1joL7YMsFr5EJlcqZrbF784NY Rc0g63Ic4ruNeW7UaYyW6H5wgMRP8gGuB1LJN3qljp/n0ZSp7YSvMPxE76d0/OLKP8mALw vtU9W1qgAfTiU4K4LgCtQD4tHNfdtlNpCHiyEgvm3rw/Xd960SKp7Z+k/Ivk4ItTm6/8Px bH10W9QUrKUWvmkxGNsaoDttGCep2tPg2fdUmMmKuPyfi2RvJzEopVYMv9qufvlkWzLXvn LG/Bin5n6GsIMkXCfIUcgHMqff0AWQcEY66OrWrtHl3LWKhRiadhVnd6Jeolkw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681898533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D+rS0TSKT4q674y2NlyHuepF+qK+0VF3K9UGMkt4m6I=; b=aBg3jkaZVu9ekmilvAiDsIwwLyt/KtN1EtTRCvQFGS+3kD46UpQa9VbTbfEg4BuTXU1Agc XbOFhuUJskdNlRDQ== To: linux-wireless@vger.kernel.org Cc: Jes Sorensen , Kalle Valo , Ping-Ke Shih , Bitterblue Smith , Sebastian Andrzej Siewior Subject: [PATCH v2 14/18] wifi: rtl8xxxu: Clean up filter configuration Date: Wed, 19 Apr 2023 12:01:41 +0200 Message-Id: <20230419100145.159191-15-martin.kaistra@linutronix.de> In-Reply-To: <20230419100145.159191-1-martin.kaistra@linutronix.de> References: <20230419100145.159191-1-martin.kaistra@linutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org When RCR_CHECK_BSSID_MATCH is set in AP mode, we don't receive any data frames. Rearrange RCR bits to filter flags to match other realtek drivers and remove RCR_CHECK_BSSID_MATCH in AP mode. Signed-off-by: Martin Kaistra --- .../net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c index cff465c7cda30..f5b6ff3351e5a 100644 --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c @@ -6619,22 +6619,22 @@ static void rtl8xxxu_configure_filter(struct ieee80211_hw *hw, */ if (*total_flags & FIF_BCN_PRBRESP_PROMISC) - rcr &= ~RCR_CHECK_BSSID_BEACON; + rcr &= ~(RCR_CHECK_BSSID_BEACON | RCR_CHECK_BSSID_MATCH); else - rcr |= RCR_CHECK_BSSID_BEACON; + rcr |= RCR_CHECK_BSSID_BEACON | RCR_CHECK_BSSID_MATCH; + + if (priv->vif && priv->vif->type == NL80211_IFTYPE_AP) + rcr &= ~RCR_CHECK_BSSID_MATCH; if (*total_flags & FIF_CONTROL) rcr |= RCR_ACCEPT_CTRL_FRAME; else rcr &= ~RCR_ACCEPT_CTRL_FRAME; - if (*total_flags & FIF_OTHER_BSS) { + if (*total_flags & FIF_OTHER_BSS) rcr |= RCR_ACCEPT_AP; - rcr &= ~RCR_CHECK_BSSID_MATCH; - } else { + else rcr &= ~RCR_ACCEPT_AP; - rcr |= RCR_CHECK_BSSID_MATCH; - } if (*total_flags & FIF_PSPOLL) rcr |= RCR_ACCEPT_PM; -- 2.30.2