Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp711997rwr; Thu, 20 Apr 2023 05:36:30 -0700 (PDT) X-Google-Smtp-Source: AKy350bUC/NpfIQFX8CEo9k65I8cAFxJdcoGdwPm0d8YGuihM8IX8lXHqc+s71oEY1zr22G4mrwp X-Received: by 2002:a17:902:f551:b0:1a6:dc3b:9ed2 with SMTP id h17-20020a170902f55100b001a6dc3b9ed2mr1392446plf.13.1681994190113; Thu, 20 Apr 2023 05:36:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681994190; cv=none; d=google.com; s=arc-20160816; b=k6/omODLF4Epi24fxyBYZ8PgDF2xIVlF9AXJe+94Xc67AcSagZzR1TcbJPNkXHsMLW ETda1C9U3dt2HlS0fh6qaznO9KXW+gVd6+Cy4PIB66cIozMQqFYdUdbjPWiKukUmnGid qV8yKoEFDQBZ4nnpfm2IFI0jIuQ2SYHuIe4hJj1CDLIkgzVLd0XULmvx0MNCUlcqbGVr U/En7U18TBVIaEE3nfojIkscqQdZk1COcGg8eUy/yzSRRoi+d/8t7Xi77Xskep8o0+J/ pWyq7yrv2PX3HfzNlaCNKfUL14dvgRMsVCDXVlCO8CVm+uDdakhjJnuFWRnOlK5eRd+H DySw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=Lt6oqCWINq4OBlMiDg4u/1ZB8HyTToRsTSSC00mp6As=; b=gGcqrmCtdvbJTHq9vhLGFFclAG0SGKZqJU85/Tzrl5gkb1ZCcUOhx8U40fTNUcwh5s P9gsTeCtUEZqh+tzXUkRUPBXJPhs8fPZEC0cpQAD2m4+vTZl3RwjrLo+apHzg11kF5of sbPg8jW06PDnSNh0MNjcajaYWcz576L4gIKjR6R9S5WRRTpqpRrxNb40wpJZXT7ju0M8 Kba+r4qPgZk5bUTqSOoHaY+O7N7GpNyPP/OP1z/uYcV7b+HhyA+iWExaaR0gUfsHWZCm m4F4sN+wY2/l4A4rkixncyRDyUVIu1c0CvVL9FCcpdvZnA1dtXdkUQfp1c2tBL131kgm 5zaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=b8ljy5P3; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jy6-20020a17090342c600b0019a96125cd7si1597650plb.332.2023.04.20.05.36.20; Thu, 20 Apr 2023 05:36:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=b8ljy5P3; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230464AbjDTMff (ORCPT + 63 others); Thu, 20 Apr 2023 08:35:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229915AbjDTMfd (ORCPT ); Thu, 20 Apr 2023 08:35:33 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 573D261A8; Thu, 20 Apr 2023 05:35:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 37DDF647D2; Thu, 20 Apr 2023 12:34:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B923BC433EF; Thu, 20 Apr 2023 12:34:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681994095; bh=ZVPl9soHfS/xgIlOXOG9k3GM/fGYYRXOIzddm4WJhjM=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=b8ljy5P3Z3nJqO65Pk3yCCziiE+r1s7kCSUhWku/dGfgSnTHtIbBV33ey0MUo9rs0 Y2VZV33LarMGQy0O5XgDSE+rFH7jmB5Tq1dDghjAYhgjbGcogK+G6M7lrSjMcB4hdx 78tBnXhneaARVVwTEXplra0jZIwCpLTIHiGV6Vy092lCTgyK20gub24iZVw6YtkeuG Y5jwVPiWV4EjclCp9YwR66vtoeYnS/JVxCEYtPSaf2qszvWAs7Z9ndopB6xjYfQ36J uCeWD37p9Ffu3hfi7bV7RM9gFfvjyQq1cVD302LJ/1zjqke0KytjrzjqoG0vSYpMLG IV6VUFbjGfcnw== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v3 1/4] wifi: rtw88: usb: fix priority queue to endpoint mapping From: Kalle Valo In-Reply-To: <20230417140358.2240429-2-s.hauer@pengutronix.de> References: <20230417140358.2240429-2-s.hauer@pengutronix.de> To: Sascha Hauer Cc: linux-wireless , Hans Ulli Kroll , Larry Finger , Pkshih , Tim K , "Alex G ." , Nick Morrow , Viktor Petrenko , Andreas Henriksson , ValdikSS , kernel@pengutronix.de, Sascha Hauer , stable@vger.kernel.org User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <168199409054.31131.13943288409295170406.kvalo@kernel.org> Date: Thu, 20 Apr 2023 12:34:52 +0000 (UTC) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Sascha Hauer wrote: > The RTW88 chipsets have four different priority queues in hardware. For > the USB type chipsets the packets destined for a specific priority queue > must be sent through the endpoint corresponding to the queue. This was > not fully understood when porting from the RTW88 USB out of tree driver > and thus violated. > > This patch implements the qsel to endpoint mapping as in > get_usb_bulkout_id_88xx() in the downstream driver. > > Without this the driver often issues "timed out to flush queue 3" > warnings and often TX stalls completely. > > Signed-off-by: Sascha Hauer > Tested-by: ValdikSS > Tested-by: Alexandru gagniuc > Tested-by: Larry Finger > Cc: stable@vger.kernel.org > Reviewed-by: Ping-Ke Shih 4 patches applied to wireless-next.git, thanks. a6f187f92bcc wifi: rtw88: usb: fix priority queue to endpoint mapping 14705f969d98 wifi: rtw88: rtw8821c: Fix rfe_option field width 97c75e1adeda wifi: rtw88: set pkg_type correctly for specific rtw8821c variants 172591baa2cc wifi: rtw88: call rtw8821c_switch_rf_set() according to chip variant -- https://patchwork.kernel.org/project/linux-wireless/patch/20230417140358.2240429-2-s.hauer@pengutronix.de/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches