Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH 1/3] wifi: rtl8xxxu: Don't print the vendor/product/serial
From:   Kalle Valo <kvalo@kernel.org>
In-Reply-To: <a2a7d9df-0529-7890-3522-48dce613753f@gmail.com>
References: <a2a7d9df-0529-7890-3522-48dce613753f@gmail.com>
To:     Bitterblue Smith <rtl8821cerfe2@gmail.com>
Cc:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        Jes Sorensen <Jes.Sorensen@gmail.com>,
        Ping-Ke Shih <pkshih@realtek.com>
User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3
Message-ID: <168199414822.31131.11910739234657361957.kvalo@kernel.org>
Date:   Thu, 20 Apr 2023 12:35:50 +0000 (UTC)
Precedence: bulk

Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:

> Most devices have a vendor name, product name, and serial number in the
> efuse, but it's pretty useless. It duplicates the information already
> printed by the USB subsystem:
> 
>    usb 1-4: New USB device found, idVendor=0bda, idProduct=8178, bcdDevice= 2.00
>    usb 1-4: New USB device strings: Mfr=1, Product=2, SerialNumber=3
>    usb 1-4: Product: 802.11n WLAN Adapter
>    usb 1-4: Manufacturer: Realtek
>    usb 1-4: SerialNumber: 00e04c000001
> -> usb 1-4: Vendor: Realtek
> -> usb 1-4: Product: 802.11n WLAN Adapter
> 
>    usb 1-4: New USB device found, idVendor=0bda, idProduct=818b, bcdDevice= 2.00
>    usb 1-4: New USB device strings: Mfr=1, Product=2, SerialNumber=3
>    usb 1-4: Product: 802.11n NIC
>    usb 1-4: Manufacturer: Realtek
>    usb 1-4: SerialNumber: 00e04c000001
> -> usb 1-4: Vendor: Realtek
> -> usb 1-4: Product: 802.11n NIC
> -> usb 1-4: Serial not available.
> 
>    usb 1-4: New USB device found, idVendor=0bda, idProduct=f179, bcdDevice= 0.00
>    usb 1-4: New USB device strings: Mfr=1, Product=2, SerialNumber=3
>    usb 1-4: Product: 802.11n
>    usb 1-4: Manufacturer: Realtek
>    usb 1-4: SerialNumber: 002E2DC0041F
> -> usb 1-4: Vendor: Realtek
> -> usb 1-4: Product: 802.11n
> 
>    usb 1-4: New USB device found, idVendor=0bda, idProduct=8179, bcdDevice= 0.00
>    usb 1-4: New USB device strings: Mfr=1, Product=2, SerialNumber=3
>    usb 1-4: Product: 802.11n NIC
>    usb 1-4: Manufacturer: Realtek
>    usb 1-4: SerialNumber: 00E04C0001
> -> usb 1-4: Vendor: Realtek
> -> usb 1-4: Product: 802.11n NIC
> -> usb 1-4: Serial: 00E04C0001
> 
> Also, that data is not interpreted correctly in all cases:
> 
> usb 3-1.1.2: New USB device found, idVendor=0bda, idProduct=8179, bcdDevice= 0.00
> usb 3-1.1.2: New USB device strings: Mfr=1, Product=2, SerialNumber=3
> usb 3-1.1.2: Product: 802.11n NIC
> usb 3-1.1.2: Manufacturer: Realtek
> usb 3-1.1.2: Vendor: Realtek
> usb 3-1.1.2: Product: \x03802.11n NI
> usb 3-1.1.2: Serial: \xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff
> 
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217231
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
> Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>

3 patches applied to wireless-next.git, thanks.

af8678e6c5bd wifi: rtl8xxxu: Don't print the vendor/product/serial
cd85c8b059c5 wifi: rtl8xxxu: Add rtl8xxxu_write{8,16,32}_{set,clear}
c8bc37602779 wifi: rtl8xxxu: Simplify setting the initial gain

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/a2a7d9df-0529-7890-3522-48dce613753f@gmail.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches