Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Amisha.Patel@microchip.com>
To:     <linux-wireless@vger.kernel.org>
CC:     <Ajay.Kathat@microchip.com>, <Claudiu.Beznea@microchip.com>,
        <Amisha.Patel@microchip.com>
Subject: [PATCH v3] wifi: wilc1000: fix for absent RSN capabilities WFA
 testcase
Thread-Topic: [PATCH v3] wifi: wilc1000: fix for absent RSN capabilities WFA
 testcase
Thread-Index: AQHZdHyIZE4jvlc6AkW1D4oyyUR4PQ==
Date:   Fri, 21 Apr 2023 18:10:20 +0000
Message-ID: <20230421181005.4865-1-amisha.patel@microchip.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?k0yUkBklm0U9dadfiEjUOF+L15MhrTnIhq8feGPZ15s3LsyN1zxPVpsRg9?=
 =?iso-8859-1?Q?vYFiXenGNIpLkeDkyTCDuRuOP9CPKoM+DzE8AdqsZDWU5w0C5vhtV2TP/T?=
 =?iso-8859-1?Q?oMplV7jZLDenPbNmztlT764xoJyhiUyOHIMMUWM46MxrXIuTBV7ojuK04J?=
 =?iso-8859-1?Q?C2h11OqHnu9rtx8YuDNWCJnIL66Cx2TVxHxc6/DEM5QDGmIsMg/OanHwVp?=
 =?iso-8859-1?Q?BSK28TrQsYZTi85f4JZmGgEi8yXgCiyApbMec+kp/an+KvLPCq/A3BcXmP?=
 =?iso-8859-1?Q?aAcjxCXOvn2rqx+iA5Y6ngyyBIvGAlP9Ma7Ca7l8BHhCzmvfwSJQEgn/U/?=
 =?iso-8859-1?Q?46mOcK4Toyc0Rb/3eWVZvbOs2Feo1sS2oqnq9xJc1UZwf0XxB1qye9bgLl?=
 =?iso-8859-1?Q?Ua4y4rJe9jLAyJjVDFhFNJhwehI70PLGgHl8m4txFokoO2oZzmuY1Vv9Cq?=
 =?iso-8859-1?Q?/urOxSB/to80E1674QoZyrBEs5cemUjhT6jEa6EJvtLnvH6ftMDaZkz8cE?=
 =?iso-8859-1?Q?29tGX123BAZo2yCen9/ucirAzhfYz7WvoO79TZ2NQ3zkJTLrIU+WX/dKzZ?=
 =?iso-8859-1?Q?qnaz6FclOIflBpqfRIkxfi2St0vJQcfs5795nWtio2fCRRsZEJCuNP0di+?=
 =?iso-8859-1?Q?uy0nk9/8dAA8Hlgz4PlIY+zdsSRxwV6xXwZXyi5xTBY9jzabQzfmFFEXea?=
 =?iso-8859-1?Q?rSjQMGTxB2NxYoIz7S1D67TAdQvkDn8HU7VmrGOshLzHTM1J+VzUxHJLu2?=
 =?iso-8859-1?Q?ZrXA+NmHxxte7vZw9diYXZf1LS+1Xc4lXRLWJ25ROLLg264buXLyo1hjJ8?=
 =?iso-8859-1?Q?TC+Zx9oV9DT429Im25DMhuD5Mo6L6zXTfRIHUZDWIsKG/79DHqGTx6C/MY?=
 =?iso-8859-1?Q?d4lfWwyvg2tF9GrVQYIqOlUChtxa9MfEplnfBIgY8o3TaR0ydV+pLVgyCo?=
 =?iso-8859-1?Q?Pu9HZI0aJgKrMLNOViC1sAh2mtVxSLuSGfXn4uKAwHNc0KCTVgCn7hiGiB?=
 =?iso-8859-1?Q?W+X+lkT2rjYwGap64lrZSwrlmMDPZCSESfaYy+EZ0lo2NUd+E/3SDCgouh?=
 =?iso-8859-1?Q?sIF7Sn/ZVMqlrEY4kHn/9/8SO2N04DTtP2pmmZipTfTWlyg36XDd3dAtsE?=
 =?iso-8859-1?Q?t78LuVyOgPgoD51sCSGJkN1mz3luM9I1MwZPxfhPua+LvXI1zNg6kLxlsL?=
 =?iso-8859-1?Q?YGPRDLo+PDIWS+KYZFvIxnzC9Pd3dJ3uwKV0nxhbcQ5rrb/+Yj/unLMWtr?=
 =?iso-8859-1?Q?Woyg6c9pbJ/30qL1mn1fLAM/+hZ3lz4MBdpd49gMo23HGgdmASHylUmVkr?=
 =?iso-8859-1?Q?NY+dGATh+0qkZpNfOmBV3s9+nQ2xsMiFkhgp2uLxG8BC62o5S4RMGuEMkg?=
 =?iso-8859-1?Q?N0HQW9jIexk8OqovLNpCReVAz2SbBGaxaCPXwrxA48AVJIqOViivRyyNa/?=
 =?iso-8859-1?Q?kLQhW3QWCGKKWjBsE/yiHFNR5QhHQdjl8aM+SBnYpZbC3ebb6soMYmxSb2?=
 =?iso-8859-1?Q?pabZwPueQisfXdcXb+KHnz6StzSGxDssSchcMvDkvvuD5eCckqaBhIVYhp?=
 =?iso-8859-1?Q?pqA47gwq09ozefCvdX866oTlRMdHSX8pivaXkJglnMhGMhGcEDvNt9hIV3?=
 =?iso-8859-1?Q?FWRZtYeFkxP/hvptjJ8m9f9PbK6L2UszSWrgN+BM6hx2EJ+CR+TX7VNA?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CY8PR11MB7393.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 517584ba-01c3-407b-bfa9-08db4293ab0b
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2023 18:10:20.0304
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: juwh9FLjafqHBXHL+UZuyFmI1BTZfoesB064v8MOYnGTxb6vAPo6Mvt/XoL+Tngrjpeb1f9O06gsV2QgyHllexwneR2zeJusFIa9gfy1f38=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5558
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

From: Amisha Patel <amisha.patel@microchip.com>

Mandatory WFA testcase
CT_Security_WPA2Personal_STA_RSNEBoundsVerification-AbsentRSNCap,
performs bounds verfication on Beacon and/or Probe response frames. It
failed and observed the reason to be absence of cipher suite and AKM
suite in RSN information. To fix this, enable the RSN flag before extractin=
g RSN
capabilities.

Fixes: cd21d99e595e :"wifi: wilc1000: validate pairwise and authentication =
suite offsets")
Signed-off-by: Amisha Patel <amisha.patel@microchip.com>
---
v3 - fixed From field as per review

v2 - modified commit log based on review
---
 drivers/net/wireless/microchip/wilc1000/hif.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/wireless/microchip/wilc1000/hif.c b/drivers/net/wi=
reless/microchip/wilc1000/hif.c
index 5adc69d5bcae..a28da5938481 100644
--- a/drivers/net/wireless/microchip/wilc1000/hif.c
+++ b/drivers/net/wireless/microchip/wilc1000/hif.c
@@ -485,6 +485,9 @@ void *wilc_parse_join_bss_param(struct cfg80211_bss *bs=
s,
 		int rsn_ie_len =3D sizeof(struct element) + rsn_ie[1];
 		int offset =3D 8;
=20
+		param->mode_802_11i =3D 2;
+		param->rsn_found =3D true;
+
 		/* extract RSN capabilities */
 		if (offset < rsn_ie_len) {
 			/* skip over pairwise suites */
@@ -494,11 +497,8 @@ void *wilc_parse_join_bss_param(struct cfg80211_bss *b=
ss,
 				/* skip over authentication suites */
 				offset +=3D (rsn_ie[offset] * 4) + 2;
=20
-				if (offset + 1 < rsn_ie_len) {
-					param->mode_802_11i =3D 2;
-					param->rsn_found =3D true;
+				if (offset + 1 < rsn_ie_len)
 					memcpy(param->rsn_cap, &rsn_ie[offset], 2);
-				}
 			}
 		}
 	}
--=20
2.25.1