Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Apr 2023 15:39:45 +0300
From:   Dan Carpenter <dan.carpenter@linaro.org>
To:     Ping-Ke Shih <pkshih@realtek.com>
Cc:     "kvalo@kernel.org" <kvalo@kernel.org>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] wifi: rtw89: fix rtw89_read_chip_ver() for RTL8852B and
 RTL8851B
Message-ID: <3b1ed718-ce01-4a98-ae8b-3c042851c3f5@kili.mountain>
References: <e4d912a2-37f8-4068-8861-7b9494ae731b@kili.mountain>
 <7475bff70fd50c7e8527e66080e126b4eff440bb.camel@realtek.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7475bff70fd50c7e8527e66080e126b4eff440bb.camel@realtek.com>
Precedence: bulk

On Fri, Apr 21, 2023 at 11:48:43AM +0000, Ping-Ke Shih wrote:
> On Fri, 2023-04-21 at 13:44 +0300, Dan Carpenter wrote:
> > 
> > The if statement is reversed so it will not record the chip version.
> > This was detected using Smatch:
> > 
> >     drivers/net/wireless/realtek/rtw89/core.c:3593 rtw89_read_chip_ver()
> >     error: uninitialized symbol 'val'.
> 
> I use smatch to check our driver regularly, but I can't find this error.
> With the latest version v0.5.0-8321-g556064ca, I still can't find it.
> Do I need to specify additional arguments? Thanks. 
> 

You need the cross function database (which takes like 9 hours to build).

~/smatch/smatch_scripts/build_kernel_data.sh

regards,
dan carpenter