Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.500.231\))
Subject: Re: pull-request: wireless-next-2023-04-21
From:   Gregg Wonderly <greggwonderly@seqtechllc.com>
In-Reply-To: <e31dae6daa6640859d12bf4c4fc41599@realtek.com>
Date:   Mon, 24 Apr 2023 23:14:53 -0500
Cc:     Jakub Kicinski <kuba@kernel.org>, Kalle Valo <kvalo@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <92FFD14B-6BE0-4AC1-9281-A37508817A3B@seqtechllc.com>
References: <20230421104726.800BCC433D2@smtp.kernel.org>
 <20230421075404.63c04bca@kernel.org>
 <e31dae6daa6640859d12bf4c4fc41599@realtek.com>
To:     Ping-Ke Shih <pkshih@realtek.com>
Precedence: bulk

Could this be expressed in a /proc structure of files and directories?

Gregg Wonderly

> On Apr 24, 2023, at 9:41 PM, Ping-Ke Shih <pkshih@realtek.com> wrote:
>=20
>=20
>=20
>> -----Original Message-----
>> From: Jakub Kicinski <kuba@kernel.org>
>> Sent: Friday, April 21, 2023 10:54 PM
>> To: Kalle Valo <kvalo@kernel.org>
>> Cc: netdev@vger.kernel.org; linux-wireless@vger.kernel.org
>> Subject: Re: pull-request: wireless-next-2023-04-21
>>=20
>> On Fri, 21 Apr 2023 10:47:26 +0000 (UTC) Kalle Valo wrote:
>>> .../net/wireless/realtek/rtw89/rtw8851b_table.c    | 14824 =
+++++++++++++++++++
>>> .../net/wireless/realtek/rtw89/rtw8851b_table.h    |    21 +
>>=20
>> We should load these like FW, see the proposal outlined in
>> https://lore.kernel.org/all/20221116222339.54052a83@kernel.org/
>> for example. Would that not work?
>>=20
>=20
> That would work, and I think struct fields addr and val should be =
__le32.
> And, I have some draft ideas to handle some situations we will face:
>=20
> 1. upgrading to newer driver without built-in tables will break user =
space
>   if people don't download table file from linux-firmware.git.
>   Maybe, we can keep the built-in tables and support loading from =
files
>   for couple years at least.
>=20
> 2. c code can do changes along with these tables, so driver should do =
some
>   compatibility things for register version.=20
>=20
> 3. The file contains not only simple registers tables but also TX =
power tables
>   and power tracking tables. These tables are multiple dimensions, and
>   dimensions can be changed due to more channels are supported, for =
example.
>   To be backward compatible, we need to add conversion function from
>   v1, v2 ... to current.
>=20
> I will think further to make this change smooth.=20
>=20
> Ping-Ke
>=20