Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp6553612rwr; Mon, 24 Apr 2023 23:32:44 -0700 (PDT) X-Google-Smtp-Source: AKy350bLZTIo6xJYfB85pUOoJPikhsIpcleCAGd3ZbjCMH5OaAdYvLmhRkZLRViIJoI7/axKITh+ X-Received: by 2002:a17:902:e882:b0:1a2:8940:6da4 with SMTP id w2-20020a170902e88200b001a289406da4mr20477499plg.29.1682404364081; Mon, 24 Apr 2023 23:32:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682404364; cv=none; d=google.com; s=arc-20160816; b=Q35vckt+If6Ib4oe7tAw7Eh5k0TJBNCUsfzNYApOU2PuJZABt7FCR76UHPfPKmlZfs mMb3MzWhmDgsdOTtG1uqlZaTYpYWhgS7/QTCH2SvJQTm/S9BOXwhz/ze80Z7xnCla+5c CyiH+vRPAzDT+GPFHGldgTnKyFu1Ia+CCONyyq1ObyU+LotLqnUQ1LP/td6tRUu5NQdL HBkQJHwkxy5iFkvbO8Vx31L/sbzFkuHQ7AN46d3rDtsDakYjba2aiYEeR4zd4TwzKrG0 x6Xkypo6VK+FogSHvY4+oa1H+S1eafZzbDV92vSOZw60/2dLXuxY0gMGKfjJjkKdYEyA tXdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=gzS3HozDK4ggEqJpf6xsi9Fbp/a9DRCvWF/0MrXrJOY=; b=AP6Srslc/5NoNNjR1xlBMjMFKwBaOuaU/IN1GN3QGb6oBVgkIG6L4zBrq/aJIPQaw+ W+0j/Cds1DNaG3W+HXeNRn2pe4FFXSj3uSGkiuB31DSQEeT0RTPs8oHtBzkY7UT7h2D4 AD9oGmmP0aG6CXnVLWn2FmH+XbyTDde/3IRcMofjKtFeDAjYaPbVHLfExb2iXwm/N6WN jHDbWwzZEF9ro2F2qoGf7qbaQNhuv2SriUa8kU2QojvR7srffjP5HCP7IH59/3m7JKwR /6/vh+4gdvLitq+ptAlD0Z8ImsP9SChRAWLt4ziktOV00m6Z0yraBJTFXtMzU3fx/9q6 JEsQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RLUBoML5; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c2-20020a170903234200b001a6632368ecsi14121672plh.503.2023.04.24.23.32.29; Mon, 24 Apr 2023 23:32:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RLUBoML5; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231175AbjDYFxj (ORCPT + 62 others); Tue, 25 Apr 2023 01:53:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230314AbjDYFxi (ORCPT ); Tue, 25 Apr 2023 01:53:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D205C4C15 for ; Mon, 24 Apr 2023 22:53:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 70F8B62B32 for ; Tue, 25 Apr 2023 05:53:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A425C433EF; Tue, 25 Apr 2023 05:53:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682402016; bh=+w+5rtL8LJ8B3LU18mhmJe8KrxsNeAal+me9ozVOLjA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=RLUBoML5wg8PlrNGyU+1aPkILBJ0hzcfuYFpKDmzespL1ygvZrkEQs6OucS1QKXvE msmpyBHGDuWeKeN7dsb/G6xNBalEotwUKBbgDdMH9jHJeS2WtKY0ejqvnAq9o5DUCQ VVaLx0Mmmvyr4MGF8NUlluP5TCqUBCQJj/vrQNjGp0Qg2Px9oN6bSaLAhH0g2P+t4B EHoMUFc8Y4QZCNaIdeDIHya9jrf1XNQiFPzr55ybVfDJO4Ek1n/P7DYUyGqWch6kI7 PIxNh7Dvj50IY9mTm0oVD1wXewMQbNWpb/rb90/PtF3hbTWl6ZD9hzOiX1JeFMANNh aYp0anV2fyAFg== From: Kalle Valo To: Bitterblue Smith Cc: Martin Kaistra , linux-wireless@vger.kernel.org, Jes Sorensen , Ping-Ke Shih , Sebastian Andrzej Siewior Subject: Re: [PATCH v2 18/18] wifi: rtl8xxxu: Set maximum number of supported stations References: <20230419100145.159191-1-martin.kaistra@linutronix.de> <20230419100145.159191-19-martin.kaistra@linutronix.de> <98355d5e-ac45-c522-3b8a-8cdc243b87cb@gmail.com> Date: Tue, 25 Apr 2023 08:53:32 +0300 In-Reply-To: <98355d5e-ac45-c522-3b8a-8cdc243b87cb@gmail.com> (Bitterblue Smith's message of "Mon, 24 Apr 2023 23:16:23 +0300") Message-ID: <875y9kqzhf.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Bitterblue Smith writes: >> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c >> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c >> @@ -7464,6 +7464,8 @@ static int rtl8xxxu_probe(struct usb_interface *interface, >> >> hw->wiphy->max_scan_ssids = 1; >> hw->wiphy->max_scan_ie_len = IEEE80211_MAX_DATA_LEN; >> + if (priv->fops->max_sta_num) >> + hw->wiphy->max_ap_assoc_sta = priv->fops->max_sta_num - 1; > > The way you use it, "max_macid_num" would be a more accurate name. Indeed. I was first wondering why subtract max_sta_num, at least for me max_macid_num makes more sense. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches