Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp7431225rwr; Tue, 25 Apr 2023 12:56:05 -0700 (PDT) X-Google-Smtp-Source: AKy350boB1ldcpcJJHumBOLyHHTLDE5Rt2ZDDM9z9l/+FQWuEn3z/L/K7Pm7k75YO4YqVTE/00ir X-Received: by 2002:a17:902:b495:b0:1a6:dc4a:b8f8 with SMTP id y21-20020a170902b49500b001a6dc4ab8f8mr16922654plr.38.1682452564970; Tue, 25 Apr 2023 12:56:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682452564; cv=none; d=google.com; s=arc-20160816; b=l80U3++BxsGM1VRyKcWhm4N4ynuZ70lhbNoPWjS6A60R2rB8Hwkc0Jmq3ShTCLAJDT mkXlVOAySvJxInw7Q6sYdvzvV8nfSuLf00PMtc0zgjSTR3pF/ihIAIjAyRKQ6c7mh9kh VPhE1PB+Nxpm2V8RFIGbEvk84gjKIoVdclzbj+gKy2eP9izeGH+apHF8lfyipwO3Syw+ FmvRFk2oLQlm86NwGlSYkF0jDWNOd4baSHig/LD5C9I51oGKA6hum/IWfHrTX4C3CHxi FIEGUcn0aMN4Mjq3KILB24/migIuvgaC6B6fFynArP9piytje5O8JNHN599ob9GgqWve bNrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:subject:user-agent:references :in-reply-to:message-id:date:cc:to:from:dkim-signature; bh=4cP9Xt8xbkJClCSGc7a2sPBFz3RBF3qO2uGdOTRV66E=; b=c1Nz6QpS2nRJdOebBCqqAnHngrBCyLc47E97K4UpY//bMb0WGYq10Krq0Wi06ZJqVE zH2+WH60Z+KLELZKis19uJ3eA2JwaPjRokmj7sj/oWRZAv0V/+D7GHAtu3I+nv4Araaz u/PeZUzUKxImThVjBJmlCqdGWWIpxvWbjEdXh/UIp+K8fdEbnxpCSmjLFdYq/8tuFE9s kV1pZ6TPNWSFamv58t0/KsRUe+hI0ViwHEfVbUZyl0aptInN38wwzvcEeftjdcC0FfNI oktsZuugfpXjk1qUPQbT6la1pRp/0p05p6rfBQetTGua2LBju61Zfb61v9rkWd1+q38O cAyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=J1XFqFbL; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ij24-20020a170902ab5800b001a6bc44b863si13884325plb.249.2023.04.25.12.55.27; Tue, 25 Apr 2023 12:56:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=J1XFqFbL; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235264AbjDYTwU (ORCPT + 63 others); Tue, 25 Apr 2023 15:52:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234754AbjDYTwT (ORCPT ); Tue, 25 Apr 2023 15:52:19 -0400 Received: from mail-qv1-xf33.google.com (mail-qv1-xf33.google.com [IPv6:2607:f8b0:4864:20::f33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA1455FDB for ; Tue, 25 Apr 2023 12:52:18 -0700 (PDT) Received: by mail-qv1-xf33.google.com with SMTP id 6a1803df08f44-5ef4d54a583so30007016d6.0 for ; Tue, 25 Apr 2023 12:52:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1682452338; x=1685044338; h=mime-version:subject:user-agent:references:in-reply-to:message-id :date:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=4cP9Xt8xbkJClCSGc7a2sPBFz3RBF3qO2uGdOTRV66E=; b=J1XFqFbLl+SwNUq/tFVSaDlyDqM1wCoddjj1CCjcNi1nNZhsls+IkZfLseDnkpuNUD h2PSuK8i3H/JC+mvaMDRx/uPNLijx1mtGPRrdrp4vCsNyNG7aPJnf37E83WRt9hn59n6 7rhxWRzpEgKqXS2t3L+MN18f+iduHEIhICH+4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682452338; x=1685044338; h=mime-version:subject:user-agent:references:in-reply-to:message-id :date:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4cP9Xt8xbkJClCSGc7a2sPBFz3RBF3qO2uGdOTRV66E=; b=GrH+dL7IzFIzQs67oYOgrutnVZwhX9gQavt37dyK8d/U4rORhBksLuniNOFGRPjSMg +cKzIHaNsxIDzcWJSnuXYVyfZPZ6CvQSy61+LDtxoTGj1EXIhcspe5kw1+tPV26eGih6 kP0rNvAthmDBVsft1ZfDAJTGovMSrAUsX0qhpgN1SB2xL0iENmCZemJ36REZZdVI5BGI jdYMBGBSpMfiTfCO4Gk9iBQ5M2/J35ptuFjAjy7JRKF6OYEHGd4wMRAWbBEewxgHxAkJ N+TN6L+SI08sKx40rdjuREv8jYGfLntWiOsUQ20Enwj3+wtYfEXtvYi6L27xdyabwJt9 wWnw== X-Gm-Message-State: AAQBX9ftXipzL+mGbT2rd7pD3skhrOoIlMT73qgr52tQbL7QsR1bXaQu VtJxREtmCqUnvIarblVVMCsV5A== X-Received: by 2002:a05:6214:21ca:b0:5ef:60c3:57af with SMTP id d10-20020a05621421ca00b005ef60c357afmr32920416qvh.4.1682452337762; Tue, 25 Apr 2023 12:52:17 -0700 (PDT) Received: from [192.168.178.38] (f215227.upc-f.chello.nl. [80.56.215.227]) by smtp.gmail.com with ESMTPSA id j13-20020a0cf50d000000b005eee5c22f30sm4323527qvm.139.2023.04.25.12.52.15 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Apr 2023 12:52:17 -0700 (PDT) From: Arend Van Spriel To: Johannes Berg CC: "linux-wireless" Date: Tue, 25 Apr 2023 21:52:14 +0200 Message-ID: <187b9f945b0.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> In-Reply-To: References: <9de1cb94-7b60-3d1d-3833-1b08624af645@broadcom.com> User-Agent: AquaMail/1.44.0 (build: 104400286) Subject: Re: question about struct ieee80211_iface_combination MIME-Version: 1.0 Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000f661ae05fa2e7578" X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org --000000000000f661ae05fa2e7578 Content-Type: text/plain; format=flowed; charset="us-ascii" Content-Transfer-Encoding: 8bit On April 25, 2023 8:14:33 PM Johannes Berg wrote: > Hi Arend, > > On Tue, 2023-04-25 at 12:01 +0200, Arend van Spriel wrote: >> My brain is tripping over a field in struct ieee80211_iface_combination, >> ie. the num_different_channels. Looking at the name I tend to think that >> num_different_channel = 0 means the interfaces must all operate on the >> same channel. However, in most places it is configured as 1 or more. The >> documentation in cfg80211.h [1] is not unambiguous about it in my >> opinion. By now it probably depends on how user-space uses it. > > Well it's not valid for it to be 0 in the first place: > > static int wiphy_verify_combinations(struct wiphy *wiphy) > { > ... > for (i = 0; i < wiphy->n_iface_combinations; i++) { > ... > for (i = 0; i < wiphy->n_iface_combinations; i++) { > ... > /* Need at least one channel */ > if (WARN_ON(!c->num_different_channels)) > return -EINVAL; > > > So really what was meant that _1_ means you only have a single channel, > and so on. Are you tripping over the "different"? The way I read it, is Yup. That WARN_ON is a big help ;-) > that with all the interfaces you have, you can have N different > channels, i.e. looking at it "globally". It seems maybe you're more > interpreting it as "additionally" to the first interface? Thanks for taking time to clarify this to me. Regards, Arend --000000000000f661ae05fa2e7578 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQdwYJKoZIhvcNAQcCoIIQaDCCEGQCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3OMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBVYwggQ+oAMCAQICDE79bW6SMzVJMuOi1zANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMjA5MTAxMTQzMjNaFw0yNTA5MTAxMTQzMjNaMIGV MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xGTAXBgNVBAMTEEFyZW5kIFZhbiBTcHJpZWwxKzApBgkqhkiG 9w0BCQEWHGFyZW5kLnZhbnNwcmllbEBicm9hZGNvbS5jb20wggEiMA0GCSqGSIb3DQEBAQUAA4IB DwAwggEKAoIBAQDxOB8Yu89pZLsG9Ic8ZY3uGibuv+NRsij+E70OMJQIwugrByyNq5xgH0BI22vJ LT7VKCB6YJC88ewEFfYi3EKW/sn6RL16ImUM40beDmQ12WBquJRoxVNyoByNalmTOBNYR95ZQZJw 1nrzaoJtK0XIsv0dNCUcLlAc+jHkngD+I0ptVuWoMO1BcJexqJf5iX2M1CdC8PXTh9g4FIQnG2mc 2Gzj3QNJRLsZu1TLyOyBBIr/BE7UiY3RabgRzknBGAPmzhS+fmyM8OtM5BYBsFBrSUFtZZO2p/tf Nbc24J2zf2peoZ8MK+7WQqummYlOnz+FyDkA9EybeNMcS5C+xi/PAgMBAAGjggHdMIIB2TAOBgNV HQ8BAf8EBAMCBaAwgaMGCCsGAQUFBwEBBIGWMIGTME4GCCsGAQUFBzAChkJodHRwOi8vc2VjdXJl Lmdsb2JhbHNpZ24uY29tL2NhY2VydC9nc2djY3IzcGVyc29uYWxzaWduMmNhMjAyMC5jcnQwQQYI KwYBBQUHMAGGNWh0dHA6Ly9vY3NwLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24y Y2EyMDIwME0GA1UdIARGMEQwQgYKKwYBBAGgMgEoCjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3 dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAJBgNVHRMEAjAAMEkGA1UdHwRCMEAwPqA8oDqG OGh0dHA6Ly9jcmwuZ2xvYmFsc2lnbi5jb20vZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAuY3Js MCcGA1UdEQQgMB6BHGFyZW5kLnZhbnNwcmllbEBicm9hZGNvbS5jb20wEwYDVR0lBAwwCgYIKwYB BQUHAwQwHwYDVR0jBBgwFoAUljPR5lgXWzR1ioFWZNW+SN6hj88wHQYDVR0OBBYEFIikAXd8CEtv ZbDflDRnf3tuStPuMA0GCSqGSIb3DQEBCwUAA4IBAQCdS5XCYx6k2GGZui9DlFsFm75khkqAU7rT zBX04sJU1+B1wtgmWTVIzW7ugdtDZ4gzaV0S9xRhpDErjJaltxPbCylb1DEsLj+AIvBR34caW6ZG sQk444t0HPb29HnWYj+OllIGMbdJWr0/P95ZrKk2bP24ub3ZP/8SyzrohfIba9WZKMq6g2nTLZE3 BtkeSGJx/8dy0h8YmRn+adOrxKXHxhSL8BNn8wsmIZyYWe6fRcBtO3Ks2DOLyHCdkoFlN8x9VUQF N2ulEgqCbRKkx+qNirW86eF138lr1gRxzclu/38ko//MmkAYR/+hP3WnBll7zbpIt0jc9wyFkSqH p8a1MYICbTCCAmkCAQEwazBbMQswCQYDVQQGEwJCRTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1z YTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMgUGVyc29uYWxTaWduIDIgQ0EgMjAyMAIMTv1t bpIzNUky46LXMA0GCWCGSAFlAwQCAQUAoIHUMC8GCSqGSIb3DQEJBDEiBCABU/T57Js7+KjS+7aa gnWqpCFRTzrwA2mUNhl0TSdL1DAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcBMBwGCSqGSIb3DQEJ BTEPFw0yMzA0MjUxOTUyMThaMGkGCSqGSIb3DQEJDzFcMFowCwYJYIZIAWUDBAEqMAsGCWCGSAFl AwQBFjALBglghkgBZQMEAQIwCgYIKoZIhvcNAwcwCwYJKoZIhvcNAQEKMAsGCSqGSIb3DQEBBzAL BglghkgBZQMEAgEwDQYJKoZIhvcNAQEBBQAEggEAVg/a3ydaiYyYoBTnbO1OKcmtTk3lLXFt1yTm arIB3D7px0nruvXUseh512IEsjO878/dCB3qZblzhcXmsHlheCtiPT47u+ZELazX3Z8sdpWRj2r3 WA8dw+IJ8bZKkp3oAE8JPoIDF5X6t1iAbDrEdRRpAIRPjCk+bOgmsr9Jr+Iw7AJrIbR9y825NxuU 6ZjHvwdsbzV9G3NYe3OBT0ks7GR4jKGTKqMu7aTVSCb+umTrSwGFtOHirGJb+S2RnUkDm8TFTI7a JObfdb9C5xb0yxHWjQocm0I/Bhz9sn+Rvnn/lcgfXNIJVgyDuxrQZLCgdISWiWz05uGblXuVVQ9Q iw== --000000000000f661ae05fa2e7578--