Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <763c41bb-7452-1ded-ace5-8cda9ca64788@quicinc.com>
Date:   Wed, 26 Apr 2023 13:09:56 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH] wifi: ath11k: update proper pdev/vdev id for testmode
 command
Content-Language: en-US
To:     Kalle Valo <kvalo@kernel.org>
CC:     <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
        Venkateswara Naralasetty <quic_vnaralas@quicinc.com>
References: <20230424092420.12794-1-quic_rajkbhag@quicinc.com>
 <87a5yvt831.fsf@kernel.org>
From:   Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>
In-Reply-To: <87a5yvt831.fsf@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/26/2023 12:59 PM, Kalle Valo wrote:
> Raj Kumar Bhagat <quic_rajkbhag@quicinc.com> writes:
> 
>> From: Venkateswara Naralasetty <quic_vnaralas@quicinc.com>
>>
>> User can extend test mode command support to set vdev and pdev params
>> for debug purpose at run time by sending vdev/pdev param set command
>> through the testmode command interface.
>>
>> Fill the proper pdev/vdev id in driver since, pdev/vdev id details may
>> not be available at user space. It will make sure that the proper
>> vdev/pdev ids are sent to firmware.
>>
>> Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.7.0.1-01744-QCAHKSWPL_SILICONZ-1
>>
>> Depends-On:
>> 	[v3,3/4] wifi: ath11k: factory test mode support
>>
>> Signed-off-by: Venkateswara Naralasetty <quic_vnaralas@quicinc.com>
>> Signed-off-by: Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>
>> ---
> 
> Please add 'Depends-on' after the '---' line. This is for future
> patches, no need to resend because of this.
> 

Thanks for pointing this. Will take care for future patches.

Thanks,
Raj