Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authenticated-By: 
From:   Ping-Ke Shih <pkshih@realtek.com>
To:     Zhang Shurong <zhang_shurong@foxmail.com>
CC:     "tony0620emma@gmail.com" <tony0620emma@gmail.com>,
        "kvalo@kernel.org" <kvalo@kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3 0/2] wifi: rtw88: error codes fix patches
Thread-Topic: [PATCH v3 0/2] wifi: rtw88: error codes fix patches
Thread-Index: AQHZeGJ27jYL+1Dzf0WhQst+fewc+a8+UeVA
Date:   Thu, 27 Apr 2023 00:47:07 +0000
Message-ID: <5629deb196114fefb12f5f2273b4786d@realtek.com>
References: <tencent_1BB7243C6EDA6B2BB6E2C1563C1614D45009@qq.com>
In-Reply-To: <tencent_1BB7243C6EDA6B2BB6E2C1563C1614D45009@qq.com>
Accept-Language: en-US, zh-TW
Content-Language: zh-TW
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Precedence: bulk


> -----Original Message-----
> From: Zhang Shurong <zhang_shurong@foxmail.com>
> Sent: Thursday, April 27, 2023 1:02 AM
> To: Ping-Ke Shih <pkshih@realtek.com>
> Cc: tony0620emma@gmail.com; kvalo@kernel.org; davem@davemloft.net; edumazet@google.com; kuba@kernel.org;
> pabeni@redhat.com; linux-wireless@vger.kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
> Zhang Shurong <zhang_shurong@foxmail.com>
> Subject: [PATCH v3 0/2] wifi: rtw88: error codes fix patches
> 
> rtw88 does not handle the failure during copy_from_user or invalid
> user-provided data. We fix such problems by first modifying the return
> value of customized function rtw_debugfs_copy_from_user. Then for all
> the callers rtw_debugfs_set_*, we receive the returned error code.
> Moreover, negative code is returned if the user-provided data is invalid
> instead of a positive value count.
> 
> The changes in this version:
> - check by if (ret) instead of check by if (ret < 0)

It would be better if you preserve the change of v2 as changelog.
v3 is okay to me, so don't need v4 if no other reviewer has comment
for this patchset.

> 
> Zhang Shurong (2):
>   wifi: rtw88: fix incorrect error codes in rtw_debugfs_copy_from_user
>   wifi: rtw88: fix incorrect error codes in rtw_debugfs_set_*
> 
>  drivers/net/wireless/realtek/rtw88/debug.c | 59 ++++++++++++++++------
>  1 file changed, 43 insertions(+), 16 deletions(-)
> 
> --
> 2.40.0
>