Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e05d4d4d33a2c50973d139752b4fcfad5dbdf056.camel@redhat.com>
Subject: Re: [PATCH net-next] wifi: ath11k: Use list_count_nodes()
From:   Paolo Abeni <pabeni@redhat.com>
To:     Kalle Valo <kvalo@kernel.org>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org, ath11k@lists.infradead.org,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Date:   Thu, 27 Apr 2023 09:07:34 +0200
In-Reply-To: <87v8hiosci.fsf@kernel.org>
References: <941484caae24b89d20524b1a5661dd1fd7025492.1682542084.git.christophe.jaillet@wanadoo.fr>
         <87v8hiosci.fsf@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2023-04-27 at 07:35 +0300, Kalle Valo wrote:
> Christophe JAILLET <christophe.jaillet@wanadoo.fr> writes:
>=20
> > ath11k_wmi_fw_stats_num_vdevs() and ath11k_wmi_fw_stats_num_bcn() reall=
y
> > look the same as list_count_nodes(), so use the latter instead of hand
> > writing it.
> >=20
> > The first ones use list_for_each_entry() and the other list_for_each(),=
 but
> > they both count the number of nodes in the list.
> >=20
> > While at it, also remove to prototypes of non-existent functions.
> > Based on the names and prototypes, it is likely that they should be
> > equivalent to list_count_nodes().
> >=20
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> > ---
> > Un-tested
>=20
> I'll run sanity tests on ath11k patches. I'll also add "Compile tested
> only" to the commit log.
>=20
> Oh, and ath11k patches go to ath tree, not net-next.

Just for awareness, there are 2 additional patches apparently targeting
net-next but being instead for the WiFi tree:

https://lore.kernel.org/all/e77ed7f719787cb8836a93b6a6972f4147e40bc6.168253=
7509.git.christophe.jaillet@wanadoo.fr/
https://lore.kernel.org/all/e6ec525c0c5057e97e33a63f8a4aa482e5c2da7f.168254=
1872.git.christophe.jaillet@wanadoo.fr/

Cheers,

Paolo