Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Larry Finger <larry.finger@gmail.com>
Content-Type: multipart/mixed; boundary="------------1Z6k6nMckqgHmYBAFUkW9KKH"
Message-ID: <866570c9-38d8-1006-4721-77e2945170b9@lwfinger.net>
Date:   Thu, 27 Apr 2023 21:00:28 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH] wifi: rtl8xxxu: fix authentication timeout due to
 incorrect RCR value
To:     Yun Lu <luyun_611@163.com>, Jes.Sorensen@gmail.com
Cc:     kvalo@kernel.org, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, linux-wireless@vger.kernel.org,
        netdev@vger.kernel.org
References: <20230427020512.1221062-1-luyun_611@163.com>
Content-Language: en-US
From:   Larry Finger <Larry.Finger@lwfinger.net>
In-Reply-To: <20230427020512.1221062-1-luyun_611@163.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------1Z6k6nMckqgHmYBAFUkW9KKH
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 4/26/23 21:05, Yun Lu wrote:
> From: Yun Lu <luyun@kylinos.cn>
> 
> When using rtl8192cu with rtl8xxxu driver to connect wifi, there is a
> probability of failure, which shows "authentication with ... timed out".
> Through debugging, it was found that the RCR register has been inexplicably
> modified to an incorrect value, resulting in the nic not being able to
> receive authenticated frames.
> 
> To fix this problem, add regrcr in rtl8xxxu_priv struct, and store
> the RCR value every time the register is writen, and use it the next
> time the register need to be modified.

I added the attached patch to see what was different between the two values in 
REG_RCR. To my surprise, nothing was logged.

Please add this one on top of you proposed patch, and send me the output from 
the log.

Thanks,

Larry


--------------1Z6k6nMckqgHmYBAFUkW9KKH
Content-Type: text/x-patch; charset=UTF-8; name="log_data.patch"
Content-Disposition: attachment; filename="log_data.patch"
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL01ha2VmaWxlIGIvTWFrZWZpbGUKaW5kZXggZjU1NDNlZWY0ZjgyLi42
ZDk4NWExNzVkNzggMTAwNjQ0Ci0tLSBhL01ha2VmaWxlCisrKyBiL01ha2VmaWxlCkBAIC0x
LDggKzEsOCBAQAogIyBTUERYLUxpY2Vuc2UtSWRlbnRpZmllcjogR1BMLTIuMAogVkVSU0lP
TiA9IDYKLVBBVENITEVWRUwgPSAzCitQQVRDSExFVkVMID0gNAogU1VCTEVWRUwgPSAwCi1F
WFRSQVZFUlNJT04gPQorRVhUUkFWRVJTSU9OID0gLXJjMAogTkFNRSA9IEh1cnIgZHVyciBJ
J21hIG5pbmphIHNsb3RoCiAKICMgKkRPQ1VNRU5UQVRJT04qCmRpZmYgLS1naXQgYS9kcml2
ZXJzL25ldC93aXJlbGVzcy9yZWFsdGVrL3J0bDh4eHh1L3J0bDh4eHh1X2NvcmUuYyBiL2Ry
aXZlcnMvbmV0L3dpcmVsZXNzL3JlYWx0ZWsvcnRsOHh4eHUvcnRsOHh4eHVfY29yZS5jCmlu
ZGV4IDgzMTYzOWQ3MzY1Ny4uYjUyMTJjZWI0ZWI0IDEwMDY0NAotLS0gYS9kcml2ZXJzL25l
dC93aXJlbGVzcy9yZWFsdGVrL3J0bDh4eHh1L3J0bDh4eHh1X2NvcmUuYworKysgYi9kcml2
ZXJzL25ldC93aXJlbGVzcy9yZWFsdGVrL3J0bDh4eHh1L3J0bDh4eHh1X2NvcmUuYwpAQCAt
NjUwNCw2ICs2NTA0LDEwIEBAIHN0YXRpYyB2b2lkIHJ0bDh4eHh1X2NvbmZpZ3VyZV9maWx0
ZXIoc3RydWN0IGllZWU4MDIxMV9odyAqaHcsCiAJc3RydWN0IHJ0bDh4eHh1X3ByaXYgKnBy
aXYgPSBody0+cHJpdjsKIAl1MzIgcmNyID0gcHJpdi0+cmVncmNyOwogCisJaWYgKHJjciAh
PSBydGw4eHh4dV9yZWFkMzIocHJpdiwgUkVHX1JDUikpIHsKKwkJcHJfaW5mbygiQkVGT1JF
OiBSRUdfUkNSIGRpZmZlcnMgZnJvbSByZWdyY3I6IDB4JXggaW5zdGVkIG9mIDB4JXhcbiIs
CisJCQlydGw4eHh4dV9yZWFkMzIocHJpdiwgUkVHX1JDUiksIHByaXYtPnJlZ3Jjcik7CisJ
fQogCWRldl9kYmcoJnByaXYtPnVkZXYtPmRldiwgIiVzOiBjaGFuZ2VkX2ZsYWdzICUwOHgs
IHRvdGFsX2ZsYWdzICUwOHhcbiIsCiAJCV9fZnVuY19fLCBjaGFuZ2VkX2ZsYWdzLCAqdG90
YWxfZmxhZ3MpOwogCkBAIC02NTQ3LDYgKzY1NTEsMTAgQEAgc3RhdGljIHZvaWQgcnRsOHh4
eHVfY29uZmlndXJlX2ZpbHRlcihzdHJ1Y3QgaWVlZTgwMjExX2h3ICpodywKIAkgKiBGSUZf
UFJPQkVfUkVRIGlnbm9yZWQgYXMgcHJvYmUgcmVxdWVzdHMgYWx3YXlzIHNlZW0gdG8gYmUg
YWNjZXB0ZWQKIAkgKi8KIAorCWlmIChyY3IgIT0gcnRsOHh4eHVfcmVhZDMyKHByaXYsIFJF
R19SQ1IpKSB7CisJCXByX2luZm8oIkFGVEVSOiBSRUdfUkNSIGRpZmZlcnMgZnJvbSByZWdy
Y3I6IDB4JXggaW5zdGVkIG9mIDB4JXhcbiIsCisJCQlydGw4eHh4dV9yZWFkMzIocHJpdiwg
UkVHX1JDUiksIHByaXYtPnJlZ3Jjcik7CisJfQogCXJ0bDh4eHh1X3dyaXRlMzIocHJpdiwg
UkVHX1JDUiwgcmNyKTsKIAlwcml2LT5yZWdyY3IgPSByY3I7CiAK

--------------1Z6k6nMckqgHmYBAFUkW9KKH--