Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp1641619rwr; Thu, 27 Apr 2023 22:52:54 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5k78gLEcrORbWXCa7U1ihgXH5jtkNUNF+pszkALF8SLQo9b6aCF0EHLqwyGf6EUtjrW4pl X-Received: by 2002:a05:6a20:9143:b0:f4:1acb:8b1f with SMTP id x3-20020a056a20914300b000f41acb8b1fmr5387395pzc.2.1682661174319; Thu, 27 Apr 2023 22:52:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682661174; cv=none; d=google.com; s=arc-20160816; b=tXeLBMptBku/QxqcgZ8tzWVxWs0NKFi6zDPyrqpufgWqHnM/GZfrA25IezMMGEGxvd cydwp2J/bw3UPXSK+AqI+6PAYfVe/kZQ9X/jEH1H+kBQ5wxyLAhV1F3pbF2vTVlylOIE bkSVIFfk51E4z1fK85uWgv7mDKfk2M7XEsfQQ+i95qqzZ9fh6ORnygelbpulVffpBPlW ldHFPZtxBCmxzhNWK4E6Xdx4eozQ2tNDhMedEVVeqNOSrDNCWMPqzdS2rgvoc1ON6CE0 BhOAp4M1LntNbWKXwWJ6i50Rnso6gUETWRj6HIrw3E34I+qG3PxyN2J6aBoX5rtnZA4v avYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=ekz6N25T0cgrgk2DqlXhYGLC16QBYGWLzP1y2wqvr/4=; b=KJjurIk6zAjSz1w/HbbQ1fcAjqB/5A0lNCzzRxh7m5tjoJmb8voYFA2eWlpWGMYV5P N7Ej5/u1rN3uf1RRYA156zI9JBxTV/OR5788aRR20uxBFGRxFCWsuH0sm0rtytW2d81p AyeoBEmmAVgY/aRijTM6m2EETlZF7VmzyMQSAZN3sU4pNMhCuvOuvsbcAZoRo4N+lYo+ jG54jp0rJc5En52n5pVa3wb6NjsONN43SQ3tITOlKM2mje62qGtFNOsscfF5MggkiFIg Ahjfd8nPoHZdxxxxwoOTF08qHa2Z1RMupz7TQIGWqa4DGJEGtpj2QFX4WPjrLeBYU7aU lYVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sBDZPzys; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y62-20020a638a41000000b0051b6e9d4daesi22214850pgd.585.2023.04.27.22.52.42; Thu, 27 Apr 2023 22:52:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sBDZPzys; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345112AbjD1Fkl (ORCPT + 62 others); Fri, 28 Apr 2023 01:40:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345054AbjD1Fkk (ORCPT ); Fri, 28 Apr 2023 01:40:40 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BED431BC5 for ; Thu, 27 Apr 2023 22:40:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5492463F9B for ; Fri, 28 Apr 2023 05:40:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3EADC433EF; Fri, 28 Apr 2023 05:40:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682660438; bh=Z6NUqTrlWX5VBE5oRjZuHIG9wfGp1DFGIcVkDpuGTfQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=sBDZPzys/tD7jgEOxzC6LLL/GIRgSqOJptkcw25m44BTW0nq0yOSg3fXaSb7fzORy rICmSfY0MNSZkdDu7QNbsKSVK9NkMWL1SiIfRVd7j0uxoDd+1kPpUnlPR3sOzDWdOy FMl1u/czxdGoQKMd7E7eFDhARbmZdQDSxVSjQ/GiK3PsjiF0aExUnlGeIDKBVxf/H+ 5+iAZIscW0d6nXHMp4TE4Tj4AZ0wPujljMJJYRnbDtqKztI1zH8DQ0/QCDBdMIIFa9 56QlecN2LbUrJE1pwn2CscRqtX2gLFpwoMBN/UoKDFTanb3RJVC6hkAIeW8QNqjS7y 3rzMKy6lq30kg== From: Kalle Valo To: Kevin Lo Cc: linux-wireless@vger.kernel.org, Bitterblue Smith , Jes Sorensen , Ping-Ke Shih Subject: Re: [PATCH v2] wifi: rtl8xxxu: 8188f: no need to initialize interrupts References: Date: Fri, 28 Apr 2023 08:40:34 +0300 In-Reply-To: (Kevin Lo's message of "Fri, 28 Apr 2023 10:34:17 +0800") Message-ID: <87ildgpnsd.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Kevin Lo writes: > There's no need to initialize interrupts for RTL8188FTV like the vendor driver. > > Signed-off-by: Kevin Lo Why do this, what's the benefit? Or is this just a theoretical fix. The commit log should explain this. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches