Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 28 Apr 2023 14:34:54 +0800
From:   Kevin Lo <kevlo@kevlo.org>
To:     Kalle Valo <kvalo@kernel.org>
Cc:     linux-wireless@vger.kernel.org,
        Bitterblue Smith <rtl8821cerfe2@gmail.com>,
        Jes Sorensen <Jes.Sorensen@gmail.com>,
        Ping-Ke Shih <pkshih@realtek.com>
Subject: Re: [PATCH v2] wifi: rtl8xxxu: 8188f: no need to initialize
 interrupts
Message-ID: <ZEtpDi8oCr0E9scd@ns.kevlo.org>
References: <ZEswqUHBXPHC/znL@ns.kevlo.org>
 <87ildgpnsd.fsf@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87ildgpnsd.fsf@kernel.org>
Precedence: bulk

On Fri, Apr 28, 2023 at 08:40:34AM +0300, Kalle Valo wrote:
> 
> Kevin Lo <kevlo@kevlo.org> writes:
> 
> > There's no need to initialize interrupts for RTL8188FTV like the vendor driver.
> >
> > Signed-off-by: Kevin Lo <kevlo@kevlo.org>
> 
> Why do this, what's the benefit? Or is this just a theoretical fix. The
> commit log should explain this.

If I understand correctly, just like rtw88 usb devices, rtl8xxxu has no
hardware interrupt.