Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Larry Finger <larry.finger@gmail.com>
Content-Type: multipart/mixed; boundary="------------dXNjmVauvoy0tmBnxkx4nmvc"
Message-ID: <d3743b66-23b1-011c-9dcd-c408b1963fca@lwfinger.net>
Date:   Fri, 28 Apr 2023 12:06:03 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH] wifi: rtl8xxxu: fix authentication timeout due to
 incorrect RCR value
Content-Language: en-US
To:     wo <luyun_611@163.com>
Cc:     Jes.Sorensen@gmail.com, kvalo@kernel.org, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org
References: <20230427020512.1221062-1-luyun_611@163.com>
 <866570c9-38d8-1006-4721-77e2945170b9@lwfinger.net>
 <76a784b2.2cb3.187c60f0f68.Coremail.luyun_611@163.com>
From:   Larry Finger <Larry.Finger@lwfinger.net>
In-Reply-To: <76a784b2.2cb3.187c60f0f68.Coremail.luyun_611@163.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------dXNjmVauvoy0tmBnxkx4nmvc
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 4/27/23 23:11, wo wrote:
> [  149.595642] [pid:7,cpu6,kworker/u16:0,0]BEFORE: REG_RCR differs from regrcr: 
> 0x1830613 insted of 0x7000604e
> [  160.676422] [pid:237,cpu6,kworker/u16:5,3]BEFORE: REG_RCR differs from 
> regrcr: 0x70006009 insted of 0x700060ce
 > [  327.234588] [pid:7,cpu7,kworker/u16:0,5]BEFORE: REG_RCR differs from 
regrcr: 0x1830d33 insted of 0x7000604e


My patch was messed up, but it got the information that I wanted, which is shown 
in the quoted lines above. One of these differs only in the low-order byte, 
while the other 2 are completely different. Strange!

It is possible that there is a firmware error. My system, which does not show 
the problem, reports the following:

[54130.741148] usb 3-6: RTL8192CU rev A (TSMC) romver 0, 2T2R, TX queues 2, 
WiFi=1, BT=0, GPS=0, HI PA=0
[54130.741153] usb 3-6: RTL8192CU MAC: xx:xx:xx:xx:xx:xx
[54130.741155] usb 3-6: rtl8xxxu: Loading firmware rtlwifi/rtl8192cufw_TMSC.bin
[54130.742301] usb 3-6: Firmware revision 88.2 (signature 0x88c1)

Which firmware does your unit use?

Attached is a new test patch. When it logs a CORRUPTED value, I would like to 
know what task is attached to the pid listed in the message. Note that the two 
instances where the entire word was wrong came from pid:7.

Could improper locking could produce these results?

Larry

--------------dXNjmVauvoy0tmBnxkx4nmvc
Content-Type: text/x-patch; charset=UTF-8; name="log_data_2.patch"
Content-Disposition: attachment; filename="log_data_2.patch"
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL01ha2VmaWxlIGIvTWFrZWZpbGUKaW5kZXggZjU1NDNlZWY0ZjgyLi42
ZDk4NWExNzVkNzggMTAwNjQ0Ci0tLSBhL01ha2VmaWxlCisrKyBiL01ha2VmaWxlCkBAIC0x
LDggKzEsOCBAQAogIyBTUERYLUxpY2Vuc2UtSWRlbnRpZmllcjogR1BMLTIuMAogVkVSU0lP
TiA9IDYKLVBBVENITEVWRUwgPSAzCitQQVRDSExFVkVMID0gNAogU1VCTEVWRUwgPSAwCi1F
WFRSQVZFUlNJT04gPQorRVhUUkFWRVJTSU9OID0gLXJjMAogTkFNRSA9IEh1cnIgZHVyciBJ
J21hIG5pbmphIHNsb3RoCiAKICMgKkRPQ1VNRU5UQVRJT04qCmRpZmYgLS1naXQgYS9kcml2
ZXJzL25ldC93aXJlbGVzcy9yZWFsdGVrL3J0bDh4eHh1L3J0bDh4eHh1X2NvcmUuYyBiL2Ry
aXZlcnMvbmV0L3dpcmVsZXNzL3JlYWx0ZWsvcnRsOHh4eHUvcnRsOHh4eHVfY29yZS5jCmlu
ZGV4IDgzMTYzOWQ3MzY1Ny4uOWQ3Nzg0MDBkMmI5IDEwMDY0NAotLS0gYS9kcml2ZXJzL25l
dC93aXJlbGVzcy9yZWFsdGVrL3J0bDh4eHh1L3J0bDh4eHh1X2NvcmUuYworKysgYi9kcml2
ZXJzL25ldC93aXJlbGVzcy9yZWFsdGVrL3J0bDh4eHh1L3J0bDh4eHh1X2NvcmUuYwpAQCAt
NDg2NCw2ICs0ODY0LDEwIEBAIHJ0bDh4eHh1X2Jzc19pbmZvX2NoYW5nZWQoc3RydWN0IGll
ZWU4MDIxMV9odyAqaHcsIHN0cnVjdCBpZWVlODAyMTFfdmlmICp2aWYsCiAJdTMyIHZhbDMy
OwogCXU4IHZhbDg7CiAKKwlpZiAocHJpdi0+cmVncmNyICE9IHJ0bDh4eHh1X3JlYWQzMihw
cml2LCBSRUdfUkNSKSkgeworCQlwcl9pbmZvKCJSRUdfUkNSIGNvcnJ1cHRlZCBpbiAlczog
MHgleCBpbnN0ZWQgb2YgMHgleFxuIiwKKwkJCV9fZnVuY19fLCBydGw4eHh4dV9yZWFkMzIo
cHJpdiwgUkVHX1JDUiksIHByaXYtPnJlZ3Jjcik7CisJfQogCXJhcnB0ID0gJnByaXYtPnJh
X3JlcG9ydDsKIAogCWlmIChjaGFuZ2VkICYgQlNTX0NIQU5HRURfQVNTT0MpIHsKQEAgLTY1
MDQsNiArNjUwOCwxMCBAQCBzdGF0aWMgdm9pZCBydGw4eHh4dV9jb25maWd1cmVfZmlsdGVy
KHN0cnVjdCBpZWVlODAyMTFfaHcgKmh3LAogCXN0cnVjdCBydGw4eHh4dV9wcml2ICpwcml2
ID0gaHctPnByaXY7CiAJdTMyIHJjciA9IHByaXYtPnJlZ3JjcjsKIAorCWlmIChwcml2LT5y
ZWdyY3IgIT0gcnRsOHh4eHVfcmVhZDMyKHByaXYsIFJFR19SQ1IpKSB7CisJCXByX2luZm8o
IlJFR19SQ1IgY29ycnVwdGVkIGluICVzOiAweCV4IGluc3RlZCBvZiAweCV4XG4iLAorCQkJ
X19mdW5jX18sIHJ0bDh4eHh1X3JlYWQzMihwcml2LCBSRUdfUkNSKSwgcHJpdi0+cmVncmNy
KTsKKwl9CiAJZGV2X2RiZygmcHJpdi0+dWRldi0+ZGV2LCAiJXM6IGNoYW5nZWRfZmxhZ3Mg
JTA4eCwgdG90YWxfZmxhZ3MgJTA4eFxuIiwKIAkJX19mdW5jX18sIGNoYW5nZWRfZmxhZ3Ms
ICp0b3RhbF9mbGFncyk7CiAK

--------------dXNjmVauvoy0tmBnxkx4nmvc--