Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <431b8d98c2e5d81c20862965151ac63596f04bf3.camel@sipsolutions.net>
Subject: Re: [PATCH] wifi: rtlwifi: rtl8192cu: Remove driver
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Larry Finger <Larry.Finger@lwfinger.net>,
        Kalle Valo <kvalo@kernel.org>
Cc:     linux-wireless@vger.kernel.org
Date:   Fri, 28 Apr 2023 20:41:53 +0200
In-Reply-To: <20230428182933.19157-1-Larry.Finger@lwfinger.net>
References: <20230428182933.19157-1-Larry.Finger@lwfinger.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Fri, 2023-04-28 at 13:29 -0500, Larry Finger wrote:
> --- a/drivers/net/wireless/realtek/rtlwifi/core.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/core.c
> @@ -1770,12 +1770,6 @@ static void rtl_op_flush(struct ieee80211_hw *hw,
> =C2=A0static int rtl_op_set_tim(struct ieee80211_hw *hw, struct ieee80211=
_sta *sta,
> =C2=A0			=C2=A0 bool set)
> =C2=A0{
> -	struct rtl_priv *rtlpriv =3D rtl_priv(hw);
> -	struct rtl_hal *rtlhal =3D rtl_hal(rtl_priv(hw));
> -
> -	if (rtlhal->hw_type =3D=3D HARDWARE_TYPE_RTL8192CU)
> -		schedule_work(&rtlpriv->works.update_beacon_work);
> -
> =C2=A0	return 0;
> =C2=A0}
> =C2=A0

Looks like you could remove that entire method if it does nothing now,
it doesn't matter to mac80211 if you have it or not (since you don't use
AP_LINK_PS.)

Not sure it matters to you in the driver :)

johannes