Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Larry Finger <larry.finger@gmail.com>
Message-ID: <52684230-07e3-ebd6-8418-4eae54672575@lwfinger.net>
Date:   Fri, 28 Apr 2023 14:02:55 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH] wifi: rtlwifi: rtl8192cu: Remove driver
Content-Language: en-US
To:     Johannes Berg <johannes@sipsolutions.net>,
        Kalle Valo <kvalo@kernel.org>
Cc:     linux-wireless@vger.kernel.org
References: <20230428182933.19157-1-Larry.Finger@lwfinger.net>
 <431b8d98c2e5d81c20862965151ac63596f04bf3.camel@sipsolutions.net>
From:   Larry Finger <Larry.Finger@lwfinger.net>
In-Reply-To: <431b8d98c2e5d81c20862965151ac63596f04bf3.camel@sipsolutions.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 4/28/23 13:41, Johannes Berg wrote:
> On Fri, 2023-04-28 at 13:29 -0500, Larry Finger wrote:
>> --- a/drivers/net/wireless/realtek/rtlwifi/core.c
>> +++ b/drivers/net/wireless/realtek/rtlwifi/core.c
>> @@ -1770,12 +1770,6 @@ static void rtl_op_flush(struct ieee80211_hw *hw,
>>   static int rtl_op_set_tim(struct ieee80211_hw *hw, struct ieee80211_sta *sta,
>>   			  bool set)
>>   {
>> -	struct rtl_priv *rtlpriv = rtl_priv(hw);
>> -	struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
>> -
>> -	if (rtlhal->hw_type == HARDWARE_TYPE_RTL8192CU)
>> -		schedule_work(&rtlpriv->works.update_beacon_work);
>> -
>>   	return 0;
>>   }
>>   
> 
> Looks like you could remove that entire method if it does nothing now,
> it doesn't matter to mac80211 if you have it or not (since you don't use
> AP_LINK_PS.)
> 
> Not sure it matters to you in the driver :)

I thought about doing that, but decided to leave the empty one there until I 
could do more testing. Leaving it will add a few bytes to the driver, but that 
should not make much difference.

Larry