Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Larry Finger <larry.finger@gmail.com>
Message-ID: <53260a3b-9256-07a2-1d66-553e865362b7@lwfinger.net>
Date:   Sat, 29 Apr 2023 12:03:14 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH] wifi: rtlwifi: rtl8192cu: Remove driver
Content-Language: en-US
To:     Martin Kaistra <martin.kaistra@linutronix.de>,
        Kalle Valo <kvalo@kernel.org>
Cc:     Johannes Berg <johannes@sipsolutions.net>,
        linux-wireless@vger.kernel.org
References: <20230428182933.19157-1-Larry.Finger@lwfinger.net>
 <cab66a9d-9a66-7cd1-408b-91e8cd9d8a9c@linutronix.de>
From:   Larry Finger <Larry.Finger@lwfinger.net>
In-Reply-To: <cab66a9d-9a66-7cd1-408b-91e8cd9d8a9c@linutronix.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/29/23 04:42, Martin Kaistra wrote:
> Am 28.04.23 um 20:29 schrieb Larry Finger:
>> The functionality of these devices has been replaced by the rtl8xxxu
>> driver, thus the version under rtlwifi can be removed.
>>
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> 
> Things to keep in mind:
> - rtlwifi offers AP mode support for rtl8192cu devices, rtl8xxxu doesn't (yet) 
> do that. Should be relatively easy to add that on top of [1], though.
> - The rtl8192cu devices are currently hidden behind CONFIG_RTL8XXXU_UNTESTED in 
> the rtl8xxxu driver with the comment "Still supported by rtlwifi".
> 
> 
> [1] 
> https://lore.kernel.org/linux-wireless/20230428150833.218605-1-martin.kaistra@linutronix.de/

Kalle,

I failed to consider this point. Please drop my patch. Instead, I will submit 
one to remove that configuration parameter that says the rtl8192cu is "untested".

Larry