Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp1597358rwr; Wed, 3 May 2023 18:32:47 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6uPGjRYtJG8QbXy4U/dKNsGFN2k2g4ztsq3i0nFyoyr/bd4ot7rZ0epzBHAOrwxNz7V+aK X-Received: by 2002:a05:6a20:54a1:b0:f2:14f7:c1e1 with SMTP id i33-20020a056a2054a100b000f214f7c1e1mr868483pzk.12.1683163967030; Wed, 03 May 2023 18:32:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683163967; cv=none; d=google.com; s=arc-20160816; b=e/NIFc/zuTi9QBBAunh8zsYo0YydRE1UTea1LVylAs1gfEvbEHCPwRIybahSOBIDOk IV3nNZwpPA7lkyYkgeA65tiTyJbYhRgjlzpelze6qeRbotqdVn2kmufDh7CUiQmB0Pcx bP7nsssT9BzTBunoBghV4okQ3MtYPkQV4qV/0emhJPVrEqxNHz2sPWoSMlBL63zNREuy cmTWMXcq7xNoEjOdYeS1WD8hw4//8gWqDNyw69joNeL+klWi8UBhdclXHW+RnAGuLXgR uAi36LuesGmEaVfA5rHLdjALwiBht1I8U6BXzQCwqbKDIoScR5mSVGyg6I/ZIggv+XDF 0wOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from:authenticated-by; bh=dBh2bfJmcW9dgYYPUJUzW1pwEklK2Tu+3d9JfpDjbjU=; b=Sr7cfk0N4nV+k1UfI7+eqc40tdoMxl/W8w+JqfeCi5sWFI26DU32v+gtlFkQsTAX5P KmNFk4FcI++0m7nqYvaO7R35RW7VzZIFMBR0HIpNLzrxympluzJ6fgdmTHbbqy/9H+jt y1Do1836rWw5+5mxEJdwtOkmxSmUqojD4tbdaXynK+EE2PmAW9NShc50+J4vOKOeGqWF mFckB2CHfNItVyVxeKkwF5a1aetQGAGuXnDPjmgKKdgj3tfGkGr7livaiZ1wxI4qvtsm HixLuT1SSXTOtxxPQwlZa+O3wYfcbFUbw8Gx3asj6CJlmAVQSfeXXD/gMpg42Ue+qkhW JIIQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d24-20020a63ed18000000b00528ca114e67si13639200pgi.898.2023.05.03.18.32.18; Wed, 03 May 2023 18:32:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229785AbjEDBQe convert rfc822-to-8bit (ORCPT + 61 others); Wed, 3 May 2023 21:16:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229761AbjEDBQd (ORCPT ); Wed, 3 May 2023 21:16:33 -0400 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A4B8101; Wed, 3 May 2023 18:16:29 -0700 (PDT) Authenticated-By: X-SpamFilter-By: ArmorX SpamTrap 5.77 with qID 3441GA4H0026212, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36505.realtek.com.tw[172.21.6.25]) by rtits2.realtek.com.tw (8.15.2/2.81/5.90) with ESMTPS id 3441GA4H0026212 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=OK); Thu, 4 May 2023 09:16:10 +0800 Received: from RTEXMBS01.realtek.com.tw (172.21.6.94) by RTEXH36505.realtek.com.tw (172.21.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.32; Thu, 4 May 2023 09:16:14 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXMBS01.realtek.com.tw (172.21.6.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Thu, 4 May 2023 09:16:13 +0800 Received: from RTEXMBS04.realtek.com.tw ([fe80::e138:e7f1:4709:ff4d]) by RTEXMBS04.realtek.com.tw ([fe80::e138:e7f1:4709:ff4d%5]) with mapi id 15.01.2375.007; Thu, 4 May 2023 09:16:13 +0800 From: Ping-Ke Shih To: Dan Carpenter , Bernie Huang CC: Yan-Hsuan Chuang , Kalle Valo , "linux-wireless@vger.kernel.org" , "kernel-janitors@vger.kernel.org" Subject: RE: [PATCH] wifi: rtw88: unlock on error path in rtw_ops_add_interface() Thread-Topic: [PATCH] wifi: rtw88: unlock on error path in rtw_ops_add_interface() Thread-Index: AQHZfdFZxTos89hEMEC3CDV8yFWan69JUEdA Date: Thu, 4 May 2023 01:16:13 +0000 Message-ID: <4f09ff0dd95143a3a70f6fa641a66fca@realtek.com> References: In-Reply-To: Accept-Language: en-US, zh-TW Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.21.69.188] x-kse-serverinfo: RTEXMBS01.realtek.com.tw, 9 x-kse-antispam-interceptor-info: fallback x-kse-antivirus-interceptor-info: fallback Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-ServerInfo: RTEXH36505.realtek.com.tw, 9 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-Antivirus-Interceptor-Info: fallback X-KSE-AntiSpam-Interceptor-Info: fallback X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org > -----Original Message----- > From: Dan Carpenter > Sent: Wednesday, May 3, 2023 11:10 PM > To: Bernie Huang > Cc: Yan-Hsuan Chuang ; Kalle Valo ; Ping-Ke Shih > ; linux-wireless@vger.kernel.org; kernel-janitors@vger.kernel.org > Subject: [PATCH] wifi: rtw88: unlock on error path in rtw_ops_add_interface() > > Call mutex_unlock(&rtwdev->mutex); before returning on this error path. > > Fixes: f0e741e4ddbc ("wifi: rtw88: add bitmap for dynamic port settings") > Signed-off-by: Dan Carpenter Reviewed-by: Ping-Ke Shih [...]