Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp776433rwr; Fri, 5 May 2023 05:03:42 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6n/zrtD+DamxGcKY8HBM/ISQFK5eTqWWc8AIZ6mZyTNvp1yBodRmPhr7q0h4RodqIekaSz X-Received: by 2002:a17:90a:3e4a:b0:24e:534f:7b70 with SMTP id t10-20020a17090a3e4a00b0024e534f7b70mr998006pjm.48.1683288222354; Fri, 05 May 2023 05:03:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683288222; cv=none; d=google.com; s=arc-20160816; b=BkeV5DR22jrc4VHetZEZwkkLX+Pun+24ztaDKbfffJauMjrgPDhd/s3Oqh5EC4mrOQ 6UhH5oZ3/0kk7FFQVzEKp1z/zCw2CiSdre/MNm/ik/ZSC6iRJQ91lyRsbGElf3E7Sxx4 Efvfea1bNqI78rXn7B7a9PQzlQgh2kYIXnZ3gHKjYhNWG44rpeZLzW9wkqLLXypFKVpu eBn6MjNQMzzpHqsEWWNLtw5wUV+zGAJnBu/8bzlFQbzbhDmah+7vQZCiaHzkNfX3GsdB +hJiOfR/s16TEJfzbbW21nDSKR6RSEsyiOsIgofpRvh+vbTc2iN04RSrOaejGDrLB7I3 fxiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=w0Jn7T88DrcDAiXCfsup8Og+dKwS+mD6VLc96s+khqM=; b=mSwPiRDERbeF00xA01rmmRpbwh22/uVW6eaUCEgQ34fbUkCvnCOMMwmM0piW9YlQ56 cORWheqCIabYmB9BXnts+s16TWJg1FRoZy+ksyY8acJop9/J7vTgMkdvYskkQl2gpupx Yno8zbjJB2nimjCMd4cTVylbTFkIbwf4wDYb8teMzO0MzNjEIJXPkZLaUS+4KG59VNsd Rb4elMpcvgO6BhGvszPGJscfj7baiEesyRan4W6cEJFO+oyXm4Y5scgmAgCBaW2sWkzI s5ptF9yRHkidsq0rd9bT3SGbsQ7Ieazlf69txWi6oQbTLxOeOgoEvcC6/af2UjNW51sa 8h5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=af8ibFnj; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x21-20020a17090ab01500b0024dfb91753bsi6108019pjq.4.2023.05.05.05.03.16; Fri, 05 May 2023 05:03:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=af8ibFnj; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232059AbjEEMCU (ORCPT + 61 others); Fri, 5 May 2023 08:02:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232057AbjEEMCH (ORCPT ); Fri, 5 May 2023 08:02:07 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37D3C1C0E8; Fri, 5 May 2023 05:01:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 95E9563D98; Fri, 5 May 2023 12:01:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1538EC4339B; Fri, 5 May 2023 12:01:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683288111; bh=5mLh7jfZI1nfWLVwYkSpPhEzk5XtMGt0LfKmDL5kA/g=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=af8ibFnj7doVZmxVcbqEpsn8LJ7lVystx1XcVNeuYnVZxuCGYxCwBesY//RNgy3zo IdzABBRLfqbimsQo9mWhsH3FQGscjPnwIWpSi7mDPZsZY+VRj+FVHKq3rk0HDINMsF Fyd8sbdAdY3XxGVSBlyZFV5NzCxx5wLDR2w31FPwC2JiD12jHny9+bnI9CZwBgJQjm LFlhrPWlKLkWVlUBnG6hKcx2vuEmAtIKNcKjsLzvgzDB2Dr5LhDUtqPOOwiSurzlU5 B2HnBfmAgpMK6dv3+78BQyT4ZD4A2VHPiRcO+YMz8eAYHnFlb7uUg8IY9E38Syy9pa BKiQyKAfhfMcw== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: rtw89: fix rtw89_read_chip_ver() for RTL8852B and RTL8851B From: Kalle Valo In-Reply-To: References: To: Dan Carpenter Cc: Ping-Ke Shih , linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <168328810808.30117.5754345043778347753.kvalo@kernel.org> Date: Fri, 5 May 2023 12:01:49 +0000 (UTC) X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Dan Carpenter wrote: > The if statement is reversed so it will not record the chip version. > This was detected using Smatch: > > drivers/net/wireless/realtek/rtw89/core.c:3593 rtw89_read_chip_ver() > error: uninitialized symbol 'val'. > > Fixes: a6fb2bb84654 ("wifi: rtw89: read version of analog hardware") > Signed-off-by: Dan Carpenter > Acked-by: Ping-Ke Shih Patch applied to wireless-next.git, thanks. 9d4f491b860e wifi: rtw89: fix rtw89_read_chip_ver() for RTL8852B and RTL8851B -- https://patchwork.kernel.org/project/linux-wireless/patch/e4d912a2-37f8-4068-8861-7b9494ae731b@kili.mountain/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches