Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp860035rwr; Fri, 5 May 2023 06:09:24 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7Hd52jca7Rc4R2Yp78MziZQUOHyVyGS2uN5lemoh8CIPMiLpMXP2jO3IYIx0FBgDnOb4Wz X-Received: by 2002:a05:6a20:4295:b0:fe:1383:eab2 with SMTP id o21-20020a056a20429500b000fe1383eab2mr2015272pzj.2.1683292163638; Fri, 05 May 2023 06:09:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683292163; cv=none; d=google.com; s=arc-20160816; b=Rd9E5pAE1vUinsTK7OeJIAVhIIOtJRYxcAGkY9E1/yArhipttNX8qmTAC/P30I5W1d +opVGpttB764fPofH5RTP1iPtM3tI9tlAJZppjis/meF7EaeleBSaVCeRFkssImi4kfL I3bKYJi4CCChDVqCj1eGnT8XKKm0NwKGDNIs4NPV3oJPkeqxhutIhyY6eW51YWTd5iKL QUJIPFMFSt/GvTEdE0oIktBD/2orpujxHckSqmnDh94g9m5c12r9DT2v3TzS04U2Tqvz i/K5tOJ+ZRo/Om+fnwvkshSDA8/OD/BHuKSWylHEuokIwdCNSf3Wqahb4P5021UCeFOg i2BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=klj6WyzfTmE6ZEwFgAOmwFx4RXycJwMdZUPgQqo4PrA=; b=BUg6kmH/1CcW/uVRjhok2NV5QN2LGurhqoQG7f1hoqMzvsP/0/YaUdtSBqLdGcmkRk fOl5M7vUNA/kKKCixO3C2PAXE86G+waG4mQoG8d1TzhJKAu9kUw6ny2eW6LvHSa1me2n FgFiSOrXrWTd8PLMH/dSzVMmi7d6L/4mZ0dq8+AtiHPd2n06tPaPRw9zpUZqqj93MiWa bdCWjnvc031zWAsiO0lG0giAbIPxv7yevMCZlmc+kv5lpay69Dj1oH2oze1p8tuhPb62 PMELCo1dHaYsHgpw6Kjf8kfmn9JeJJ7MeBs61Wz8juBZQbMhA1N0Rx1tJrnj8qOO1nlZ tcCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="t/mbZcq+"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l23-20020a639857000000b0051bb415165dsi2001920pgo.194.2023.05.05.06.09.01; Fri, 05 May 2023 06:09:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="t/mbZcq+"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229904AbjEENBm (ORCPT + 60 others); Fri, 5 May 2023 09:01:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232313AbjEENBi (ORCPT ); Fri, 5 May 2023 09:01:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E4101E988; Fri, 5 May 2023 06:01:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 57DDD63DE1; Fri, 5 May 2023 13:01:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31970C4339B; Fri, 5 May 2023 13:01:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683291695; bh=/jJRR7zmYd2NwUUaRgBBZHi/LSaazlrrBn7yHDLa/LU=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=t/mbZcq+P0886LZVkw2H1mTTOmyup06UBoiSTdWhIW6Pn6ti/K1wrQluxmIYHiFX/ Z6FgPgYD8y39GyFjDQSwKPs5E9q8akELmhuy6/C30zOz6E6QbpX09JfjrNgpkBVJo3 v7n5MDbBuyMfZdrYXOk+WApl27ejJx/RxVFnvu3xea9Pr+Nw9Fsvdel9d9vurJuakS CDMCra2j+xn6DXRQqMJJlRuDmxAFX5Y3Z2toQDTG4zyQH50hs+mXV04eFVZlzrOkiv zq0mlLy21GDgKPClAGK8mSRk+kr1Q/I90ANi4oH4NLMHNqN76yucZXW6dY3nitoEh5 m6RzZgD6N6qsQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: ath10k: Serialize wake_tx_queue ops From: Kalle Valo In-Reply-To: <20230323165527.156414-1-alexander@wetzel-home.de> References: <20230323165527.156414-1-alexander@wetzel-home.de> To: Alexander Wetzel Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgens?= =?utf-8?q?en?= , Alexander Wetzel , Felix Fietkau , stable@vger.kernel.org User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <168329168628.4336.2281740515872835038.kvalo@kernel.org> Date: Fri, 5 May 2023 13:01:34 +0000 (UTC) X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Alexander Wetzel wrote: > Serialize the ath10k implementation of the wake_tx_queue ops. > ath10k_mac_op_wake_tx_queue() must not run concurrent since it's using > ieee80211_txq_schedule_start(). > > The intend of this patch is to sort out an issue discovered in the discussion > referred to by the Link tag. > > I can't test it with real hardware and thus just implemented the per-ac queue > lock Felix suggested. One obvious alternative to the per-ac lock would be to > bring back the txqs_lock commit bb2edb733586 ("ath10k: migrate to mac80211 txq > scheduling") dropped. > > Fixes: bb2edb733586 ("ath10k: migrate to mac80211 txq scheduling") > Reported-by: Felix Fietkau > Link: https://lore.kernel.org/r/519b5bb9-8899-ae7c-4eff-f3116cdfdb56@nbd.name > CC: > Signed-off-by: Alexander Wetzel > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. b719ebc37a1e wifi: ath10k: Serialize wake_tx_queue ops -- https://patchwork.kernel.org/project/linux-wireless/patch/20230323165527.156414-1-alexander@wetzel-home.de/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches