Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authenticated-By: 
From:   Ping-Ke Shih <pkshih@realtek.com>
To:     Ping-Ke Shih <pkshih@realtek.com>,
        Dan Carpenter <dan.carpenter@linaro.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>
CC:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [bug report] wifi: rtw88: usb: fix priority queue to endpoint mapping
Thread-Topic: [bug report] wifi: rtw88: usb: fix priority queue to endpoint
 mapping
Thread-Index: AQHZfnckew+PUCPgkEGu0NoEQg74H69PrtFAgABqVRA=
Date:   Mon, 8 May 2023 09:00:25 +0000
Message-ID: <f0206253275b4e0a8b0e4097084f2109@realtek.com>
References: <c3f70197-829d-48ed-ae15-66a9de80fa90@kili.mountain>
 <ab52f337fdf842499912458efab7704c@realtek.com>
In-Reply-To: <ab52f337fdf842499912458efab7704c@realtek.com>
Accept-Language: en-US, zh-TW
Content-Language: zh-TW
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Precedence: bulk


> -----Original Message-----
> From: Ping-Ke Shih <pkshih@realtek.com>
> Sent: Monday, May 8, 2023 10:39 AM
> To: Dan Carpenter <dan.carpenter@linaro.org>; s.hauer@pengutronix.de
> Cc: linux-wireless@vger.kernel.org
> Subject: RE: [bug report] wifi: rtw88: usb: fix priority queue to endpoint mapping
> 
> Hi Sascha,
> 
> > -----Original Message-----
> > From: Dan Carpenter <dan.carpenter@linaro.org>
> > Sent: Thursday, May 4, 2023 6:56 PM
> > To: s.hauer@pengutronix.de
> > Cc: linux-wireless@vger.kernel.org
> > Subject: [bug report] wifi: rtw88: usb: fix priority queue to endpoint mapping
> >
> > Hello Sascha Hauer,
> >
> > The patch a6f187f92bcc: "wifi: rtw88: usb: fix priority queue to
> > endpoint mapping" from Apr 17, 2023, leads to the following Smatch
> > static checker warning:
> >
> > drivers/net/wireless/realtek/rtw88/usb.c:219 rtw_usb_parse() warn: assigning (-22) to unsigned variable
> > 'rtwusb->qsel_to_ep[8]'
> 
> [...]
> 
> >     218         rtwusb->qsel_to_ep[TX_DESC_QSEL_TID7] = dma_mapping_to_ep(rqpn->dma_map_vo);
> > --> 219         rtwusb->qsel_to_ep[TX_DESC_QSEL_TID8] = -EINVAL;
> >
> > Can't save negative error codes to a u8.
> >
> 
> return type of dma_mapping_to_ep() is 'int' and it also possibly returns -EINVAL, and
> rtwusb->qsel_to_ep[] is used by qsel_to_ep() that also use 'int' as return type.
> Therefore, I would like to change type of qsel_to_ep[] from 'u8' to 'int'. Does it
> work to you?
> 

I have made a patch [1] along with above idea. 

[1] https://lore.kernel.org/linux-wireless/20230508085539.46795-1-pkshih@realtek.com/T/#u

Ping-Ke