Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Larry Finger <larry.finger@gmail.com>
Message-ID: <3c157ef7-8bf3-e886-769c-c27b9cc00547@lwfinger.net>
Date:   Mon, 8 May 2023 09:04:03 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [bug report] wifi: rtw88: usb: fix priority queue to endpoint
 mapping
Content-Language: en-US
To:     Ping-Ke Shih <pkshih@realtek.com>,
        Dan Carpenter <dan.carpenter@linaro.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>
Cc:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
References: <c3f70197-829d-48ed-ae15-66a9de80fa90@kili.mountain>
 <ab52f337fdf842499912458efab7704c@realtek.com>
From:   Larry Finger <Larry.Finger@lwfinger.net>
In-Reply-To: <ab52f337fdf842499912458efab7704c@realtek.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/7/23 21:39, Ping-Ke Shih wrote:
> return type of dma_mapping_to_ep() is 'int' and it also possibly returns -EINVAL, and
> rtwusb->qsel_to_ep[] is used by qsel_to_ep() that also use 'int' as return type.
> Therefore, I would like to change type of qsel_to_ep[] from 'u8' to 'int'. Does it
> work to you?
> 
Sasha and Ping-Ke,

I have been testing using s8 rather than u8 for qsel_to_ep[], if you would like 
to keep the array the same size. All the values fit within the s8 limits.

Larry