Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0e7023062f44d0ea68625c27cb13731d17857311.camel@sipsolutions.net>
Subject: Re: [PATCH 10/27] wifi: mac80211: isolate driver from inactive links
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Wen Gong <quic_wgong@quicinc.com>, linux-wireless@vger.kernel.org
Cc:     ath11k@lists.infradead.org
Date:   Wed, 10 May 2023 13:24:40 +0200
In-Reply-To: <5e3ec5f8-1462-5de6-2b5a-4cf62f23deb7@quicinc.com>
References: <20220902141259.377789-1-johannes@sipsolutions.net>
         <20220902161143.5ce3dad3be7c.I92e9f7a6c120cd4a3631baf486ad8b6aafcd796f@changeid>
         <5d82e564-86bf-c26b-077a-d0bc14e2d3c3@quicinc.com>
         <74f3eb848326607b15336c31a02bdd861ccafb47.camel@sipsolutions.net>
         <d10b88b4-0bd7-a38c-e8d7-8982a281c4b3@quicinc.com>
         <e5adbed1524b27228c152ba14f78c550c8730baa.camel@sipsolutions.net>
         <5e3ec5f8-1462-5de6-2b5a-4cf62f23deb7@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Wed, 2023-05-10 at 19:06 +0800, Wen Gong wrote:
> On 4/11/2023 3:38 PM, Johannes Berg wrote:
> > On Tue, 2023-04-04 at 11:28 +0800, Wen Gong wrote:
> > > May I also add a field such as "u16 active_links_count" in struct
> > > wiphy_iftype_ext_capab,
> > > and add logic in function ieee80211_set_vif_links_bitmaps() for stati=
on
> > > like this ?:
> > > if (active_links_count && hweight16(links) <=3D active_links_count)
> > >   =C2=A0=C2=A0=C2=A0 then sdata->vif.active_links =3D links;
> > >=20
> > Also here, not sure it makes sense in cfg80211 level?
> >=20
> > Though I'm not sure what the idea here is at all - you can refuse to
> > link switch etc, what would you use this for?
> >=20
> > Then again, we haven't really designed out all the link selection stuff=
,
> > do we want wpa_s to do it, driver to do it, etc.? Hence debugfs. So
> > depending on what end up doing there, we will obviously need to
> > advertise some level of link-concurrency to userspace.
>=20
> So will you plan to do something to let wpa_s/userspace app=20
> active/deactive links?
>=20
> Or you already have implemented that?
>=20

No plans right now, and honestly not sure what the right thing even is.

johannes