Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Larry Finger <larry.finger@gmail.com>
Message-ID: <880bb4ed-f3a5-2d7f-db10-fec65087dd05@lwfinger.net>
Date:   Wed, 10 May 2023 16:47:24 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: Driver for rtw8723ds
Content-Language: en-US
To:     Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc:     =?UTF-8?Q?Jernej_=c5=a0krabec?= <jernej.skrabec@gmail.com>,
        linux-wireless <linux-wireless@vger.kernel.org>
References: <72a8eeb1-c91c-80a7-5a09-1b7963e0996b@lwfinger.net>
 <5930608.lOV4Wx5bFT@jernej-laptop>
 <813d74b8-6d9f-c7b0-40b4-c661fca13002@lwfinger.net>
 <CAFBinCB3xnCrLvEvqsFMQuDxL+xC9tkxnwubfC+xEMP3-ZXqSg@mail.gmail.com>
 <527585e5-9cdd-66ed-c3af-6da162f4b720@lwfinger.net>
 <CAFBinCCdbt0OAHMnGPYA+xH8WC1nWqJPP5aBU48R=LHRu_xuew@mail.gmail.com>
 <77bdcc7b-c3b2-7c3b-5146-9b7f8c3ae5a7@lwfinger.net>
 <CAFBinCAA2CXZBRO7yb4Hjg6Cos4JFQiCMWZLGVh8DCOYWg7HhA@mail.gmail.com>
From:   Larry Finger <Larry.Finger@lwfinger.net>
In-Reply-To: <CAFBinCAA2CXZBRO7yb4Hjg6Cos4JFQiCMWZLGVh8DCOYWg7HhA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 5/10/23 16:07, Martin Blumenstingl wrote:
> On Wed, May 10, 2023 at 12:02 AM Larry Finger <Larry.Finger@lwfinger.net> wrote:
> [...]
>> I added that patch to the driver. The user reports that he was able to do a ping
>> and an nslookup before it crashed with the following in the log:
> That's some positive news alongside the crash log: it seems that a
> part of the driver works! :-)
> 
>> [    8.700626] skbuff: skb_over_panic: text:ffff8000011924ac len:3341 put:3341
>> head:ffff000003b3c000 data:ffff000003b3c040 tail:0xd4d end:0x2c0 dev:<NULL>
> [...]
>> Somehow skb->tail was greater than skb->end. Unfortunately I do not have access
>> to gdb to tell you what line corresponds to rtw_sdio_rx_skb+0x50 on the MangoPi
>> MQ Quad.
> I need to have a closer look at the pkg_offset and struct
> rtw_rx_pkt_stat which we receive.
> Recently my own MangoPI MQ-Quad arrived but I did not have the time to
> set it up yet. I'll try to do so during the weekend so I can debug
> this on my own.
> 
> Please ping me next week in case I haven't provided any update until then.

I have some test prints in to check for skb overrun. My initial indication is 
that the problem was in the c2h branch of rtw_sdio_rx_skb(), but my next run 
should verify that. My changes will do a pr_warn_once() when the problem 
happens, and then drop the skb.

My contact reported that he had one run of 3 minutes before the problem 
happened, which is good news for most of the driver.

Larry