Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Larry Finger <Larry.Finger@lwfinger.net>
Cc:     Martin Kaistra <martin.kaistra@linutronix.de>,
        Johannes Berg <johannes@sipsolutions.net>,
        linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wifi: rtlwifi: rtl8192cu: Remove driver
References: <20230428182933.19157-1-Larry.Finger@lwfinger.net>
        <cab66a9d-9a66-7cd1-408b-91e8cd9d8a9c@linutronix.de>
        <53260a3b-9256-07a2-1d66-553e865362b7@lwfinger.net>
Date:   Thu, 11 May 2023 14:34:27 +0300
In-Reply-To: <53260a3b-9256-07a2-1d66-553e865362b7@lwfinger.net> (Larry
        Finger's message of "Sat, 29 Apr 2023 12:03:14 -0500")
Message-ID: <873543nlto.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Larry Finger <Larry.Finger@lwfinger.net> writes:

> On 4/29/23 04:42, Martin Kaistra wrote:
>> Am 28.04.23 um 20:29 schrieb Larry Finger:
>>> The functionality of these devices has been replaced by the rtl8xxxu
>>> driver, thus the version under rtlwifi can be removed.
>>>
>>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>>
>> Things to keep in mind:
>> - rtlwifi offers AP mode support for rtl8192cu devices, rtl8xxxu
>> doesn't (yet) do that. Should be relatively easy to add that on top
>> of [1], though.
>> - The rtl8192cu devices are currently hidden behind
>> CONFIG_RTL8XXXU_UNTESTED in the rtl8xxxu driver with the comment
>> "Still supported by rtlwifi".
>>
>>
>> [1]
>> https://lore.kernel.org/linux-wireless/20230428150833.218605-1-martin.kaistra@linutronix.de/
>
> Kalle,
>
> I failed to consider this point. Please drop my patch. Instead, I will
> submit one to remove that configuration parameter that says the
> rtl8192cu is "untested".

The original reason why we added CONFIG_RTL8XXXU_UNTESTED back in the
day was so that we would not have two drivers supporting the same
hardware. Though I don't know how much the kconfig helped with that but
at least the conflicts were somehow documented.

Now that rtl8xxxu has matured and gained more features, I would really
like the idea of removing rtl8192cu driver. Of course we should make
sure that we are not accidentally removing any devices support, for
example I was not able to find this device in rtl8xxxu:

	{RTL_USB_DEVICE(USB_VENDOR_ID_REALTEK, 0x817c, rtl92cu_hal_cfg)},

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches