Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 11 May 2023 14:26:40 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Larry Finger <Larry.Finger@lwfinger.net>
Cc:     Yun Lu <luyun_611@163.com>, Jes.Sorensen@gmail.com,
        kvalo@kernel.org, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, linux-wireless@vger.kernel.org,
        netdev@vger.kernel.org
Subject: Re: [PATCH v2] wifi: rtl8xxxu: fix authentication timeout due to
 incorrect RCR value
Message-ID: <ZFzfAH+a4ivS3gXo@corigine.com>
References: <20230511031825.2125279-1-luyun_611@163.com>
 <d8b5f499-6778-34c0-1f12-9d0f6698abb7@lwfinger.net>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d8b5f499-6778-34c0-1f12-9d0f6698abb7@lwfinger.net>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fFP4lmM42NZZVXx1hs6BEs/QhZJoScAAcZb/rlKHJNO0ASVA/38A1U7sXAEa?=
 =?us-ascii?Q?3Xfq5rhgTKz3diF9v7s/o7BO3o7ezWjXsThbCn6Yyg8oQqMxxn1Syd9YuisM?=
 =?us-ascii?Q?X/iF7tfXf23MgqJcagLN8nZ3IIzK+oa0qICR+yZR6OJkqaGjVdvZwxXhxG/P?=
 =?us-ascii?Q?MW39rwU1ez4JEa/AaqtMcHnhq1m9RuEgCkVKsF9YRRLK1rWsdiu+Ky9OB2uC?=
 =?us-ascii?Q?sqAuBx6QVsTtH7oDBOVUHNG4XZl75UoGhPWbEasx0ZR4PINn/N5uuf5c+hEh?=
 =?us-ascii?Q?JnaDo3eRN8sbcvzGwsOcHMMvd4sMDhvhO3KVMK5VQZyYMi1exOxGjn3+4cGx?=
 =?us-ascii?Q?aOEHdPX0/hVINQCQ0AcgltJ4C1dWLwPaL9rpKddP7VRd4NAbuVpcsuTuruBr?=
 =?us-ascii?Q?0ylHrqkRv91NMPwPddBOiKIb4ob/tK8d6fQB5B4qIyye3jBy1V2SncVcSFdN?=
 =?us-ascii?Q?j9IEnyZGKe8qFlhqaK93KdUcaDNXMvgTIt5SVYcto66GbENLz1TIJyq5OtzU?=
 =?us-ascii?Q?FkLpK30QIXPm/4D0O3WTjsf6kAqVqRlBVM43lUcJc1ho96xcvQAi+mR50Nbv?=
 =?us-ascii?Q?mjWMd/bcGWXHtNGm15pSdplJTTkZpRB+BeyPUoNCAjBIHvv+BiH4AhNdQFET?=
 =?us-ascii?Q?qPJypl+vm4V0jXMtXWMp/E+IuMgYe0IptT88EfJ0/uTJSgi3dqBqwwoSGgPw?=
 =?us-ascii?Q?sUW31XhKVHnztA0k7UyeAMZ7IzeZ9/qZvwK+yxAb/OxDat7olAZ3pnIW7bJg?=
 =?us-ascii?Q?8LQmgvVkuCkz9Jcz779p0mtuT/GRLdM21qg/flczYKaHUGtly71u/tMo/aw+?=
 =?us-ascii?Q?eYIIGHQ+x1i+JYUK9nUIUuK4gEcdort7cHnAvHvBWJb6uKfLAFnV4bKCbv6Y?=
 =?us-ascii?Q?cSwJ07Jyzs8OoC6vcaKvFHGxY0Ns9pvvn3lsRq9mv01Zqq5L3MkAv9JVpXg8?=
 =?us-ascii?Q?yuAhXsg/t1f8t0TVGnTPONYvfGWQL9Gynyq8oE5Oj2EjhFC28d7BH37inD80?=
 =?us-ascii?Q?R/Ixy1hv3HsaYKQdG/FBeqLnq5YfF/TMtkgAb9QU34uWS4nZbDSvdoUzmCn1?=
 =?us-ascii?Q?GRLwaMpwd0G6SvdCho4PXYCURsVuxf7HSyJX9ThmEc42CD1KV7pSFLk9b5eY?=
 =?us-ascii?Q?W1LjntTW7g/IqkwRhBqwKFYZstWoJ4jKmfo6NB5YGMHIGJbsuV0J08C/4oL5?=
 =?us-ascii?Q?hNzIhwDNz4aTUNZNmntCjii0rcc4HmIP+ix8XRbqvbmKArcl0PTHOulduReE?=
 =?us-ascii?Q?3BnOB699SThQ+BKOb32CmjbfPGG8Rvx934xcbsW7vY4VRA2mPsWp4x5X3qZe?=
 =?us-ascii?Q?9fv1NtkT5MxUrAKNjAiFqIRHMXZeveHagRI1e80io9Fczugp/RSWT0AmtldV?=
 =?us-ascii?Q?XajKRqDE6Oz9jifL3Ej4hZqHWI8mEKJCtGnK4jRV4KKkCikgotTUyo9vUgEa?=
 =?us-ascii?Q?3KJzTxuLuX8vu8eE6mHLPGOn6dl6jkYawGVnlIy/Tfbt1D3M9My54Rr8UmBz?=
 =?us-ascii?Q?ijjkglC5sqn3l9Os/ef/sIjLRMnfBkVFvF8CSAHhuWjUumH6eAAcwi/yFGpw?=
 =?us-ascii?Q?7GftLRgCREk8kGTPxOpMJgKxiRbOFGLrNfa87Nei9KwFJ47N/TXE2vqn7S4m?=
 =?us-ascii?Q?WvhTaPiEhqJZGFVU+mxUAG8uWDL5MbOTNDv/LewlQx1LyGaNaYjcWBymBRFT?=
 =?us-ascii?Q?NFzB4Q=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c9b3868-805f-4625-230f-08db521afd48
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2023 12:26:47.6472
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1e4LCsPkJV6m7G1OwP6cyXSBcf8gOM1xfkmBUQnH67PjQvulGyELKadRXcg+n4NAU/M5z6CJP6qmQ/luDkK362LVCcvg25dXA9yzlNfj6Kw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB5496
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Wed, May 10, 2023 at 11:34:19PM -0500, Larry Finger wrote:
> On 5/10/23 22:18, Yun Lu wrote:
> > From: Yun Lu <luyun@kylinos.cn>
> > 
> > When using rtl8192cu with rtl8xxxu driver to connect wifi, there is a
> > probability of failure, which shows "authentication with ... timed out".
> > Through debugging, it was found that the RCR register has been inexplicably
> > modified to an incorrect value, resulting in the nic not being able to
> > receive authenticated frames.
> > 
> > To fix this problem, add regrcr in rtl8xxxu_priv struct, and store
> > the RCR value every time the register is writen, and use it the next

nit: s/writen/written/

> > time the register need to be modified.
> > 
> > Signed-off-by: Yun Lu <luyun@kylinos.cn>

...