Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp8795610rwr; Thu, 11 May 2023 06:24:49 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5plhbD+gO6RkXEoPX8S7Tz72PfN4YQVnH5B5VJ6wuYH+x/XLVkOAd2Uak1yLVlZSARo9oc X-Received: by 2002:a17:90a:4ec7:b0:252:79f3:ded4 with SMTP id v7-20020a17090a4ec700b0025279f3ded4mr3781730pjl.34.1683811488833; Thu, 11 May 2023 06:24:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683811488; cv=none; d=google.com; s=arc-20160816; b=Ze96v9W6wCEYtlPQ5jjuXWZhp8rhIO1TKZpjnqUqVnY+/I14sMgE8Pjtv8+/KMSqe9 H1DSxF5m8NCtwluBFFPuptOVdOMu4HXfw8pYjETt7tMV7/Cnw6v9wmMWyiZ1lp4EB7Gb i16HOYSnOwHOFQfpiooL3Y2+mQC+HO0e84fYvzZXFN3KGSxXF4+BfB4eQAw8qds+45pT pSTaoMnCRzSTxOh1yG99tbiL2EIywaxgd92hdR7tHOVh/oK4sHcFyxXOf8IGBHMyFuT4 AxPA7E9egzVY8m0YBpXFq36PuTYFl7aHqcanjYjSipTbNkQHZXp/ijRHQxBUY/2AcGxI +l8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=NwS/YKYUgEiTIkOI7kpAkJXihANO931X2tCA1ACrFDA=; b=iIJUAxz5UCPCEopmRzhdhhxMCiravP+1Csd+5WHLgAw1OA3wch3MIsv7kMKEO41EPH hlwg5CY9jjBvBaKidbIH3iBUDMQKeEfyW/+3qVEAII3L8oj4fhn9zOo7sLqljQK6+rOG g/wTEUH559BhoxWtQ7LywssZKxAI61HBuBuBC48GAa6elRx3+O5tqxheipp56PF+suU2 4u2GA4Qt2KtmRsgyyPMLQn69peM18A/YOP1bZBM1VLh3Iey66nLkZHk51qW+6LsYtqmS 60BAN/jQLpIRvzS53MuJF1lcFusJE8FwffDqXnxmH6Ujvn+eOMqi/wAMns0q9P2dJ82p z5bQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=t6vFzM6x; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id na16-20020a17090b4c1000b00237155f2303si12056567pjb.136.2023.05.11.06.24.40; Thu, 11 May 2023 06:24:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=t6vFzM6x; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238267AbjEKNU0 (ORCPT + 61 others); Thu, 11 May 2023 09:20:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238061AbjEKNUD (ORCPT ); Thu, 11 May 2023 09:20:03 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB1B110E66; Thu, 11 May 2023 06:18:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E482C61652; Thu, 11 May 2023 13:18:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E721C433D2; Thu, 11 May 2023 13:18:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683811082; bh=4YERbDXXstqPQ1/3lmZBAHqtWDMcORq7IokrQhfuPJ8=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=t6vFzM6xY6fG+dhEsI7HSJ1LTrlos7nN46mFAyCnJ88bveaRcIONCTKsErgUwLLtc pYF4cL3DZ29AaxB+ffbABHRGvC450LHo3OuVW0d8JGtzdnjhfBTJ751qbjdrWovGHG nfS52rSgsU9UtS4mDQYbtxAbE7Jv6IJ+9LxD+DQhZi/LOuHRgKaRZF/7DZgIF9FyBK 3uvYZzsc1LrTUGCxeNrUvtpTHs6ul+sTb4nEbgbA9O94QdmdEWehS6flvGnUXbszwp 1awL1rZnpUmWQq3MUV5reDK9eESwfmjk8ySZZIvFtTAifEn9KBO05wMXV1pVhTX+Y+ JVhQ9VdWBhlcA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: rtw88: unlock on error path in rtw_ops_add_interface() From: Kalle Valo In-Reply-To: References: To: Dan Carpenter Cc: Po-Hao Huang , Yan-Hsuan Chuang , Ping-Ke Shih , linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <168381107884.27145.12968599583133133991.kvalo@kernel.org> Date: Thu, 11 May 2023 13:18:00 +0000 (UTC) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Dan Carpenter wrote: > Call mutex_unlock(&rtwdev->mutex); before returning on this error path. > > Fixes: f0e741e4ddbc ("wifi: rtw88: add bitmap for dynamic port settings") > Signed-off-by: Dan Carpenter > Reviewed-by: Ping-Ke Shih Patch applied to wireless-next.git, thanks. e2ff1181b3d4 wifi: rtw88: unlock on error path in rtw_ops_add_interface() -- https://patchwork.kernel.org/project/linux-wireless/patch/ddd10a74-5982-4f65-8c59-c1cca558d239@kili.mountain/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches