Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Larry Finger <larry.finger@gmail.com>
Message-ID: <da5e25df-75bd-5474-a7e6-1d86ad604261@lwfinger.net>
Date:   Thu, 11 May 2023 21:12:54 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH] wifi: rtlwifi: rtl8192cu: Remove driver
Content-Language: en-US
To:     Kalle Valo <kvalo@kernel.org>
Cc:     Martin Kaistra <martin.kaistra@linutronix.de>,
        Johannes Berg <johannes@sipsolutions.net>,
        linux-wireless@vger.kernel.org
References: <20230428182933.19157-1-Larry.Finger@lwfinger.net>
 <cab66a9d-9a66-7cd1-408b-91e8cd9d8a9c@linutronix.de>
 <53260a3b-9256-07a2-1d66-553e865362b7@lwfinger.net>
 <873543nlto.fsf@kernel.org>
From:   Larry Finger <Larry.Finger@lwfinger.net>
In-Reply-To: <873543nlto.fsf@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/11/23 06:34, Kalle Valo wrote:
> 
> The original reason why we added CONFIG_RTL8XXXU_UNTESTED back in the
> day was so that we would not have two drivers supporting the same
> hardware. Though I don't know how much the kconfig helped with that but
> at least the conflicts were somehow documented.
> 
> Now that rtl8xxxu has matured and gained more features, I would really
> like the idea of removing rtl8192cu driver. Of course we should make
> sure that we are not accidentally removing any devices support, for
> example I was not able to find this device in rtl8xxxu:
> 
> 	{RTL_USB_DEVICE(USB_VENDOR_ID_REALTEK, 0x817c, rtl92cu_hal_cfg)},

I will submit a patch to add this device, and check the vendor driver to see if 
there are any devices that were missed in the rtlwifi driver, but that can wait 
until I remove rtl8192cu, which has to wait until rtl8xxxu can support AP mode 
on the devices. When that happens, I will resubmit the patch for the removal of 
CONFIG_RTL8XXXU_UNTESTED as part of a 3-patch series.

Larry