Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f19bb9e3-a706-2a22-c1fb-029b77719831@gmail.com>
Date:   Sat, 13 May 2023 23:42:19 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v3 1/2] wifi: rtl8xxxu: Support new chip RTL8192FU
To:     Ping-Ke Shih <pkshih@realtek.com>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc:     "Jes.Sorensen@gmail.com" <Jes.Sorensen@gmail.com>
References: <98eff876-bb91-f51a-ffe9-b37d27518f9d@gmail.com>
 <094340810bbcbb7d85dd9c9c06b48d3a19aadd85.camel@realtek.com>
Content-Language: en-US
From:   Bitterblue Smith <rtl8821cerfe2@gmail.com>
In-Reply-To: <094340810bbcbb7d85dd9c9c06b48d3a19aadd85.camel@realtek.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 13/05/2023 09:13, Ping-Ke Shih wrote:
> On Fri, 2023-05-12 at 20:07 +0300, Bitterblue Smith wrote:
>> External mail.
>>
>>
>>
>> This is a newer chip, similar to the RTL8710BU in that it uses the same
>> PHY status structs.
>>
>> Features: 2.4 GHz, b/g/n mode, 2T2R, 300 Mbps.
>>
>> It can allegedly have Bluetooth, but that's not implemented here.
>>
>> This chip can have many RFE (RF front end) types, of which types 1
>> and 5 are the only ones tested. Many of the other types need different
>> initialisation tables. They can be added if someone wants them.
>>
>> The vendor driver v5.8.6.2_35538.20191028_COEX20190910-0d02 from
>> https://github.com/BrightX/rtl8192fu was used as reference, with
>> additional device IDs taken from
>> https://github.com/kelebek333/rtl8192fu-dkms.
>>
>> The vendor driver also claims to support devices with ID 0bda:a725,
>> but that is found in some bluetooth-only devices, so it's not supported
>> here.
>>
>> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
>> ---
>> v3:
>>  - Rebase on top of wireless-next.
>>  - Mark device 0b05:18b1 and RFE type 1 (ASUS USB-N13 C1) as tested.
>>
>> v2:
>>  - Feedback from Ping-Ke Shih:
>>    - Add rtl8xxxu_8192f.o to Makefile.
>>    - Initialise variable channel_idx in rtl8192fu_config_kfree() and
>>      variable ledcfg in rtl8192fu_led_brightness_set() to avoid
>>      warnings.
>>    - Give names to a lot of registers.
>>    - Initialise bb_gain_for_path in rtl8192fu_config_kfree() in two
>>      steps.
>>    - Don't assign the return value of rtl8xxxu_write32_mask() to
>>      variable val32 in rtl8xxxu_fill_iqk_matrix_b().
>>  - Add more information about device IDs to the commit message.
>> ---
>>  drivers/net/wireless/realtek/rtl8xxxu/Kconfig |    3 +-
>>  .../net/wireless/realtek/rtl8xxxu/Makefile    |    2 +-
>>  .../net/wireless/realtek/rtl8xxxu/rtl8xxxu.h  |   47 +
>>  .../realtek/rtl8xxxu/rtl8xxxu_8188f.c         |    3 +-
>>  .../realtek/rtl8xxxu/rtl8xxxu_8192f.c         | 2090 +++++++++++++++++
>>  .../realtek/rtl8xxxu/rtl8xxxu_8710b.c         |    1 +
>>  .../realtek/rtl8xxxu/rtl8xxxu_8723b.c         |    1 +
>>  .../wireless/realtek/rtl8xxxu/rtl8xxxu_core.c |  107 +-
>>  .../wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h |   39 +
>>  9 files changed, 2262 insertions(+), 31 deletions(-)
>>  create mode 100644 drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192f.c
>>
>>
> 
> [...]
> 
>> @@ -7484,6 +7522,9 @@ static int rtl8xxxu_probe(struct usb_interface *interface,
>>                 if (id->idProduct == 0x0109)
>>                         untested = 0;
>>                 break;
>> +       case 0x0b05:
>> +               if (id->idProduct == 0x18f1)
>> +                       untested = 0;
> 
> 'break;' is missing. 
> 

Ah, sorry about that.

>>         default:
>>                 break;
>>         }
>>
> 
> [...]
>