Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 14 May 2023 16:53:43 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Daniel Golle <daniel@makrotopia.org>
Cc:     linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-mediatek@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Felix Fietkau <nbd@nbd.name>,
        Lorenzo Bianconi <lorenzo@kernel.org>,
        Ryder Lee <ryder.lee@mediatek.com>,
        Shayne Chen <shayne.chen@mediatek.com>,
        Sean Wang <sean.wang@mediatek.com>,
        Kalle Valo <kvalo@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        Alexander Couzens <lynxis@fe80.eu>,
        Sujuan Chen <sujuan.chen@mediatek.com>,
        Bo Jiao <bo.jiao@mediatek.com>,
        Nicolas Cavallari <nicolas.cavallari@green-communications.fr>,
        Howard Hsu <howard-yh.hsu@mediatek.com>,
        MeiChia Chiu <MeiChia.Chiu@mediatek.com>,
        Peter Chiu <chui-hao.chiu@mediatek.com>,
        Johannes Berg <johannes.berg@intel.com>,
        Wang Yufen <wangyufen@huawei.com>,
        Lorenz Brun <lorenz@brun.one>
Subject: Re: [PATCH] wifi: mt76: mt7915: add support for MT7981
Message-ID: <ZGD192iDcUqoUwo3@corigine.com>
References: <ZF-SN-sElZB_g_bA@pidgin.makrotopia.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZF-SN-sElZB_g_bA@pidgin.makrotopia.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fdATbZspMpbMzBv2NDt0pATp7UmmpPJe2KtS0XB9cR9GeGWdEZhTYeizAxY7?=
 =?us-ascii?Q?eb0CwCR7ogFTtCHyJCikx2Zde7dqmGaUq8mfX8b8c/OvhGG6ol5jDS+7UV/p?=
 =?us-ascii?Q?h+mjxE9SbVvUoEMqNZsTa+KPHJTVkKG0S6Tpl5XEbkChG6DOTEq4WDDK3K37?=
 =?us-ascii?Q?rNHoq3wcrKFgk1xxuxjtltK1CsQcaYbsYmm42/G9hdWSzvqvaZFave4a87oK?=
 =?us-ascii?Q?qpt6Mqp8RhQ7GG0DdVrBRkCi8QmExbz165uzSaQU3EkDCWvs3Y2wuQYTi9eJ?=
 =?us-ascii?Q?/1Xh2n51wMDwA/llA47QZJ3Royo36+V8xONcbLpm5Xgm39Bx0LDBxGv9dk1I?=
 =?us-ascii?Q?A9hj06ZrvbzdtXbZkfiLDUIdvrI+6DQGtRXuhLJDF+xGN6o0A3y4anuKimqy?=
 =?us-ascii?Q?af0CjZlJI/+iih90NiE5/BPGl2hPxcChM43rcKA5E+YErF0UFMFE/5lX0bNR?=
 =?us-ascii?Q?OGe+tlsWJKNYhjFP0qPyQTv0d6uf2kjNci9nILntX5H22jZOdniXHHKrSHv3?=
 =?us-ascii?Q?NdLXIU3gvLMstBE8YzNQJRYkJd7EFWmKDBmzjhw0kd3Zcd8QiygxL3xWHToM?=
 =?us-ascii?Q?sAV1qN23Xpr3L8K2ZHcSfNCVzEhIBOojntwOFiTVddMpKCyIX1f6FXFP9NV0?=
 =?us-ascii?Q?EtMI6EAVeR7LjUCHs/snCgOGNoe4h4vnwIz6HJUotO0ZwTJ+izOMvB2hoy2r?=
 =?us-ascii?Q?M/POduZdAEWRQf4WxKjLOYUt5c0U3tdpjq3teAbnSRup11bE0wpsYn02jEDJ?=
 =?us-ascii?Q?yRGpDBGoyDtsj64GGpI/rpp6ySGd/8hOH/xRzanmAxjG30ts39bHkELed1+h?=
 =?us-ascii?Q?CNUdTWk9NB80dpWe5eIX3vBE44oiDoU3Q4VqAB7JQl519UERFHmjgoYiqOvU?=
 =?us-ascii?Q?Rqc+vGpk+vEoSIbcXi118uCvGv0zJWNDBLKEWBlIkOlivf5xJj4NCraC3iyT?=
 =?us-ascii?Q?hIivjJzxiI1m+h0fVKRNkto13i91Srv/dtwkEk2PYcxkLHgrQROHK+ohmhn5?=
 =?us-ascii?Q?l3HwMIK5Nsa5+jsEGCe/op6qMBkh7ANxhH1lDvsOX/3oBSEJTvm+lrKlovXB?=
 =?us-ascii?Q?PrP37SUZG07PN7QYdToViU9vqzXD9TD6z5/Cw2Tf95uCI/HvZKm058js0ybf?=
 =?us-ascii?Q?E1PFQyQGU2xsSNsWtHyaUhgge2g5FEg5+m7KWBDMAskvDtMXjFWRH5zl2c3x?=
 =?us-ascii?Q?CEYwXVt1ymhcuPUUxiRmm0KxeFei5Th7UksR4cvGSHP/tDID/lX2izLk9ai9?=
 =?us-ascii?Q?J6CgkvOEVzA13BJ9n36oLYiTEKHlflAbDD45NxSBzdLX44sadLIQgbIADH0J?=
 =?us-ascii?Q?P7TRxYJOM5PIziXwSwmKJu1judkqLyV6WNKsgbFjjE+sCdmzRUIxuH7DyUoI?=
 =?us-ascii?Q?ogJpa0ieEf4ehzNL2mFe3OYYgtHrdGmo5i5EJ1tFGo6tvQWCYzfPh8fseNXy?=
 =?us-ascii?Q?93hs2lSlQWZVIFGFis+XP2OBAPSF4Mar8PVPSkeojs4OVGfdhJhYRgZUszHq?=
 =?us-ascii?Q?6haJK9kr9MefD2xIoYQ9QsPmDoiyUsrSsN2/f33YGEwW4iBVVHktKPSBZ3Fy?=
 =?us-ascii?Q?5dkW8oF9qizqGGsnU/nJ/9YtWktSM8Zkj7DRdrWkVA1PYchp7XTc9LEu7GRY?=
 =?us-ascii?Q?Q8VyU669XR+5HAyO+mG+aA4JYgR1N1bGFqgKEC5zbX4StGoudW+nReTknQDc?=
 =?us-ascii?Q?vWNExw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 441c59d8-3042-40a3-1434-08db548b0860
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2023 14:53:52.3084
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SHKVQTvLysa47nyCDqwc21RlVRA3uKNdGNHZ82w3BpYakrucX79sTvgKpFBu6RIyX0uNHTZRjSk86dxhcrIYXc+Ml1g6NuqQSQb2zpdAYcw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR13MB3690
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Sat, May 13, 2023 at 03:35:51PM +0200, Daniel Golle wrote:
> From: Alexander Couzens <lynxis@fe80.eu>
> 
> Add support for the MediaTek MT7981 SoC which is similar to the MT7986
> but with a newer IP cores and only 2x ARM Cortex-A53 instead of 4x.
> Unlike MT7986 the MT7981 can only connect a single wireless frontend,
> usually MT7976 is used for DBDC.
> 
> Signed-off-by: Alexander Couzens <lynxis@fe80.eu>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>

...

> @@ -489,7 +516,10 @@ static int mt7986_wmac_adie_patch_7976(struct mt7915_dev *dev, u8 adie)
>  		rg_xo_01 = 0x1d59080f;
>  		rg_xo_03 = 0x34c00fe0;
>  	} else {
> -		rg_xo_01 = 0x1959f80f;
> +		if (is_mt7981(&dev->mt76))
> +			rg_xo_01 = 0x1959c80f;
> +		else if (is_mt7986(&dev->mt76))
> +			rg_xo_01 = 0x1959f80f;

Hi Daniel,

		rg_xo_01 will be used uninitialised below if we get here
		and neither of the conditions above are true.

		Can this occur?

>  		rg_xo_03 = 0x34d00fe0;
>  	}
>  

...