Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1849012rwd; Mon, 15 May 2023 04:05:19 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7/8DuTqko9B/isCqv+wY2j7+p0qob9uzPfqwNnm+lT/wfniSN5flmP+GbzVgcmaSbjizmy X-Received: by 2002:a17:903:120d:b0:1a5:2993:8aa6 with SMTP id l13-20020a170903120d00b001a529938aa6mr40359473plh.63.1684148719526; Mon, 15 May 2023 04:05:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684148719; cv=none; d=google.com; s=arc-20160816; b=yYx9MoauMjdNdp10kC2sSyolsYvt1JjhPdBR5ay9WpJ5o2vvs1EVpxkYUbEYqA42uU 6FSjBrbybRgNE8Egws2vHeWjx3D38CVdz1/Ry3+M9GXs+/j5uVYKIXDYJJiCNATvWHbu ebNS0j4oTIOwlef4IJp0C7rzAaKlpgtOKeAYcOBIArHy15FwpCZOsPdOU+NoFoZ2bgQ3 lILEImKFpFn8XXbDu6nPMG9CJlW8yrEYR7WjABdg0gwcfmd0Yfr1sGfPf7RtxoEu1W06 LVgYrONLa7leGnhoQR/oGWD9NLgAkFgfbFN6T3e/ragsC+Zn5ksFW63VRuuqgo/bJMVd tarQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=2SApDu49Dd87p2hugCMQcz/PfCI6LYeMCzMST9/wnss=; b=Y8/wE8Ilt/h5WWGbewU4t1Ap2Mvy/2mpkHALu3gA2BsRwQ/APX8yKkDl1AHlpNjEKc ldpYaqmxwZj+13gp5stWQW+P2u17wEREDklwFXPtlXPaGh5c3AsqR3CFLq44LlVLOVHc i9prM3xApcJW/hlvhuXFGxJ+LGdaamiMTeAaYsNb9snrp/VHV7lf8xQNsJBZbqFJP4mq 3n8raPA2nsjJBM8c0f9Dzntfude6FvYbBjcR3zQGF2Ds7Cty1xMlG243+6bqe6QgmWnv Xktn9Osf0hsdTAeLGS2lR0n7+l9K6Cf5Z+GBr0H3aEYVoWozS2QvygIwm0ojOWqUTk0Z 1R8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KRueawOO; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m17-20020a170902bb9100b001a8d80c7bb1si14601690pls.128.2023.05.15.04.05.07; Mon, 15 May 2023 04:05:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KRueawOO; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235707AbjEOLBl (ORCPT + 62 others); Mon, 15 May 2023 07:01:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232090AbjEOLBk (ORCPT ); Mon, 15 May 2023 07:01:40 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C1F493 for ; Mon, 15 May 2023 04:01:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C632D62280 for ; Mon, 15 May 2023 11:01:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B0F1C433D2; Mon, 15 May 2023 11:01:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684148499; bh=4mAlHlm1TO+UKzBjyEfEjZ5xwoceajajA0/RCVAfT9c=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=KRueawOOoYcKfWSH7TfEO522jF9PaGfxSKPu0QxQKWiqfTz1nRZhxeKa2m75dAjUq 8Jrd868VI7XxsTavXjpnE1hxwK5ghwDbybsd7vuY7mnapbyiOe83GmmG2ZXZOjRq7N BbEcWFIyc2tWp13VlKyroY2QalRUmBMbciPFb3/clg96l5HE9XBl0JodYtUomJNDEb UvKS2TvD3HCiS9J8GQFQcpfZP/s8nCuaULTXKYsK65ch7ocOFufq9lZcUzCx68C6sG OBydeKSp4N+aiUtwDTi/mJG0e4TNq7gBqt1UZZwVsJZjQH6VzO+KNTzDOpf39+dbRF r8lTnnbFHn0DQ== From: Kalle Valo To: Zhengchao Shao Cc: , , , , , , , , , , , Subject: Re: [PATCH net-next,v2] mac80211_hwsim: fix memory leak in hwsim_new_radio_nl References: <20230515092227.2691437-1-shaozhengchao@huawei.com> Date: Mon, 15 May 2023 14:01:34 +0300 In-Reply-To: <20230515092227.2691437-1-shaozhengchao@huawei.com> (Zhengchao Shao's message of "Mon, 15 May 2023 17:22:27 +0800") Message-ID: <87ilctn9ip.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Zhengchao Shao writes: > When parse_pmsr_capa failed in hwsim_new_radio_nl, the memory resources > applied for by pmsr_capa are not released. Add release processing to the > incorrect path. > > Fixes: 92d13386ec55 ("mac80211_hwsim: add PMSR capability support") > Reported-by: syzbot+904ce6fbb38532d9795c@syzkaller.appspotmail.com > Signed-off-by: Zhengchao Shao > --- > v2: move the value assigned to pmsr_capa before parse_pmsr_capa > --- > drivers/net/wireless/virtual/mac80211_hwsim.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) drivers/net/wireless changes go to wireless-next, not net-next. But no need to resend because of this. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches